nkkollaw / zubr Goto Github PK

View Code? Open in Web Editor NEW

99.0 7.0 6.0 152 KB

Wrapper library to fix inconsistencies in PHP's core functions

License: MIT License

PHP 98.62% Shell 1.38%

php php-7 php-library php-functions functions-beautifier wrapper conventions

zubr's People

Contributors

Stargazers

Watchers

Forkers

tommica ddziaduch radmen brzuchal dbergunder peterafh

zubr's Issues

Core/Array/array_chunk

Core/Array: array_search

Core/Array: array_combine

Core/Array: array_diff_uassoc

Core/Array: array_uintersect_assoc

Core/Array: array_map

Core/Array: array_replace_recursive

Core/Array: array_diff_key

Core/Array: array_intersect

Core/Array: array_pop

Core/Array/array_column

Core/Array: array_fill

Core/Array: array_udiff_assoc

Core/Array: array_shift

Core/Array: array_reduce

Core/Array: array_slice

Core/Array: array_udiff_uassoc

Core/Array: array_rand

Core/Array: array_flip

Core/Array: array_multisort

No tests?

I know that this library may be considered "just" a wrapper. Yet the lack of tests disturbs me a little.

Should they be included?

Core/Array: array_count_values

Core/Array: array_diff

Core/Array: array_intersect_uassoc

Core/Array: array_pad

Core/Array: array_key_exists

Core/Array: array_intersect_assoc

Core/Array: array_fill_keys

Core/Array: array_merge_recursive

Core/Array: array_flip

Core/Array: array_reverse

Guidelines are incomplete

IMO, we need to set the project's scope/objectives, and guidelines on every issue.

I added what I was personally interested in in the README: parameter order, underscores, etc. Guidelines could be moved to a dedicated file or the wiki as that would keep things more organized.

What problems do we tackle? Function naming for sure, but what about inconsistent errors? There might be more things that we can "fix".

Core/Array: array_diff_assoc

Core/Array: array_intersect_key

No name?

Although the namespace should IMHO be called PHP for clarity and readability, I think the project should have a somewhat recognizable name/repo name.

Even something like PHP-sane or PHP-wrapper.

Opinions..?

Core/Array: array_splice

Core/Array: array_keys

Core/Array: array_filter

Should we proxy or core functions?

Or just a subset which requires fixing?

Core/Array: array_udiff

Core/Array/array_change_key_case

Core/Array: array_push

Core/Array: array_diff_ukey

Core/Array: array_sum

Core/Array: array_merge

Fix parameter order

Parameters should follow the following rule:

Always 'subject', then 'keyword' (for example you'd say "search Google (%SUBJECT%) for %KEYWORD%").

That is, $haystack first, then $needle.

We would have to support all functions under "Core" (http://php.net/manual/en/extensions.membership.php#extensions.membership.core), and "Bundled" (http://php.net/manual/en/extensions.membership.php#extensions.membership.bundled).

I'm adding each function as an issue, so that whoever implements it can reference the issue while committing or doing pull requests.

I think we should do 1 function per commit/request, referencing the issue.

Would this work in your opinion?