njx / repoman Goto Github PK

Create a "content" type of match that searches for the query in title or description, and add "content=querystr", "title=querystr", and "description=querystr" as possibilities in the dropdown, so that they'll always match the currently-typed string and will be available if no other matches work.

Calling this "usability" since right now in order to do an ordinary keyword search you have to know to type "title=" or "description=".

Possibly a race condition with when we null out the result cache vs. when we retrieve the repos from the url?

Also, maybe placeholder text in queries.

This used to work, not sure how it broke.

We seem to end up rerendering a bunch of times for each event. It probably has to do with a combination of the fact that we rerender for any event on "children", plus the fact that we add an incomplete query when we "complete" an existing query, etc. We should somehow be smarter and only render once.

Instead of having big ugly query strings.

Instead of waiting till we've fetched all the pages.

That's Not the Node Way.

Or do a combination--e.g. use the github API to specify as much of the search as I can, and then do the rest of the filtering on the client.

Both design and performance. It's super slow to load right now.

Looks kind of squished horizontally.

So you can see number of bugs by assignee, etc., maybe in nice collapsible lists.

e.g. show "is pull" or "is not pull" instead of "pull_request.html_url is null"

Last used repos and query

I'd love to be able to see "pull requests assigned to me where the last update wasn't made by me" -- i.e. those that might be ready for re-review, not waiting on the other person. I think I'd define an "update" as either adding a comment or adding a commit.

If we add login back, it should just be from a "sign in" button on the main page.

Maybe allow "!assignee" as a synonym?

Because we're unauthenticated. Need to get a client id and send it in our requests.

It looks like StringMatch sometimes returns a slightly higher score for user= than for assignee= (but not always).

"Can't add same model to collection twice"

(Or find a different icon set.)

We're just dying right now.

Currently we have models for issues, but they're just a thin wrapper and we don't actually use them to update anything in the view (since repoman is only read-only for now). Conversely, we don't use models for fetching things like the list of labels/usernames for suggestions.

There's no real value in the current two-line display for query items, and it's confusing that it's not just the same as what you typed. Just make it the same and hide all the underlying syntax.

...since we're only dealing with open bugs right now.

Possible steps:

1. Make a bogus query (e.g. foo=null)
2. Click on it
3. Type "pull" to accept pull_request
4. Hit enter

Result: Doesn't properly replace it.