Thread termination with exception not handled? about ruby-mqtt

[JakubSzajna]

Hello!
I just run into that issue too. It's due to a fact that Exception here is in fact MQTT::Exception instead of ::Exception and I wonder if this is intentionally implemented that way? Because of that, if the connection is broken for some reason the thread dies silently and the only trace of that is in the logs.

I don't want to globally set abort_on_exception, but if using MQTT::Exception is intentional, maybe allowing one to set this value for the @read_thread specifically via some config option + having the issue described somewhere would be enough?

My fix for now is something like this:

MQTT::Client.prepend(Module.new do
  def receive_packet
    super
  rescue ::Exception => ex
    Thread.current[:parent].raise(ex)
  end
end)

[JakubSzajna]

I don't think this fixes the issue were talking about here. If I find some time, I'll create a PR to include a proposed solution in the gems code.

[phlegx]

@JakubSzajna but ruby-mqtt has this definition: mqtt.rb#L23

module MQTT
  ...
  # Super-class for other MQTT related exceptions
  class Exception < ::Exception
  end
  ...
end

Used here: mqtt/client.rb#L476

# Pass exceptions up to parent thread
rescue Exception => exp
  unless @socket.nil?
    @socket.close
    @socket = nil
    handle_close
  end
  Thread.current[:parent].raise(exp)
end

Is @socket.close and handle_close considered in your fix? How can I catch the exception in my case, described in the first comment of this issue?

[JakubSzajna]

@phlegx Yes, it does have this definition and it branches out from stdlib Exception.

rescue Exception => exp in MQTT module refers to MQTT::Exception instead of ::Exception though.
So it would catch exceptions like MQTT::Exception and everything that inherits from MQTT::Exception.
Errno::ECONNRESET does not have MQTT::Exception in it's ancestors chain, so it won't be catched in the rescue clause you mentioned.

The monkey-patch from my message wraps the whole receive_packet in the rescue clause, so every exception that will be raised inside receive_packet will be catched there and elevated to the parent thread. Hope this is the answer for your question :) It is supposed to make sure the exception from your initial message (and others from inside the receive_packet method) can be rescued. So this does not actually rescue from the exception, it just makes it rescue'able :) To catch this exception, use a rescue clause in a scope where you use MQTT::Client.connect method.

[phlegx]

@JakubSzajna can you write a PR please?

[phlegx]

Found similar PR #112 related to StandardError.

[Toucouleur66]

I don't think this fixes the issue were talking about here. If I find some time, I'll create a PR to include a proposed solution in the gems code.

any hope for this PR?