Coder Social home page Coder Social logo

Comments (6)

njh avatar njh commented on June 3, 2024

Thanks for reporting this.

I am not sure if the best thing to do is:

  1. Just revert #134
  2. Attempt to monkey-patch OpenSSL::SSL::SSLSocket, so that it support #getbyte

What do you think @tenderlove ?

from ruby-mqtt.

tenderlove avatar tenderlove commented on June 3, 2024

I think we should monkeypatch OpenSSL. If normal sockets support getbyte, and SSLSocket doesn't, then I think it's a bug in SSLSocket. I've sent a patch upstream. I'll try making a patch for ruby-mqtt, but I might need a day or two.

from ruby-mqtt.

njh avatar njh commented on June 3, 2024

@tenderlove fantastic! Thank you very much!

from ruby-mqtt.

Andy-Bell avatar Andy-Bell commented on June 3, 2024

Thanks both

from ruby-mqtt.

njh avatar njh commented on June 3, 2024

Hi @tenderlove. Do you think you might have time to create a patch for the lack of #getbyte in ruby-mqtt?

Would be good to make a new release of this gem.

from ruby-mqtt.

tenderlove avatar tenderlove commented on June 3, 2024

@njh I'm so sorry. I totally forgot to do this. I've done it and sent a PR #139

🙇

from ruby-mqtt.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.