nirvanaitsolutions / swapsteem

Peer to peer STEEM and SBD exchange via escrow

SwapsteemUi

SwapSteem is a peer-to-peer, no custodian exchange platform built on the Steem blockchain. The main vision behind Swapsteem is to create a platform to enable Steem users to trade their STEEM/SBD for Fiat, Cryptocurrencies tokens, or pretty much anything with other users. It is a completely open source software licensed under AGPL and the license and source code can found on our github repo. We have installed a dynamic system on the SwapSteem UI, where trading parties signal each other for instant trading, and we connect the trading parties together to relate their terms and conditions of trade,and upon agreement a trade is initiated between the users. For each trade a trusted escrow agent is assigned for the cases when a dispute arises between the parties involved in the trade.

How to contribute

• fork and Clone the repo
• Pick any task from the project board and get it assigned to yourself.
• Implement features or bug fixes in a feature branch
• Create a PR

swapsteem's Issues

Format User Reputation Correctly

It looks like you're displaying the raw rep rather than the correct reputation, but really the reputation should be formatted correctly to make it more user-friendly.

Currently, reputation shows as:

In javascript, it would be calculated in the following way based on the rep shown above.

let rep = 47004555430

rep = ((Math.log10(rep) - 9) * 9 + 25).toFixed(2);

Design error in create new listing

Describe the bug
When the FIAT option is selected in Market, more fields are added in the form and the form is superimposed on the Footer and Navbar

To Reproduce
Steps to reproduce the behavior:

1. Go to https://www.swapsteem.online/post-trade
2. Click on Market -> Fiat
3. See error

Expected behavior
The form was expected to expand but respecting the Footer and Navbar

Screenshots

Desktop (please complete the following information):

• OS: Windows 8
• Browser Chrome
• Version 72.0.3

Make the User experience more user friendly

Back
[ Task Request - Swapsteem ] Make the trade procedure more user friendly
0 comments
aneilpatel58
17 minutes ago3 min read
Repository
https://github.com/nirvanaitsolutions/swapsteem

Details
SwapSteem is a peer to peer exchange for Steem blockchain based tokens including STEEM and SBD. This task is created for issue on our project board.

User Story : As a swapsteem user, I want to Know the status of transaction and need ability to perform necessary actions during a trade. The required features include

Ability to CANCEL a trade once an order is created by another user on my trade advertisement.
Ability to ACCEPT a trade once an order is created by another user on my trade.
If accepted, I want ability to perform Escrow operations escrow_transfer, escrow_approve, escrow_release and escrow_dispute as per the status of transaction and order type.
Ability to view the current trade status
Ability to review the trade partner and escrow agent after trade.

Convert design to code - 100 steem + 1000 sweet

The design for the application is done and we need to convert it into actual web user interface.
Design files can be found in the url provided.

Add Search feature

User story : As a swapsteem user, I want the ability to search trade advertisements as per my trade type and trade pair.

Solution : The SearchBox component has already been created. A new SearchResult component needs to be created which will be populated with the date retrieved from the search API.

Create a vote selling market - 100 steem + 1000 sweet

Is your feature request related to a problem? Please describe.
There are some services already that sell votes for SBD/steem like @booster, @smartsteem etc. We need a market to enable users sell their votes for steem/sbd.
Describe the solution you'd like
A market page for votes like current UI with some additional fields and custom vote price logic.

Additional context
Requested feature in beta.

Add Crypto pairs to Swapsteem

Is your feature request related to a problem? Please describe.
This is an enhancement to existing application and overall business model. As a part of this task request, we want to enable trades with other Crypto currencies along with the regular fiat gateway. This essentially means that we now have two main verticals - 1. STEEM/SBD to Fiat 2. STEEM/SBD to Crypto
The process for trade will be same using the escrow transactions.

Describe the solution you'd like

1. Update the nav bar with new market links " Fiat Market " and ' Crypto Market "
2. Create different Buy and Sell components and routes for Crypto and Fiat pairs
3. Update post a trade to include to and from instead of ad_coin and currency.
4. Update Post a trade component to include BTC/ EOS address instead of bank details/PayPal
5. Update the prices wherever needed from the price API

Describe alternatives you've considered
TBD

*Additional context
TBD

Add broadcast feature for custom jsons

We need the front end to broadcast ads, orders, and messages. The broadcast method is already implemented, we need to collect data from user and send to blockchain via steemconnect sign feature.

Add websockets suppport for chat

Websockets based chat is faster as compared to the current rest API based messaging system. We need to use websockets instead of messages api for chat so that the front end is refreshed with the new messages as they come.

Create a help page

Is your feature request related to a problem? Please describe.
As a swapsteem user, I need to have a page where I can get support for my trades, ask questions, find freaquently asked questions and tutorials about how to use swapsteem.

Describe the solution you'd like
We need a help and support component where we will place

• tutorials
• FAQ
• Support Contact
  in a beautiful web page aligned with our current website design.

Describe alternatives you've considered
We need expandable sections with ability to expand/collapse over all sections and subsections.

Additional context
You can take inspiration from help, FAQ and support page of

• localbitcoins.com
• localethereum.com
• wazirx.com
• koinex.com

Responsive UI for mobile friendly app

Is your feature request related to a problem? Please describe.
Right now, The application is not optimized for UI designs. We need to make it responsive to look good on smartphones and tablet browsers.

Describe the solution you'd like
Use Angular Material for responsiveness.

Describe alternatives you've considered
We have bootstrap already installed but not configured. As an alternative.

Able to remove/update items from buy/sell panels within home page when hitting API directly.

Describe the bug
Currently, you have the ability to edit the details of trades for other users and in this scenario, I believe provide them information that corrupts their ability for them to be shown on the home page of the site.

To Reproduce
Steps to reproduce the behavior:

1. Using postman enter the following https://swapsteem-api.herokuapp.com/listings/`{add any listing id here}`
2. Click on any trade shown on SwapSteem and get the listing Id from the URL.
3. Replace the listing URL noted in the above URL with the listing Id gather from the listing on SwapSteem.
4. Configure the following body into the request:

{"createdby":"anlptl","ad_type":"SELL","market":"CRYPTO","payment_method":"Crypto Transfer","to":"BTC","margin":1,"limit_from":0,"limit_to":0,"restricted_amounts":[],"from":"STEEM","ad_status":"open","ad_coin_amount":1,"terms":"1","ad_details":{"minimum_volume":0,"minimum_reputation_score":25,"new_buyer_limit":0,"track_liquidity":true},"security_details":{"identified_people_only":true,"identify_user_before_continuing_trade":true,"real_name_required":true,"sms_verification_required":true,"trusted_people_only":true},"payment_details":{"account_holder_name":"","account_number":0,"bank_name":"","bank_address":"","swift_bic_code":"","bank_code":"","paypal_email":"","upi_id":"","crypto_address":"2"}}

5. The request should be set to a PUT request and should have no authentication assoicated to it.
6. Send the request within postman.
7. Refresh the home page and note that listing Id you previously clicked is no longer shown on the home page.

Video
The following video shows the issue in more detail:

https://www.youtube.com/watch?v=qD6DokokNhg&feature=youtu.be

Enviroment

Browser: Google Chrome (Version 71.0.3578.98 (Official Build) (64-bit))
Device: MacBook Pro (Retina, 15-inch, Late 2013)
Operating system: MacOS Mojave Version 10.14.1 (18B75)

Additional context
Currently, there is no authentication that prevents a user from editing a trade, there should be authentication that checks to see if the users are A) who says he is and B) has the ability to edit that particular item.

I would recommend adding a middleware than passes in the JWT token provided by SteemConnect prior to any PUT, POST, DELETE & PATCH (GET if you want it to) to verify that the user is who he says he is and then make another check to make sure that the user who you have verified is authenticated to edit that trade an example of the SteemConnect verification from one of the apps I did:

https://github.com/tobias-g1/contest-hero/blob/master/server/src/middleware/check-steemconnect.js

Add Escrow fees and trade amount validations

Is your feature request related to a problem? Please describe.
The Escrow fees are the main revenue source for Swapsteem. Currently we have hardcoded the Escrow fees as 0.001 Steem for testing purpose. But now, we need to calculate and display the fees for the trade before making a transaction.
The fees are 1% on the trade amount for alpha users.
The trade amount should be more than 20 Steem/SBD.
Describe the solution you'd like
In the purchase/order component, display the fees required to undergo the transaction and add the fees to escrow transfer url.

Additional context
Critical issue for alpha

Accessing swapsteem.online (without www. )fails on mobile chrome

Describe the bug
Site doesnt open without adding www. on mobile browser

To Reproduce
try accessing swapsteem.online with chrome on mobile

Expected behavior

i expected swapsteem.online to be redirected to www.swapsteem.online when accessed on mobile.
it redirects to https://shortener.secureserver.net/error_404 instead.

Screenshots

Browser: Google Chrome (Version 71.0.3578.98
Device: Tecno camon xpro
Operating system: Android 0

Add UPI as Payment method for INR trades

Is your feature request related to a problem? Please describe.
As a Swapsteem user from India, I want to have UPI as payment method. UPI is generally faster and easier to use than bank transfers and PayPal.

Describe the solution you'd like
While creating a trade listing a user can select UPI as payment method from the drop-down. Also we need to add appropriate textbox to get the UPI id from the seller while creating a sell listing or sell order.

Additional context
This feature is required in the alpha.

Add auth guards for keychain - 30 steem + 300 sweet

Is your feature request related to a problem? Please describe.
Keychain is an authentication provider similar to steemcoonect. We need to add auth guards to protect user data from being accessed by others.
Describe the solution you'd like
Add strategy for keychain auth in auth guard.

Describe alternatives you've considered
This will move to steem account connection after login is moved to email
Additional context
Keychain is more secure than steemcoonect.

Replace the Price API with coingecko

Is your feature request related to a problem? Please describe.
For now, we are using the cryptocompare API to get the prices, but we have seen some huge different in prices for some specific Currencies. We believe this is because we don't have too many spots for STEEM coins yet on cryptocompare. So we ahve decided to move the price API to coingecko, an awesome open source project.

Describe the solution you'd like
While calculating the trade value, we want to fetch the exact price for the pair Just replace the current price API to coingecko instead of cryptocompare

curl -X GET "https://api.coingecko.com/api/v3/simple/price?ids=usd&vs_currencies=inr" -H "accept: application/json"

Add phone number verification

We need to verify users phone number by sending a 6 digit OTP and validating it. If a user has not verified his phone number, he should not be able to see or order a trade which has been marked "required sms verification".

Use Environment variables instead of hardcoded values for API urls and keys

Is your feature request related to a problem? Please describe.
Keeping the environment variables in the codebase is a bad practice and highly prone to a security attack if exploited.

Describe the solution you'd like
A We want all the environment variables to be loaded from an environment config.

Describe alternatives you've considered
This feature can be implemented via environments feature by angular-cli or via dotenv npm package.
Additional context
This feature is related to security and needed in alpha and later releases.

Add countdown timer and angular material

Is your feature request related to a problem? Please describe.
As a swapsteem user, I want the ability to see the time remaining before an escrow approval and release.
Also, I want to see enhancement in loading speed of pages by implementing angular material.

Describe the solution you'd like
I need to see an attractive timer on the front end instead of a "please wait" message as shown below

Create a Terms and Conditions page and make compulsory to be accepted.

Is your feature request related to a problem? Please describe.
As a swapsteem user I want to know the Terms and conditions of service and ability to accept/deny it.

Describe the solution you'd like
Create a ToS page and display it to user until he confirms it. Once confirmed, store the user in db as ToS accepted.

Additional context
We will need to do some changes to api to include users too.

Replace auth strategy with email and password - 50 steem + 500 sweet

Is your feature request related to a problem? Please describe.
Right now, it's must to have a steem account in order to be able to trade on swapsteem. It costs at least $2 to create a new account so it is nice to have free email authentication.
Describe the solution you'd like
Login and Sign up button should redirect to email login or sign up form respectively.

Describe alternatives you've considered
If possible, we also need to add 2FA with SMS/email/Google authenticator for security purpose.
Additional context
This is a must have feature for beta.

Add encryption for sensitive data

We are dealing with fiat money here, so privacy is our first concern. we want to encrypt the sensitive data e.g. real name, phone number, email or any personal info, also need to encrypt any bank or payment details to avoid being seen by anyone other than the recipient.

Account Details don't save when posting a trade

Describe the bug
When posting a trade, bank account details don't save.

To Reproduce
Steps to reproduce the behaviour:

1. Post a trade
2. Select the type of Buy
3. Fill in all empty values with the value "1"
4. Publish the trade.
5. Once created, go back and view/edit your recently created trade.

Expected behaviour
All details entered the form should be saved and ready

Screenshots

Desktop (please complete the following information):
Browser: Google Chrome (Version 71.0.3578.98 (Official Build) (64-bit))
Device: MacBook Pro (Retina, 15-inch, Late 2013)
Operating system: MacOS Mojave Version 10.14.1 (18B75)

Additional context
Looks like an unimplemented feature, as in the request it doesn't seem to be sent.

{"createdby":"votezilla","ad_type":"BUY","country":"","payment_methods":"Bank Transfer","currency":"USD","margin":0,"limit_from":0,"limit_to":0,"restricted_amounts":[],"ad_coin":"STEEM","ad_status":"open","ad_coin_amount":1,"terms":"1","ad_details":{"minimum_volume":0,"minimum_reputation_score":25,"new_buyer_limit":0,"track_liquidity":true},"security_details":{"identified_people_only":true,"identify_user_before_continuing_trade":true,"real_name_required":true,"sms_verification_required":true,"trusted_people_only":true}}
~``

Need content for Help, Faq, ToS and tutorials page

We need the following content :

• FAQ( Frequently asked questions )
• ToS ( Terms of Service )
• Tutorials ( How To's)

Contributors can refer http://localbitcoins.com for reference since our business model is similar to theirs in some features.

Add Profile feature

Is your feature request related to a problem? Please describe.
As a swapsteem user, I need the ability to see other traders' profile, which shall display his currently open listings and previous order reviews.

Describe the solution you'd like
We would need to create an additional component for route "/profile/:@ and display the profile data from the API.

Add Referral feature - 30 steem + 300 sweet

Is your feature request related to a problem? Please describe.
We are seeing low number of users on our app. Mouth publicity with referral system can help us get more users onboard. We can reward users for referrals.

Describe the solution you'd like
We want a new page to be created for referrals. Users will be displayed their referral link and rewards in the referral pag.

Implement Request a loan feature

As a part of this issue, we need to create a page to enable users to request a loan from @swapsteem as per the agreement provided by us.

User story : As a swapsteem user, I want to have a get loan feature where I can request for a loan from swapsteem.

To request a loan, I will need to agree with the terms and conditions of the loan. If agreed, an entry for a loan request should be created in the database with loan status as loan_requested.
We also need to get the type of collateral for the loan. There can be two types of collaterals,

• Liquid Steem/SBD ( max loan amount 50% of collateral)
• SP and Account keys ( max loan amount 70% of collateral)

Components

We need to create a new component for loan requests

Update the UI - 100 steem + 1000 sweet

Is your feature request related to a problem? Please describe.
Currently the market UI shows all coin listings in same table. We need to separate the listings in different pages according to the trade pair selected. Also we need to replace the current banner with a price chart on the top.
Describe the solution you'd like
Change the UI to look like steem-engine.com

Describe alternatives you've considered
Use d3.js for displaying charts
Additional context
This is a feature required in beta

Add Steem Keychain for authentication and Signing - 50 steem + 500 sweet

Is your feature request related to a problem? Please describe.
Currently we are using steemconnect for authentication and Signing transactions with the Steem blockchain, which makes us heavily dependent on the steemconnect server. STEEM keychain is a promising project that can help us in cases of steemconnect downtimes and makes the user experience seamless.
Describe the solution you'd like
The application now should check for keychain installation in the browser, and show keychain as signing client wherever needed. This includes

• Log in/out
• Sign an escrow transaction

Additional context
STEEM keychain : https://github.com/MattyIce/steem-keychain
Angular Implementation : https://github.com/steeveproject/ngx-steem-keychain

Improve UI - Show current username in top nav

Is your feature request related to a problem? Please describe.
As a swapsteem user, I want to see my username on top nav. In case, I use two accounts, I am sometimes confused about the current logged in account.

Describe the solution you'd like
Replace the "Logout" Text with current logged in username. Add a drop-down and move the right menu links in the drop down. Use https://fontawesome.com/v4.7.0/icon/sign-out

Add deployment support to heroku

Account holder name value bound to same data as SWIFT/BIC code

Describe the bug
If you type in the name field within a BUY type trade, the SWIFT/BIC code value will also be filled.

To Reproduce
Steps to reproduce the behavior:

1. Sign into Swapsteem & select post a trade
2. Select ad type as buy
3. Enter a name
4. Note that SWIFT/BIC code is also filled in.

Expected behavior
Each item within a form should be bound to its own data.

Screenshots
The following GIF helps show this issue in more detail:

Desktop (please complete the following information):
Browser: Google Chrome (Version 71.0.3578.98 (Official Build) (64-bit))
Device: MacBook Pro (Retina, 15-inch, Late 2013)
Operating system: MacOS Mojave Version 10.14.1 (18B75)

Add connect steem account button in profile - 20 steem + 200 sweet

Is your feature request related to a problem? Please describe.
Once auth is moved to email, we will need to connect the user account to his steem account via steemcoonect authentication.

Describe the solution you'd like
Add a connect steem account button in profile page which will redirected to steemcoonect/keychain auth..

Additional context
This should be done after email auth implementation

Enable whitelisted users only to log into our alpha

Is your feature request related to a problem? Please describe.
As the owner of swapsteem, I would like to have a feature to enable only whitelisted users to access the alpha. The whitelist will be maintained at the back end and users can apply for early access using a google form?

Describe the solution you'd like
I want a check to be implemented at the front end so that only the users returned from our whitelist api are only logged in.

Additional context
This feature will be implemented in our alpha.

Add Route guards for authentication to all routes

Describe the bug
As a swapsteem user, I can access some pages even without being logged in, using the url that can be aquired from a logged in session.

To Reproduce
Steps to reproduce the behavior:

1. Copy url of a order while logged in.
2. Log out and paste the previously copied url in url box and hit enter
3. You can still see the order details and actions.

Expected behavior
As a swapsteem user, I should not be able to access any protected routes which includes-

1. order route
2. profile route
3. wallet route

Screenshots
None

Save the users details to backend if not already stored

Is your feature request related to a problem? Please describe.
When a user logged in, we need to store the user data to DB. Currently we are directly using steemconnect for authentication without storing the user data on the API.

Describe the solution you'd like
After successful log in, we need to send a post request to the API with the user data return by the Steemconnect API as req body. This will create a new user in db and update the DB if the user already exists.

Minor issue with menu text

Describe the bug
First Navigation menu item should be spelled 'Crypto Market' instead of 'Crpto Market'

To Reproduce
Steps to reproduce the behavior:

1. Go to https://www.swapsteem.online/home
2. First menu item is spelled 'Crpto Market'

Expected behavior
Menu should be spelled 'Crypto Market'

Screenshots

Solution
Change following line in /src/app/app-nav/app-nav.component.html

<a class="nav-link" routerLink="market/crypto">Crpto Market</a>

To

<a class="nav-link" routerLink="market/crypto">Crypto Market</a>

Desktop (please complete the following information):

• OS: [e.g. iOS]: OSX 10.11.6
• Browser [e.g. chrome, safari]: Chrome Version 69.0.3497.100 (Official Build) (64-bit)

Create a PWA for Swapsteem

Is your feature request related to a problem? Please describe.
Since most users are on mobile, we must provide a PWA.

Describe the solution you'd like
Use angular cli to create PWA

Post a good trade tweaks and features

User Story : As a swapsteem user, I want to post a trade listing/advertisement with a price based on price derived from my custom pair from an exchange of my choice. This feature includes

1. Ability set custom price based on data retrieved from user selected exchange and pair.
2. Ability to PAUSE my trade listing.
3. Ability to DELETE my trade listing.
4. Ability to EDIT my trade listing.

Add steemmonsters market - 100 steem + 1000 sweet

Is your feature request related to a problem? Please describe.
This is a new market Request. Steemmonsters.com is a card based game popular on steem. It has collectible cards that can be traded for steem or other currencies. We need to add ability to trade those monsters for steem/SBD.
Describe the solution you'd like
Add a new steemmonsters market page and link to it on top nav.
See peakmonsters.com or steemmonsters.com for market UI .
Additional context
We can not reuse the current UI as steemnsters have more properties than coins/Fiat.

UI Tweaks and Features

Is your feature request related to a problem? Please describe.

• No loading indicator
• No Pagination
• No Message for empty table

Describe the solution you'd like

• A loading indicator whenever an API call is in progress and view is updating the data. Wherever possible.
• Implement pagination in case of large number of rows in tables. You are free to use any pagination technique.
  -Display "No Data! Go play Around to see something here" message when there is no data in the table.

Describe alternatives you've considered

• Server side pagination ( In Roadmap)

Additional context
This is to make sure users have a great experience while using our application.

Add websocket support for notifications

We have the notifications API ready and need to implement real time notifications to be shown to user.
Notification route is created.

Fixed Footer Prevents Call to Action (Post Trade)

Describe the bug
The footer shown the bottom of the page prevents the post-trade option from being clickable.

To Reproduce
Steps to reproduce the behavior:

1. Select Post a Trade
2. When on the post a trade form, select the following options:

Ad Type: BUY
From: STEEM
Market: Fiat

3. Note that the height of the form changes, now scroll to the bottom of the page and view the post-trade button.

Expected behavior
The call to action shown at the bottom to submit a trade should be clearable clickable or the page should have enough overflow to allow me to click this option easily.

Screenshots

The following screenshot shows this issue in more details when I have scrolled to the bottom of the page.

Environment

- Browser: Google Chrome (Version 71.0.3578.98 (Official Build) (64-bit))

• Device: MacBook Pro (Retina, 15-inch, Late 2013)
• Operating system: MacOS Mojave Version 10.14.1 (18B75)

Additional context


In my personal option the easiest fix for this issue would be to remove the fixed on the footer to it only to display when a user reaches the bottom of the page, the goal here is not for a user to see who made the application, the goal should be to allow them to view and create trades, removing the fixed on the footer would resolve this issue and prevent any overlap.

Details surrounding the class I mean can be seen here:





If you choose to keep the footer the, this could also be resolved quickly by applying height: calc(100vh - 25px) on the main body of the page. This can be seen here:

Note I did not apply this to be box class as I assume this is shared through the side and I assume this is only one the problem areas due to the variable width based on the form size.

With the above said I think the table on the home page could also benefit from an adjustment to the footer.

I would also recommend that the shadow is changed the footer as it's too strong and doesn't work cosmetically. Not that you asked my opinion ;)

[Performance] Observable are not unsubscribed leading to higher CPU use

Describe the bug
Swapsteem code uses RxJS to subscribe to changes in data. RxJS in-turn use Observable which are Infinite Subscriptions. This means that the code will execute even without a subscribe being called unlike http.get where call will only be made when you subscribe to it. This causes a performance and memory hog as you exit and re-enter a controller because you are subscribing to same service multiple times. You can find more details in the stack overflow discussion here: https://stackoverflow.com/a/41177163/1141542

To Reproduce
This problem can be observed in dozens of places throughout the code. Below is a discussion on one such scenario and a fix for the same.

terms-and-conditions.component.ts

  this.auth.getUserData().subscribe((scAuthService) => {
        this.ngxService.stop();
        if (scAuthService) {
          this.auth.userData = scAuthService;
        }
        this.dialogRef.close();
      })

Expected behavior
Above code can be re-written as.

  this.auth.getUserData().pipe(takeWhile(() => this.isAlive)).subscribe((scAuthService) => {
        this.ngxService.stop();
        if (scAuthService) {
          this.auth.userData = scAuthService;
        }
        this.dialogRef.close();
      })

When controller destroys set isAlive to false

  ngOnDestroy() {
    this.isAlive = false;
  }

Add Steem account creation Feature

Is your feature request related to a problem? Please describe.
In order to use swapsteem, it is mandatory to have a steem account. I want to a Sign Up feature to enable users create Steem accounts instantly by paying via debit/credit card.

Describe the solution you'd like
We need a Sign-Up button when the user is logged out. The sign-up button should redirect the user to an account creation page/modal as per the steem.account.ninja API.

Describe alternatives you've considered
We can implement account creation from our own RC in the future.

Additional context
Check the account creation feature on steempeak.com

Add feedback and review features

Users should be able to provide feedback related to the trade after completion. Both parties will be able to review the opposite party on a scale of 1-5 and also write a text feedback for future traders to be able to see.

Site doesn't load via https://

Describe the bug
Attempting to load the site via https:// doesn't work a user cannot view the site.

To Reproduce
Steps to reproduce the behaviour:

1. Go to https://www.swapsteem.online/

or

1. https://swapsteem.online (as specified in the bio)

Expected behaviour
A user should be able to access the site via https://, the fact this site holds bank details and doesn't work https:// is quite an issue.

Screenshots
If applicable, add screenshots to help explain your problem.

Browser: Google Chrome (Version 71.0.3578.98 (Official Build) (64-bit))
Device: MacBook Pro (Retina, 15-inch, Late 2013)
Operating system: MacOS Mojave Version 10.14.1 (18B75)

Additional context
If you've got specific issues with it not working via https:// let me know as I had some troubles to when working with Heroku.

Profile Images don't load on wallet

Describe the bug
When viewing a users profile on the profile page, the profile image doesn't display correctly.

To Reproduce
Steps to reproduce the behavior:

1. Go to your wallet.
2. Note that the profile image doesn't load.

I suspect this isn't happening to every user, this may not be able to replicate.

Expected behaviour
A user's profile image should always be displayed correctly.

Screenshots
The following screenshot provides additional clarity surrounding the issue:

Browser: Google Chrome (Version 71.0.3578.98 (Official Build) (64-bit))
Device: MacBook Pro (Retina, 15-inch, Late 2013)
Operating system: MacOS Mojave Version 10.14.1 (18B75)

A simple a more flexible solution would replace:

this.profile_url = this.profile && this.profile.profile ? this.profile.profile.profile_image : '';

so that the profile image is no longer pulled from the json_metadata, this prevents a number of issues that can pop up surrounding profile images not being loaded correctly. If you instead use:

https://steemitimages.com/u/${username}/avatar

This would also handle broken images with a fallback.

Add ERC20 market - 30 steem + 300 sweet

Is your feature request related to a problem? Please describe.
This is an enhancement to current application. ERC20 tokens are ethereum based tokens that can be traded for any other Fiat or Cryptocurrencies. We need to add a market for erc20 tokens and add BNB and TUSD coins for now. We will add more erc20 later.
Describe the solution you'd like
Create a new market page for erc20 and provide a link in top nav.

Additional context
This should use the latest market UI