Coder Social home page Coder Social logo

Nested messages conflicts about protolock HOT 7 CLOSED

nilslice avatar nilslice commented on May 30, 2024
Nested messages conflicts

from protolock.

Comments (7)

celrenheit avatar celrenheit commented on May 30, 2024 1

Yep sorry for the confusion.
I'll try to have a look into it whenever I have time

from protolock.

nilslice avatar nilslice commented on May 30, 2024

Interesting -- thank you for reporting! This is definitely a bug. I will need to update the tests to contain nested messages. Can I ask, what did you expect the output to be?

You mention:

The following example should trigger a conflict:

What would you expect the conflict to be?

from protolock.

celrenheit avatar celrenheit commented on May 30, 2024

I expected it to not have a conflict

from protolock.

nilslice avatar nilslice commented on May 30, 2024

@celrenheit - ok, perfect, that's what I figured but was confused (should vs. shouldn't in your comment).

Is this something you'd like to try fixing? No problem if not, just didn't want to duplicate efforts.
Thanks again!

from protolock.

nilslice avatar nilslice commented on May 30, 2024

@celrenheit - would you please try #16? I believe it should fix this issue.

from protolock.

nilslice avatar nilslice commented on May 30, 2024

I've tested this internally enough to feel confident in the fix. @celrenheit - I'm going to merge, but if you get around to it, please update your binary and test as well. I'd would appreciate it!

from protolock.

celrenheit avatar celrenheit commented on May 30, 2024

This fixed the issue but by ignoring nested messages.
I've submitted PR #17 which also checks to not reuse reserved fields in nested messages.

from protolock.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.