Comments (7)
Yep sorry for the confusion.
I'll try to have a look into it whenever I have time
from protolock.
Interesting -- thank you for reporting! This is definitely a bug. I will need to update the tests to contain nested messages. Can I ask, what did you expect the output to be?
You mention:
The following example should trigger a conflict:
What would you expect the conflict to be?
from protolock.
I expected it to not have a conflict
from protolock.
@celrenheit - ok, perfect, that's what I figured but was confused (should vs. shouldn't in your comment).
Is this something you'd like to try fixing? No problem if not, just didn't want to duplicate efforts.
Thanks again!
from protolock.
@celrenheit - would you please try #16? I believe it should fix this issue.
from protolock.
I've tested this internally enough to feel confident in the fix. @celrenheit - I'm going to merge, but if you get around to it, please update your binary and test as well. I'd would appreciate it!
from protolock.
This fixed the issue but by ignoring nested messages.
I've submitted PR #17 which also checks to not reuse reserved fields in nested messages.
from protolock.
Related Issues (20)
- Lock file does not record aggregate options with array values HOT 3
- Website incorrectly reports backwards compatibility with invalid proto files HOT 2
- Error building protolock on ppc64le HOT 2
- Processing a single file HOT 3
- Enum aliases not supported HOT 3
- Does protolock support proto2 ? HOT 1
- Propose to publish ARM64 binary in releases HOT 6
- Convert circleci jobs to GitHub Actions
- oneof structure is not persisted in protolock HOT 4
- Options not parsed at the Enum level HOT 2
- found "stream" but expected [rpc method] for a valid proto HOT 3
- Add artefacts to Maven repository HOT 4
- Update docker hub image HOT 3
- Allow ability to include proto files that are not in the root tree
- TestOrder consistently fails
- Nit: typo in info string for protolock cmd HOT 1
- [.gitignore] Remove "protolock" line or edit file to not filter out "cmd/protolock" HOT 1
- False positive in camelCase naming violation for EnumValueOptions builtin HOT 1
- Embedded comments confuse the parser HOT 7
- Deeply nested messages may conflict HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from protolock.