oneof structure is not persisted in protolock about protolock

[YaseenAlk]

I also noticed that oneof options are not recorded (options can be written on enum types, enum values, oneof fields, service types, and service methods).

@nilslice If there is anything I can do to help, let me know! Happy to work on a PR, just wasn't sure if this has been previously rejected. Either way I will likely make these changes to my own fork if they are not desired for the main protolock repo

[nilslice]

Hi @YaseenAlk -

From reading the wiki, it's my understanding that the preferred way to add more rules is to implement them in a plugin, which takes as input a Protolock go struct that is built from the output of the proto parser.

Yes, that's right - a plugin is probably the best way to go. Ideally protolock itself is only about catching compatibility issues on the most critical & common kinds of API changes. There are some examples in different languages (Go, JS) in the plugin-sames dir.

I would like to hear your thoughts on this and whether this was previously considered and rejected, or if there is a way to find oneofs in the plugins that I am not aware of. Happy to also author a PR or help out however I can! [...] I also noticed that oneof options are not recorded (options can be written on enum types, enum values, oneof fields, service types, and service methods).

There are a few places where there may be missing implementations (though I believe protolock is fairly comprehensive), and I would love to have help filling in any gaps you find. With regard to your specific need, I think recording options on oneof types is a great addition, and a PR would be welcomed.

Thank you!