nils-van-zuijlen / caravane Goto Github PK

in src/ForumBundle/Controller/ForumController.php, line 158

The AccessDeniedHttpException bypasses the Symfony Security component and always results in a 403 response. You should throw AccessDeniedException (without Http) instead, so that the Security Component displays a login form.

		if (
			$forum->getUser() != $this->getUser()
			&& !$this->get('security.authorization_checker')->isGranted('ROLE_COMMUNICATION')
		)
		{
			throw new HttpException\AccessDeniedHttpException(
				'Vous n\'êtes pas autorisé à modifier le forum '.$forum
				);
		}

		$form = $this->createForm(ForumType::class, $forum);

Posted from SensioLabsInsight

in composer.json

Defining autoload.psr-4 with an empty namespace prefix is a bad idea for performance

Posted from SensioLabsInsight

Utiliser DForumBundle au lieu d'un mélange mauvais du FOSCommentBundle et de code personnel.

use bootstrap navbar-collapse class in order to collapse the navbar

Création du controlleur et au moins de la page d'index de celui-ci.

in src/CoreBundle/Form

A form type has been found outside Form/Type folder

src/CoreBundle/Form/
├── ActusEditType.php
├── ActusType.php
├── ChefsEmailFormType.php
├── ContactType.php
├── EventType.php
└── MyFileType.php

Posted from SensioLabsInsight

Posted from SensioLabsInsight

Externalisation de tout le texte vers des fichiers de traduction.

Page(s) des responsables matériel

in src/ResponsabilitesBundle/Repository/MenuRepository.php, line 24

The Paginator class resolves to the following class: Doctrine\ORM\Tools\Pagination\Paginator.
Did you forget to add a corresponding use statement?

		$query
			->setFirstResult(($page-1) * $nbPerPage)
			->setMaxResults($nbPerPage);

		return new Paginator($query, true);
	}
}

Posted from SensioLabsInsight

En particulier, le <title>

❗ ❗ ❗ ❗

With booleans, only strict comparison (with !== operator) should be used to lower bug risks and to improve performances.

Posted from SensioLabsInsight

Possibilité de bannir des utilisateurs à partir du chat.
Affichage de l'état.
Réhabilitation des utilisateurs.

in src/ResponsabilitesBundle/Entity/Objet.php, line 69

The parameter type, which is an object, should be typehinted.

	public function getType()
	{
		return $this->type;
	}
	public function setType($type)
	{
		$type->addObjet($this);
		$this->type = $type;
		return $this;
	}

Posted from SensioLabsInsight

in src/CoreBundle/Mailer/ChefsEmail.php, line 24

Boolean property accessor should not be setIsXXX nor getIsXXX but setXXX and isXXX.

	public function setSubject($subject)
	{ $this->subject = $subject; }
	public function setBody($body)
	{ $this->body = $body; }
	public function setIsBcc($isBcc)
	{ $this->isBcc = $isBcc; }
	public function setToUsers($toUsers)
	{ $this->toUsers = $toUsers; }
	public function setToGroups($toGroups)
	{ $this->toGroups = $toGroups; }

Posted from SensioLabsInsight

Like PHPUnit.

in composer.json, line 1

description : The property description is required

{
    "name": "nils/caravane",
    "license": "proprietary",
    "type": "project",
    "autoload": {
        "psr-4": {

Posted from SensioLabsInsight

New reactions for the chatbot

Ajout des descriptions des différentes responsabilités aux pages d'index des responsabilités

in src/UserBundle/Controller/GroupController.php, line 117

This formFactory local variable is declared but never used. You should remove it.

	public function newAction(Request $request)
	{
		/** @var $groupManager \FOS\UserBundle\Model\GroupManagerInterface */
		$groupManager = $this->get('fos_user.group_manager');
		/** @var $formFactory \FOS\UserBundle\Form\Factory\FactoryInterface */
		$formFactory = $this->get('fos_user.group.form.factory');
		/** @var $dispatcher \Symfony\Component\EventDispatcher\EventDispatcherInterface */
		$dispatcher = $this->get('event_dispatcher');

		$group = $groupManager->createGroup('');

Posted from SensioLabsInsight