nikolowry / bromite-builder Goto Github PK

When attempting to build chrome_modern_public_apk with arm64 and Bromite's supplied GN args, the following fatal error will be thrown during builds due to enable_av1_decoder=true:
error: undefined symbol: aom_arm_cpu_caps

To temporarily get around this issue, enable_av1_decoder=true is being removed from Bromite's supplied GN args. Still need to determine if this is isolated to arm64 or if the same error is thrown with arm

@csagan5 how are you currently able to build arm64 with AV1?

Needed for:

• Reducing fetch-sync times
• Avoiding any non-free binaries
• Complete removal of Google Play deps in BUILD.gn, forcing to only use the system-only versions of packages/classes - following that aar blobs can be discarded

Related:

• Confirm all scripts in depot_tools are human-readable (majority are Python scripts, but verification is needed)

Todo:

• Setup a build bot that runs automatically on new Bromite releases
• Have bot push successful builds to a release tag

Only add exclude args to the git clean in fetch-sync when a build's arch type and version match that of a previously successful build.

This will make building ninja target variants quicker, but also ensure clean environments when building new or old versions.

More research is needed, but it seems like ShellCheck is the go-to for shell linting.

Resources:

• https://github.com/koalaman/shellcheck
• https://www.shellcheck.net/

Todo:

• git pre-commit hooks
• Add contributing/development notes to README. This should include links to the linter docs and more specifically on how to integrate the linter into editors

In case you are interested, the /e/ foundation people have created a Docker-based build system that seems to work on GitLab: see https://gitlab.e.foundation/e/apps/browser/blob/master/.gitlab-ci.yml and the Dockerfile in same repo.

I was not aware of this until a few minutes ago and I thought to tell you, in case it might be useful.

By the way, I am glad to see you are supporting this builder and I learnt for example from the README here that jumbo builds are being phased out; perhaps I should follow the chromium mailing list more closely :)