niklaspor / ngrx-clean-forms Goto Github PK

@PhilippSeitz

The strong typing is a large part of the framework.
Having error types available in the template would be great.

If you copy and paste text values in safari, you can not edit it in the middle of the word. The cursor automatically jumps to the end of the text.

Hey man,

I really like your work, however I feel that the ngrxControl directive should rather be named ngrxFormControl to increase clarity.

This is all for now.

The current Readme file is missing information about the usage of the FormArray.
It should be added in the chapter Additional Resources.

For an easy usage of the package a complete documentation of the public-api is necessary.

This should only target the apis which will exist after #2 is resolved.

The example app should be available at a hosted domain.

• changed: true -> ng-changed
• initial: false -> ng-initial

should be:

• changed: true -> ng-changed
• changed: false -> ng-initial

The methods:

• mapFormControlStates
• mapFormControlSummaries
• mapFormControlUpdates

Should be renamed to:

• mapFormGroupControlStates
• mapFormGroupControlSummaries
• mapFormGroupControlUpdates

As they are only FormGroup specific this will increase the clarity.

Pristine behaviour inside @angular/forms marks if the value was changed in any way, but does not get reverted if it was changed back.

Add a method for resetting a form. Should keep the validators and except for that reset to the initialValue.

An option for resetting to a specific value would also be helpful.

• resetFormControl
• resetFormGroup
• resetFormArray

Reduce the width of the public-api. This will lead to an easier usable package.

The reducers & init directories are already in a valid shape.

• Cleanup selectors
• Cleanup types
• Cleanup utils

The nesting of formGroups & formArrays is by intention not possible. This should be mentioned in the docs. Maybe add a faq.

The docs should show how to use FormArraySummary.keys to iterate over the controls of a FormArray.