nightkosh / advanced-fishing

Advanced Fishing

This mod adds new 43 fishes, blaze fishing rod, luck potion recipe and overrides fishing mechanics. All of the new and vanilla fishes can be catched only in own types of biomes, dimensions and liquids.

Luck potion recipe

Crafting recipes

Minecraft versions

"Master branch" contains mod sources for the latest version of the Minecraft I'm working on. Any previous versions contains in an own branches.

Requirements

1. Forge (check "build.gradle" file to know required forge version)
   • Latest versions of Forge requires Gradle 2.0 or higher
2. Version of the mod in "Master branch" requires jdk 1.8(do not forget to enable java 8 support in your IDE)

Get started

1. Clone mod repository
2. Download forge and copy "gradlew.bat", "gradlew" files and "gradle" directory to mod folder
3. Run "./gradlew setupDecompWorkspace idea"
4. Import mod to your ide as "new Gradle project"

advanced-fishing's Issues

API

• Splash particles for custom fluid
• Bubble particles for custom fluid
• Wake particles for custom fluid
• Catch for custom fluid
• Catch for custom biome type
• Amount of blocks of liquid for custom fluids
• New fishes enum
• Move API to submodule

Rename fishes

• snowy crucian -> snowy walleye
• cave fish -> cave trout
• specular fish -> specular snapper
• obsidifish - > obsidian bream
• nether salmon -> nether sturgeon
• pearl bass - > pearl sardine
• quartz cod -> quartz chub
• blaze cod -> blaze pike
• enderfin -> ender shad

Localization

https://github.com/NightKosh/Advanced-Fishing/tree/master/src/main/resources/assets/advanced-fishing/lang

• German - de_de
• English - en_us
• Spanish - es_es
• Portuguese (Brazil) - pt_br
• French - fr_fr
• Italian - it_it
• Russian - ru_ru
• Ukrainian - uk_ua
• Chinese (Simplified) - zh_cn
• Chinese (Traditional) Translation for Taiwan - zh_tw

This issue was created for monitoring of localization state, so checkboxes state will be changed in case of any changes in the appropriate localization files.

The current list of languages shows only already existed localization files, but if you can help with translation on any other languages - it will be great!

All untranslated blocks marked with "## TODO" to make it easier to find them. Please remove those marks in case of translation.

If you'd like to help with translation - please post here about your pull request / link on translated version, so all other contributors knew about it, and will not translate it again. Those comments will be removed from time to time, to make this issue clear.

Recipes in JSON

Fishing rod doesn't work for some reason

Minecraft Forge 1.12.2-14.23.5.2859

Advanced-Fishing-1.12.2-1.3.3

I just installed the mod on a dedicated server and on the client, tried it out, the server logs nothing, but the client logs this:

[17:15:52] [Client thread/ERROR] [FML]: Encountered an exception while constructing entity 'advanced-fishing:custom_fish_hook'
java.lang.reflect.InvocationTargetException: null
	at sun.reflect.GeneratedConstructorAccessor82.newInstance(Unknown Source) ~[?:?]
	at sun.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45) ~[?:1.8.0_345]
	at java.lang.reflect.Constructor.newInstance(Constructor.java:423) ~[?:1.8.0_345]
	at net.minecraftforge.fml.common.registry.EntityEntryBuilder$ConstructorFactory.apply(EntityEntryBuilder.java:305) ~[EntityEntryBuilder$ConstructorFactory.class:?]
	at net.minecraftforge.fml.common.registry.EntityEntryBuilder$ConstructorFactory.apply(EntityEntryBuilder.java:291) ~[EntityEntryBuilder$ConstructorFactory.class:?]
	at net.minecraftforge.fml.common.registry.EntityRegistry$EntityRegistration.newInstance(EntityRegistry.java:99) ~[EntityRegistry$EntityRegistration.class:?]
	at net.minecraftforge.fml.common.network.internal.EntitySpawnHandler.spawnEntity(EntitySpawnHandler.java:87) ~[EntitySpawnHandler.class:?]
	at net.minecraftforge.fml.common.network.internal.EntitySpawnHandler.process(EntitySpawnHandler.java:64) ~[EntitySpawnHandler.class:?]
	at net.minecraftforge.fml.common.network.internal.EntitySpawnHandler.lambda$channelRead0$0(EntitySpawnHandler.java:55) ~[EntitySpawnHandler.class:?]
	at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511) [?:1.8.0_345]
	at java.util.concurrent.FutureTask.run(FutureTask.java:266) [?:1.8.0_345]
	at net.minecraft.util.Util.func_181617_a(SourceFile:46) [h.class:?]
	at net.minecraft.client.Minecraft.func_71411_J(Minecraft.java:1088) [bib.class:?]
	at net.minecraft.client.Minecraft.func_99999_d(Minecraft.java:398) [bib.class:?]
	at net.minecraft.client.main.Main.main(SourceFile:123) [Main.class:?]
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) ~[?:1.8.0_345]
	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) ~[?:1.8.0_345]
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) ~[?:1.8.0_345]
	at java.lang.reflect.Method.invoke(Method.java:498) ~[?:1.8.0_345]
	at net.minecraft.launchwrapper.Launch.launch(Launch.java:135) [launchwrapper-1.12.jar:?]
	at net.minecraft.launchwrapper.Launch.main(Launch.java:28) [launchwrapper-1.12.jar:?]
Caused by: java.lang.NullPointerException
	at net.minecraft.entity.projectile.EntityFishHook.func_190626_a(EntityFishHook.java:75) ~[acf.class:?]
	at net.minecraft.entity.projectile.EntityFishHook.<init>(EntityFishHook.java:66) ~[acf.class:?]
	at nightkosh.advanced_fishing.entity.projectile.AbstractFishHook.<init>(AbstractFishHook.java:39) ~[AbstractFishHook.class:?]
	at nightkosh.advanced_fishing.entity.projectile.AbstractFishHook.<init>(AbstractFishHook.java:30) ~[AbstractFishHook.class:?]
	at nightkosh.advanced_fishing.entity.projectile.EntityCustomFishHook.<init>(EntityCustomFishHook.java:50) ~[EntityCustomFishHook.class:?]
	... 21 more

The bait just bounces instantly when touching the water.

Loot tables

IllegalArgumentException: bound must be positive

Caused by: java.lang.IllegalArgumentException: bound must be positive
	at java.util.Random.nextInt(Random.java:388) ~[?:1.8.0_60]
	at nightkosh.advanced_fishing.entity.projectile.EntityCustomFishHook.getCatch(EntityCustomFishHook.java:375) ~[EntityCustomFishHook.class:?]
	at nightkosh.advanced_fishing.entity.projectile.EntityCustomFishHook.handleHookRetraction(EntityCustomFishHook.java:319) ~[EntityCustomFishHook.class:?]
	at nightkosh.advanced_fishing.item.AbstractFishingPole.onItemRightClick(AbstractFishingPole.java:34) ~[AbstractFishingPole.class:?]
	at net.minecraft.item.ItemStack.useItemRightClick(ItemStack.java:234) ~[ItemStack.class:?]
	at net.minecraft.server.management.PlayerInteractionManager.processRightClick(PlayerInteractionManager.java:384) ~[PlayerInteractionManager.class:?]
	at net.minecraft.network.NetHandlerPlayServer.processTryUseItem(NetHandlerPlayServer.java:794) ~[NetHandlerPlayServer.class:?]
	at net.minecraft.network.play.client.CPacketPlayerTryUseItem.processPacket(CPacketPlayerTryUseItem.java:43) ~[CPacketPlayerTryUseItem.class:?]
	at net.minecraft.network.play.client.CPacketPlayerTryUseItem.processPacket(CPacketPlayerTryUseItem.java:9) ~[CPacketPlayerTryUseItem.class:?]
	at net.minecraft.network.PacketThreadUtil$1.run(PacketThreadUtil.java:21) ~[PacketThreadUtil$1.class:?]
	at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511) ~[?:1.8.0_60]
	at java.util.concurrent.FutureTask.run(FutureTask.java:266) ~[?:1.8.0_60]
	at net.minecraft.util.Util.runTask(Util.java:53) ~[Util.class:?]
	... 5 more

[SUGGESTION] Support for fishing rods from Just A Few Fish

As this mod adds some fish, would it be possible to add support for them through Just A Few Fish, and their respective fishing rods? It also does not pick up on your enchantments currently.

New Fishes

• Mandarinfish | jungle | very rare | experience
• Red Shroomfin | mushroom biome | normal | red mushroom
• Brown Shroomfin | mushroom biome | normal | brown mushroom
• Fungi Catfish | nether - lava | normal | nether wart
• Swamp Plaice | swamp | very rare | lily pad
• Crystal Mullet | 25 blocks | lazurit
• Charged Bullhead | 25 blocks | redstone
• Abyssal Lurker | deep ocean | rare | prizmarine shard
• Sunfish | savannah & sandy biomes | very rare | golden nugget
• Glacier Anchovy | snowy biomes | very rare | packed ice
• Catfish | ?| rare | -
• Pike | ?| normal | -
• Magikarp | trash

---

• Angler fish should be catched in the deep ocean not in caves | very rare | prizmarine crystal
• add sandy catch to savanna and mesa
• add snowy catch to taiga(conferouse)

---

gravestone mod fished in dead biome:

• green jellyfish
• bone fish
• cursed koi
• spookyfin

1.12.2 loot table crash

Thank you for reporting!

For issues:

• Try the latest version, it may have fixed the issue already.
• If you crashed, please paste the crash log to gist and link it here, or at least past it directly to the issue and embrace by "```".
• If it is possible provide your logs.
• Please provide your Minecraft version, Forge version and mod version.
• Any additional information how to reproduce your problem and screenshots will be helpful.

The crash when paired with other mods produces this crash result I fixed it by removing this mod from its directory sadly although great mod!

https://paste.dimdev.org/iwezibovek.rb

Edible fish

Couldn't cast.

For some reason this mod made my game crash when I attempted to cast any fishing rod.

crash logs attached.
crash-2019-03-03_20.28.23-client.txt

Other mod's fishing rod Compatible

can I not disabe all the thermal fishing rods?
after install, all the rods got unusable.
vanilla rod is good, but it have a lower durability.

minecraft：1.12.2
mod：1.3.3
Forge：14.23.5.2854

Crash when i got a fish (NoSuchMethodError)

Playing RLCraft 2.9.2 , Advanced-Fishing-1.12.2-1.3.3

When i get a fish (FishingEventHandler) crash whit NoSuchMethodError:

java.lang.NoSuchMethodError: levelup2.skills.SkillRegistry.getSkillLevel(Lnet/minecraft/entity/player/EntityPlayer;Ljava/lang/String;)I
at net.theawesomegem.fishingmadebetter.util.LevelUpLoot.getFishingLoot(LevelUpLoot.java:42) ~[LevelUpLoot.class:2.2.6]
at net.theawesomegem.fishingmadebetter.util.LevelUpLoot.doLevelUpLoot(LevelUpLoot.java:20) ~[LevelUpLoot.class:2.2.6]
at net.theawesomegem.fishingmadebetter.common.event.FishingEventHandler.onPlayerFish(FishingEventHandler.java:224) ~[FishingEventHandler.class:2.2.6]
at net.minecraftforge.fml.common.eventhandler.ASMEventHandler_1841_FishingEventHandler_onPlayerFish_ItemFishedEvent.invoke(.dynamic) ~[?:?]

The size of the lake

Size of the lake should affect on catching chance. There should be some minimal amount of blocks of liquid, otherwise your fishing chance will be reduced. Every type of liquid should has its own value.

Move all required content from Gravestone mod

NightKosh/Gravestone-mod-Extended#104

• Catch
• Fishing system
• EntityJoinWorldEvent
• EntityCustomFishHook

Neptunium tools/armor cannot be repaired

As subject says, neptunium armor and tools cannot be repaired with neptunium ingots unfortunately. latest version for 1.12.2

Can't see fishing line and hook

Can't see fishing line nor hook on the vanilla minecraft wooden fishing pole, and the blazer pole aswell.
The other ones work normally.

I use Minecraft 1.12.2 and Forge 2838

[1.12.2] Ore dictionary entry for fishes

Hey there,
It would be nice if the mod were more compatible with, for example, Thermal-Expansion. Thermal-Expansion has the so called entangler block that automatically fishes. It seems that advanced fishing is the only mod that provides the squid as an item with which you can craft the ink sac. If you want to farm black dye effectively then this is a must have ofc.

I don't know if it's only the ore dict entry that's missing. But all fishes that are angled by this block have the ore dict entries "listAllfishfresh" and "listAllfishraw". That are fishes from MC and Pam's Harvestcraft for example.

:)

Too many Items spawning in version [1.12.2-1.3.3]

In my pack of which I am the developer, World of Dragons, I have at least one player reporting that when using a blazing fishing rod that insane lag occurs and that an insane amount of items spawn from the water while it is being used dropping FPS to 1.

https://github.com/kreezxil/World-of-Dragons/issues/7

This occurs in his client and while connected to my server.

We're using FORGE build 2796.

Luck potion

New fishing poles

• Iron
• Golden
• Diamond
• Blazing Fishing Pole