niesmo / childcare Goto Github PK

Nick and I went through all the stuff that we as a team are working on or going to be working on.
Go on there and find yours (or the ones that are not assigned to anyone that you think are yours) and move them to the appropriate column (backlog, in progress, testing, or done).

For example for duplicate emails

http://stackoverflow.com/questions/17849529/simple-user-checking-in-meteor-is-this-secure

Creating a system to display errors in the UI in an easy fashion.
Read http://nl.discovermeteor.com/chapters/errors/

When the order for the waitlist is edited the waitlist does not properly reorder

The age of the child does not display if it is less than 1 month. The age should be displayed either in weeks or by stating the age is <1 month. Additionally, if the age is 1 month or less, the displayed text should use 'month' rather than 'months'.

Every server method call that is made in the client, needs to have a solid error handling and it should be using the "new" systemic error display (another issue is created for that).

There needs to be logical flow when errors happen.
For example, If they were in middle of filling out an application, they need to be taken back to the beginning and what they had filled out should be there.

Ids must be unique. titles are not unique. _id of the document that you get from the collection is unique. so use that.
You can't just use that by itself tho, the problem is that ID's in html cannot start with numbers. so to work around that, you can pad the ID with some text in the html and look for that same padding in the javascript
You need to change for toddlers, infants, and completed action items

In bootstrap, for things to be in the same row, the columns should add up to 12.
in the Application form, where we are getting the address, if you look at where we get the zipcode, the columns are adding to 14 which is why the zipcode is showing up in a new row.

using createdByEmail is simply duplicating data. we already have the id of the user who created it, we can get all the information of that user using their id.

From creating the application
to approving the application
to their order in the waitlist
to moving form the waitlist to the actual class

When the user wants to enroll a student, they dont have to reselect the days. they will only have to do anything if they want to change those days. Therefore, those days need to be check be default when the modal opens

it does not make sense to add another parameter to the call because we now have a second parent. what if later we needed X and Y and Z? should we just keep adding arguments?

That is why in the first place we are sending an object instead of all those variables as separate arguments. Add the parent2 to the application object (as secondary parent, or even you could have parent be an array -- future flexibility) and keep the signature of the method the same.

instead of random colors.

Similar to the waitlist page, i think it would look nicer to put the buttons all in the same column

We need to create the presentation for Thursday.

I am suggesting to use a theme. I added the theme for our first checkpoint but was not able to move the presentation to the new Themed slides.

I am suggesting to use the following theme
https://drive.google.com/open?id=1DmzOpW2zjN4oXPSKyZDotbuUmFrZt9_Xf5QQxkMZTpw

We need to figure out someway of testing our application.
We can checkout Jasmine (its kind of harder to use Jasmine when we are not writing packages)
and checkout Cucumber (for behavioral testing)

Check for the format
check for the length
check for repeatedness (if the the thing is supposed to be unique)

The reason for the for attribute in a label is so that when they click on the label, it focuses on that input element. In case of checkbox, it toggles the checkbox.

So the id of the input element and the for of the label should match.

you can use the this object in your help that will have the same context of what you are iterating through in your template.

So you could probably get the id of the action item in the getTableRowType by using: this._id

You can create the parent 2 in the HTML and just hide it initially.
When they click the add another parent, show that section.
when the say collapse, clear the form and hide that section.

I think another way to approach this is to simply mark the action item so that you can find out whether the action item is a system kind or not.

If you create another user, on each row, you have to get the user and check if its admin, which is a whole a lot of queries that are not absolutely necessary.

I thought after we talked about how Lauren does not want the title in the action items, we said that we are gonna remove it and simply just use the description.

is completed should be of boolean type. that way there there would be no confusion.

Also, the label field is for the UI, so use a human readable text of what the field should be called.
For example, for the isCompleted the label could be "Is Completed" rather than "IsCompleted"

So we dont have to wait for parent to complete and then create the student (since those two are independent)

assigning the id of the action item to the data (td), would make it harder for you to get the id of the action item when they click on the row.

but the point of an id is something that is unique within a page (what is unique). we are really talking about that whole row being a unique entity not only that data part of the row.

its best if you just stick with the regular javascript date function when you store stuff in the database.
for the formatting, you do that when you get the stuff back from the database and are trying to display it to the user.

http://www.w3schools.com/tags/att_global_id.asp

so you can't set the id of the row (for completed task) to the id of the person who created (because that is not unique). instead set the action item id to the row (as there is another issue for that).

Same validations should apply to parent 2

the collection for the action items is defined in such a way that the createdBy and completedBy are of type SimpleSchema.RegEx.Id. so you should not assign the email address of that person to such field.

So when someone creates an action item or completes an action item, you should get their Ids and set it to that field.

The system actions items are by nature from the server side, so i dont think we'd need that in the client. that may raise some security concerns.

when you call a method in meteor, there is a callback that you get from it when the method is completed (it is like an Ajax request). so send something back from the method indicating that the action went okay or no it didnt go okay (that is where the backend checks/validations come into play).
if things didnt go correct, send it back to the UI and check for that result and update the UI accordingly.

http://docs.meteor.com/#/full/meteor_methods
http://docs.meteor.com/#/full/meteor_call

we decided to use the same tab size across all of our editors so when someone edits your code, their IDE wouldnt change the tab sizes and the commit would look like there is a lot of changes where there actually is very minimal changes

Tab size: 2
IDE should use spaces for tabs

what is that classType for?

You seem to be doing the almost exact if not exactly the same same things in the different getCompletedByUser functions.

Just create a global helper that does just that so you dont have to create multiple ones. And I am sure that would be used a lot in a lot of other places.

Its not good practice to create the header of a table in the body of the table. (hence tbody)
use and for headers of every table.

https://developer.mozilla.org/en-US/docs/Web/HTML/Element/table

Cron is just an idea. We need to check once or twice a day for if a system message needs to be sent out. The function is already there for sending out the message, just needs to know when and what.

So that we are able to use the Toasts on success or failure

using html mark up for styling is a less maintainable way of developing a page.
instead using css instead, will allow you to use the different classes in different parts of the code and also is not cluttering the html (as it already it).

also, there are lots of helpers already in the bootstrap framework that you can use, take advantage of those.

in this particular example of the table that you created, if you move them to be header, they are most likely already bolded by default styling of bootstrap.