nicoseijas / php-oembed Goto Github PK

What steps will reproduce the problem?
1. Enter a URL with embedding disabled
(http://www.youtube.com/watch?v=yh5ZS5N51ug)
2. Script crashes in YouTubeProvider.class.php when trying to set
$med_content_url 

What is the expected output? What do you see instead?
Script should return gracefully but with no data

What version of the product are you using? On what operating system?
PHP 5 Apache 2

Please provide any additional information below.
I have gotten around this by checking the length of
$xml->getElementsByTagNameNS("http://search.yahoo.com/mrss/","content");
before proceeding, and if there is no length throwing an exception.

This is a different issue, but please note that also the Exception404 class
is not complete as it does not pass on its parameters to the base exception
class in the constructor, and also there is no toString function
implemented so you have an undefined function in your sample when you
attempt to catch the exceptino and call toString.

What steps will reproduce the problem?
1. Reference YouTube video, e.g. 
http://www.youtube.com/oembed?maxwidth=500&maxheight=600&url=http://www.youtube.
com/watch%3Fv%3DulcgFppkbLU


What is the expected output? What do you see instead?
Expect valid HTML in the "html" field, but it contains invalid </param> and 
</embed> tags.


What version of the product are you using? On what operating system?
N/A


Please provide any additional information below.

The code is clearly generated in YouTubeProvider.class.php in the function 
YouTubeProvider::getEmbed() at "$myEmbed->html=..."

(There might be additional places)

cf.
PARAM: http://www.w3.org/TR/html401/struct/objects.html#h-13.3.2
EMBED http://dev.w3.org/html5/spec/Overview.html#elements-0
“Void elements only have a start tag; end tags must not be specified for void 
elements.”

Reported to Google here:

http://code.google.com/p/gdata-issues/issues/detail?id=2346