nicolaslopezj / graphql-loader Goto Github PK

from the documentation, its unclear that typeDefs has to be an array of strings, instead of a string.

This fails silently.

allow typeDefs to be a string or highlight it in the readme

If a union type exists in the typeDefs, it is not parsed and made available in the resulting schema.

http://graphql.org/learn/schema/#union-types

Example typeDefs:

type TextActivity {
  title
  text
}

type VideoActivity {
  title
  video
}

union Activity = TextActivity | VideoActivity

Result when building AST Schema: Error: Type "Activity" not found in document.

Even commented type declarations are parsed, e.g.

## Color it is
# type Color {
#   name: String
#   hex: String
#   red: Int
#   green: Int
#   blue: Int
# }

# Shape it is
type Shape {
  name: String
  area: Float
}

both of these type will be parsed by graphql-loader.

If I have a definition like this:

interface Magic {
    foo: String
}

interface Trick	{
    bar: int
}

type User implements Magic, Trick {
    foo: String
    bar: int
}

and I parse it with graphql-loader, it gets mangled like this:

interface Magic {
    foo: String

}

interface Trick {
    bar: int

}

Trick {
    foo: String
    bar: int

}

... which is (of couse) invalid GraphQL, and so calling makeExecutableSchema() on it will fail with a parse error.

If I have a type like this:

type FromMe2You {
    message: String
}

and process it with graphql-loader, it will be maimed into this:

You {
    message: String

}

The reason for this is that it doesn't like the number in the name of the type.
I am not exactly sure what the specs say here, but the GraphQL parser itself has no problem with the number, so I see no reason why should it be forbidden...

# Color it is
type Color {
  name: String
  hex: String
  red: Int
  green: Int
  blue: Int
}

if you do loadSchema, then getSchema, comment is gone. And that leads to introspection queries not returning a description for the type.

Hello,
You allows to split schemas/resolvers in different files however we cannot define more than one Query otherwise the error Error: Must provide only one query type in schema is thrown. See apollographql/apollo-server#43 to find solutions to merge queries into a single one.