Coder Social home page Coder Social logo

sgt's People

Contributors

nicmichael avatar

Stargazers

 avatar

Forkers

hervegirod

sgt's Issues

AREAFILL issue

I feel the color picked in fillSquare method is not correct.

col = cmap.getColorByIndex(cindex+1);

The reasons is it seems it is assuming that number of contour levels and number of colors in color map are equal. which may not be the case.

Better solution will be to pick color by using following:

//col = cmap.getColorByIndex(cindex + 1);
if (zmin > zlevp1 || zmax < zlev) {
continue;
}
try {
col = attr_.getColorMap().getColor(clevels.getLevel(cindex + 1));
} catch (ContourLevelNotFoundException ex) {
col = cmap.getColorByIndex(cindex + 1);
}
Kindly correct me if I am incorrect. I have tested it never goes into catch. Just a fallback option.
I am attaching the current and proposed areafill snapshots by running JGridDemo.
The proposed matches closely to the raster in terms of color map.

current_areafill_grid_demo
proposed_area_fill_grid_demo
raster_grid_demo

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.