nickgang / dualpianoeeg

MaxMSP Framework for Two-Person EEG Piano Duets

dualpianoEEG

Update 2/27/16

• Color coded patch cables!
  • yellow: carrying list
  • pink: trial type (0-15)
  • cyan: trial number (0-47+)
  • green: score type (AAAA or BCBC)
  • blue: P1 odd/even (1,2)
  • red: Human/Max status (1,2,3)

What is done

• Possible deviant positions within phrase changed from 3 (3,4,5) to two (4,5)
• Number of trials per block changed from 36 to 48
• Number of blocks changed from 8 to 12
• Note duration logic
  • If held for < 375ms, wait until 375ms and send note off
  • If held for > 375ms, send note off through as soon as it's received
• Dropdown menu logic in run experiment and block-follow
  • This effects the trigger codes assigned within metronome tock. All but the Human/Max condition are fixed (this one needs two bits). Look at the comments in this file for more details.
• Assigning score-based trigger codes individually for even/odd player logic above to route only one player's note data to correct subpatch

TODO:

• Skynet mode needs to send trigger codes
• debug trigger codes sent from inside metronome-tock
• If player is holding old note and plays new note, cut off old note

dualpianoeeg's Issues

Need to update excel sheet

The trigger code excel sheet needs an update on the tab with the block-type trigger codes.

Currently, the human/max bit is split evenly, while in reality there will be 8 trials with max involved and 4 with only humans involved.

Max flagging real trials as practice trials

In blocks where many trials are needed due to errors (70+), Max will marked a trial as practice and switch to 6 metronome ticks.

Final Human Note is Cut Off

The last note of the simultaneous phrase will sound for Max but not for the human player.

No Deviants in Skynet mode

Skynet currently plays without deviant notes for all trials.

Trigger Code Issues

Trigger codes are being sent incorrectly for the final 4 unison notes.

Workarounds for pilot data analysis:
For Human/Human condition - Select whichever trigger code came first/is present 174 or 74.

For Human/Max - Working on well-defined workaround for this

Skynet Doesn't Send Trigger Codes

This omission was intentional at the time, but we will need these for FRN analysis.

Simultaneous Notes Incorrectly Marked as Errors

In Human/Human and Human/Max blocks, the notes played simultaneously will always be marked as errors. It seems that Max throws both a "wrong note" erro for all notes and "bad IOI" error for only a few notes. Attached is a screen shot from block 6 (Human/Human, P1 even).

Staccato Notes Bug

Staccato notes happen when a deviant note and the succeeding standard note are the same pitch.

This is tied to the borax object in the 'piano-note' sub-patches. This object is responsible for making each player's synthesizer monophonic.

Spurious "out-of-turn-note" errors

Out of turn note errors when playing is correct are currently keeping trials from being marked as correct. I suspect this issue comes from the old logic used in 'check-for-performance-errors' within 'check-errors-and-send-triggers' which still looks for the old phrase number (1-6).

Deviant and Standard Notes Both Play

While testing the deviant trials (via a manual override in piece-follow) both the deviant and standard notes sounded, meaning two notes played at once.

Infinite Forgiveness Mode Not Working

Trials do not proceed with infinite forgiveness mode enabled. This mode should allow a user to play through all trials of a given block regardless of the errors committed.

Spurious Metronome Trigger Codes

Wisam has discovered metronome trigger codes (i.e. 201-233) in the middle of some trials while looking through the curry data.

These codes are sent from the "metronome-tock" patch within piece follow.

Human Playback Should Be Monophonic

Desired Behavior: Each new note for a given player kills any currently held notes.
Current Behavior: Held notes will still sound until released.

Lag on 1st Note of Simultaneous Playing

When skynet is playing the odd phrases, it will pause before playing the first simultaneous note. This causes skynet to be an 8th note late on the last 4 notes.

Skynet Doesn't Record Deviant Direction

Minor Issue:

We need a reliable way to see whether skynet played a deviant note up a scale degree or down. Maybe this already exists?

Pre-Simultaneous Skynet Note is Wrong

Note 27 (one note before unison) is shifted up one scale degree (from a C# to a D) when played by skynet.

-Nick