nicholascross / weakdictionary Goto Github PK

WeakDictionary appears to convert to Swift 5 fine without any source changes.
However, the podspec says swift_version = '4.2'.

Can we either update the swift_version to 5, or create a Swift-5 branch where the podspec has swift_version set to 5?

I wish there was a way to override the swift_version of a pod from within a Podfile, but sadly there isn't.

So, this might be intentional, but I just wanted to double-check that it was intended.

This:

Will end up always having valuesRetainedByKey false, because of this:

Is this intended? Or should it inherit valuesRetainedByKey from the parent? ☺️

Sometimes it is sufficient to do a reference === check when doing a look up. We should support this ability some how as it will perform better in some scenarios.