ngscheurich / loverboy Goto Github PK

View Code? Open in Web Editor NEW

8.0 3.0 0.0 47 KB

💘 Adds libraries to a LÖVE project

Home Page: https://www.loverboy.rocks/

License: MIT License

Lua 98.08% Shell 1.92%

love2d love2d-framework lua

loverboy's Issues

Loverboy doesn't explain about mfiles

On first install, if you've forgotten to setup the mfiles, you get a stacktrace:

$ loverboy help
/usr/local/opt/lua/bin/lua5.3: /usr/local/share/lua/5.3/loverboy/util.lua:10: cannot open ~/.local/share/loverboy/mfiles: No such file or directory
stack traceback:
    [C]: in function 'lfs.dir'
    /usr/local/share/lua/5.3/loverboy/util.lua:10: in local 'load_mfiles'
    /usr/local/share/lua/5.3/loverboy/util.lua:19: in main chunk
    [C]: in function 'require'
    /usr/local/share/lua/5.3/loverboy.lua:4: in main chunk
    [C]: in function 'require'
    ...cal/lib/luarocks/rocks-5.3/loverboy/0.1.0-1/bin/loverboy:3: in main chunk
    [C]: in ?

Instead, it'd be nice to tell the user what to do:

$ loverboy help
cannot open ~/.local/share/loverboy/mfiles: No such file or directory

To get mfiles, run:
    git clone https://github.com/ngscheurich/loverboy-mfiles.git ~/.local/share/loverboy

repos with folders aren't supported

As far as I can tell, repos with folders aren't supported. The current windfield has two problems:

windfield has all its code in a folder
mlib is incorrectly spelled mib in the mfiles

So if you try to install it, it looks successful:

$ mkdir lib
$ loverboy add windfield
==> Adding windfield (master)...
  * lib/init.lua
  * lib/mlib/mib.lua
Done!

But actually, it was not:

$ find lib -type f -exec head -n2 {} +
==> lib/mlib/mib.lua <==
404: Not Found

==> lib/init.lua <==
404: Not Found

Fixing the typo doesn't make things better. I tried a couple methods of describing the path to download in the mfiles

Tested on loverboy version 0.1.0 and ngscheurich/loverboy-mfiles@f45fcbf

I think a remapping syntax like this would make sense:

files = {
  -- structure of table defines desired folder structure
  windfield = {
    "windfield/init.lua", -- path of string defines folder structure in git
  }
}

Loverboy doesn't create lib folder for you or explain that you must create it

After installing loverboy and creating a new empty project folder, loverboy fails to add a library.

$ mkdir puppypark
$ cd puppypark
$ loverboy add baton
==> Adding baton (v1.0)...
* lib/baton.lua
/usr/local/opt/lua/bin/lua5.3: /usr/local/share/lua/5.3/loverboy/util.lua:74: lib/baton.lua: No such file or directory
stack traceback:
    [C]: in function 'assert'
    /usr/local/share/lua/5.3/loverboy/util.lua:74: in function 'loverboy.util.download'
    /usr/local/share/lua/5.3/loverboy/add.lua:21: in local 'recursiveDownload'
    /usr/local/share/lua/5.3/loverboy/add.lua:50: in main chunk
    /usr/local/share/lua/5.3/cliargs/parser.lua:54: in function </usr/local/share/lua/5.3/cliargs/parser.lua:51>
    (...tail calls...)
    /usr/local/share/lua/5.3/cliargs.lua:13: in method 'parse'
    /usr/local/share/lua/5.3/loverboy.lua:24: in main chunk
    [C]: in function 'require'
    ...cal/lib/luarocks/rocks-5.3/loverboy/0.1.0-1/bin/loverboy:3: in main chunk
    [C]: in ?

Creating a lib/ directory fixes the problem, but the output doesn't clearly indicate that's the solution.

ngscheurich / loverboy Goto Github PK

loverboy's Issues

Loverboy doesn't explain about mfiles

repos with folders aren't supported

Loverboy doesn't create lib folder for you or explain that you must create it

Recommend Projects

React

Vue.js

Typescript

TensorFlow

Django

Laravel

D3

Recommend Topics

javascript

web

server

Machine learning

Visualization

Game

Recommend Org

Facebook

Microsoft

Google

Alibaba

D3

Tencent