Coder Social home page Coder Social logo

shelljs-plugin-clear's People

Contributors

nfischer avatar

Stargazers

avatar avatar avatar avatar

Watchers

avatar avatar avatar

shelljs-plugin-clear's Issues

Lint broken on node v4

Node version (or tell us if you're using electron or some other framework)

v4

ShellJS version (the most recent version/GitHub branch you see the bug on)

happening on GitHub Actions CI

Operating system

all

Description of the bug:

/home/runner/work/shelljs-plugin-clear/shelljs-plugin-clear/node_modules/eslint/node_modules/optionator/node_modules/word-wrap/index.js:9
  let lastCharPos = str.length - 1;
  ^^^

SyntaxError: Block-scoped declarations (let, const, function, class) not yet supported outside strict mode
    at exports.runInThisContext (vm.js:53:16)
    at Module._compile (module.js:373:25)
    at Object.Module._extensions..js (module.js:416:10)
    at Module.load (module.js:343:32)
    at Function.Module._load (module.js:[30](https://github.com/nfischer/shelljs-plugin-clear/actions/runs/7124938899/job/19400001442?pr=14#step:5:31)0:12)
    at Module.require (module.js:[35](https://github.com/nfischer/shelljs-plugin-clear/actions/runs/7124938899/job/19400001442?pr=14#step:5:36)3:17)
    at require (internal/module.js:12:17)
    at Object.<anonymous> (/home/runner/work/shelljs-plugin-clear/shelljs-plugin-clear/node_modules/eslint/node_modules/optionator/lib/help.js:6:14)
    at Object.<anonymous> (/home/runner/work/shelljs-plugin-clear/shelljs-plugin-clear/node_modules/eslint/node_modules/optionator/lib/help.js:260:4)
    at Module._compile (module.js:[40](https://github.com/nfischer/shelljs-plugin-clear/actions/runs/7124938899/job/19400001442?pr=14#step:5:41)9:26)

See https://github.com/nfischer/shelljs-plugin-clear/actions/runs/7124938899/job/19400001442?pr=14

It looks like one of our dependencies is no longer v4-compatible.

Example ShellJS command to reproduce the error:

npm run lint

clear() should not have a visible return value

Right now, clear() returns undefined, which gets printed in the REPL, which kind of defeats the point. The function always returns the same thing, so nobody should actually depend upon its return value.

The best return value is probably some simple object with a .inspect() method that returns the empty string. I think this should be feasible if I tell ShellJS to not wrap the plugin output.

Technically this constitutes a breaking change.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.