Description

The error was found in the file /components/Modal/StepsEditor.js
in the function: HandleOnChange.

Original function

  HandleOnChange = (target, value, id) => {
    this.setState(
      state => {
        const form = { ...state.form };
        form[`step_${id}`][target] = value;
        const stages = this.UpdateSubSteps(value, id);
        return {
          form,
          stages
        };
      },
      () => {
        if (target === 'substeps') {
          this.ChangeSubsteps(id, value);
        }
      }
    );
    if (target === 'level') {
      this.ChangeOrder(id, value);
    }
  };

Solution

  HandleOnChange = (target, value, id) => {
    if (target === 'substeps') {
      this.setState(
        state => {
          const form = { ...state.form };
          form[`step_${id}`][target] = value;
          const stages = this.UpdateSubSteps(value, id);
          return {
            form,
            stages
          };
        },
        () => {
          this.ChangeSubsteps(id, value);
        }
      );
    }
    if (target === 'level') {
      this.ChangeOrder(id, value);
    }
  };

When pathpoint is unable to retrieve a config from Nerdstore (or obtain the "last save version") it reverts to the "demo" config that is actually bundled with the nerdlet code. This is okay, BUT we don't need to save that as a stored config, we should just keep loading it from the bundle. When a user actually does a forced save of the stages, steps, or touchpoint editors it will then update the nerdstore.

Why do this? There can be some cases (or it is surmized) that Pathpoint could have a transient issue reading the config from Nerstore and it could cause pathpoint to wipeout a good config with a demo config.

@Sandeep10parmar

Summary

Heineken is using Pathpoint for internal Business Processes for our SAP integration and has requested TV mode to be available on Pathpoint in order to use New Relic in their Operations Centres and displayed on TVs around the office

Desired Behaviour

TV Mode in order for Pathpoint to be full screen and auto refresh feature

Possible Solution

TV Mode just like this Status Wall Board so the functionality is already there just needs to be copy and pasted over to the pathpoint app.

https://github.com/newrelic-experimental/nr1-wall-status-board?tab=readme-ov-file

Additional context

This feature would be beneficial to many other customers who want to use New Relic Pathpoint in their own Ops Centres

Only save the last change

Description

If you add a new steps level in many stages, the tool only saves the change made in the last stage

Steps to Reproduce

the issue was reported in the next video

Solution

It requiere an update in the file: nerdlets/pathpoint-nerdlet/components/Modal/StepsEditor.js

add the lines with the red arrow in the image

and add the next function

CODE:

HandleOnChange = (target, value, id) => {
    this.setState(
      state => {
        const form = { ...state.form };
        form[`step_${id}`][target] = value;
        const stages = this.UpdateSubSteps(value, id);
        return {
          form,
          stages
        };
      },
      () => {
        if (target === 'substeps') {
          this.ChangeSubsteps(id, value);
        }
      }
    );
    if (target === 'level') {
      this.ChangeOrder(id, value);
    }
  };

  UpdateSubSteps(value, id) {
    const current = { ...this.state.current };
    const stages = [...this.state.stages];
    const stage = stages.find(item => item.id === current.stage);
    const currentStep = stage.steps.find(item => item.id === id);
    const array = value.split(',');
    const sub_steps = [];
    array.forEach(item => {
      sub_steps.push({ value: item });
    });
    currentStep.sub_steps = [...sub_steps];
    return stages;
  }

Relevant Logs / Console output

Your Environment

• NR1 CLI version used:
• Browser name and version:
• Operating System and version:

Additional context

Hi,

Pathpoint which I enabled is available only to me. When I share the link to my team Newrelic is asking for Pathpoint to be enabled. Will they enable it will it wipe off my configuration. How can I share the pathpoint dashboard created.

Thanks,
Sangeetha

Description

If in the JSON config file the measure_time is defined as "5 minutes ago", using lower case, this is interpreted as custom. The measure_time is only considered by default when it is set to uppercase with the value of “5 MINUTES AGO”. This causes the Time-Picker to have no effect on those touchpoints and can be confusing for the user.

Steps to Reproduce

1. Enter the Pathpoint menu to download the JSON config file.

2. Select the “Json configuration” option from the menu and then click the download button.

3. In the JSON config file, you can see the measute_time properties in lowercase and uppercase of two touchpoints of the same type.

4. When the Time-Picker is selected for example in “60 minutes ago” and we download the JSON-FILE again, we observe that this selection only has an effect on the touchpoints with the measure_time defined in uppercase, the touchpoints with the time defined in lowercase they are not affected because it is considered as custom:

Expected Behaviour

The interpreter of the measure_time attribute must recognize the default value of "5 Minutes Ago" with a case-insensitive filter.

Relevant Logs / Console output

Your Environment

• NR1 CLI version used: @datanerd/nr1/2.83.5 win32-x64 node-v16.11.1
• Browser name and version: Firefox 107.0 (64 bit)
• Operating System and version: Windows 10
• Pathpoint version: 1.7.3

Additional context

Summary

The feature will provide not only the direction but the %change of the KPI, which will help the user to understand the shift in magnitude up or down.

Desired Behaviour

Display % change alongside the KPI value.

Possible Solution

This could be similar to how it shows up on the Billboard widget in the NR1 dashboard

Hi Team,

The touchpoint type drop down is not working since yesterday. The drop down is greyed out and it is changing the touchpoint type by itself every time I save. So all the touch points are now red and dashboard is not working. Can you please check

Description

When a time window other than the Time-Picker default is selected, for example, "60 minutes ago", all touchpoints that did not have measure_time are temporarily calculated from the Time-Picker selection (SINCE 1668428490 UNTIL 1668428790). This change becomes permanent if the Touchpoints GUI editor is opened and the “Save Update” button is clicked.

Steps to Reproduce

1. To verify the Touchpoints GUI editor before making changes in the Time-Picker.

2. Change the selection in the Time-Picker to 30 minutes:

3. The touchpoint graphic editor opens and clicks on the “Save Update” button.

4. The Pathpoint is reloaded with the Time-Picker in its default selection and the graphical editor of touchpoints is opened. It is evident that all the touchpoints that did not have a custom measure_time have been modified:

5. Likewise, the touchpoints that have the custom measure_time are not affected by the action of the GUI editor:

Expected Behaviour

Touchpoints GUI editor should not save changes in measure_time with Time-Picker effects.

Relevant Logs / Console output

Your Environment

• NR1 CLI version used: @datanerd/nr1/2.83.5 win32-x64 node-v16.11.1
• Browser name and version: Firefox 107.0 (64 bit)
• Operating System and version: Windows 10
• Pathpoint version: 1.7.3

Additional context

Description

It was found that when the client has a large number of synthetic scripts the algorithm fails because it only performs a search on the first 50 elements.

Steps to Reproduce

Reproducing the bug requires a customer with more than 50 Synthetic Scripts in their account.
The search algorithm fails, and instead of updating the existing script, it tries to create a new one with the same name, which is why the creation attempt fails.

Solution

• save the script id in the Pathpoint storage
• Then, instead of doing a general search, try to read the data from the Synthetic Script using the previously saved ID

file to fix: /nerdlets/pathpoint-nerdlet/services/SynConnector.js

add in the header

import { AccountStorageQuery, AccountStorageMutation } from 'nr1';

Add the next function

SetFlameScript(scriptID, scriptName) {
    try {
      AccountStorageMutation.mutate({
        accountId: this.accountId,
        actionType: AccountStorageMutation.ACTION_TYPE.WRITE_DOCUMENT,
        collection: 'pathpoint',
        documentId: 'flameScript',
        document: {
          flameScriptId: scriptID,
          flameScriptName: scriptName
        }
      });
    } catch (error) {
      /* istanbul ignore next */
      throw new Error(error);
    }
  }

Update this function ExistFlameScript()

async ExistFlameScript() {
    let searchResult = false;
    let monitorID = '';
    let error = null;
    try {
      if (this.flameScriptId === null) {
        const { data } = await AccountStorageQuery.query({
          accountId: this.accountId,
          collection: 'pathpoint',
          documentId: 'flameScript'
        });
        if (data) {
          this.flameScriptId = data.flameScriptId;
          this.flameScriptName = data.flameScriptName;
        }
      }
      // const name = `Pathpoint-${this.pathpoint_id} Flame Script`;
      if (this.flameScriptId) {
        // validate if monitor already exist
        const response = await this.axiosInstance.get(
          `${this.uriSyntetic}/${this.flameScriptId}`,
          {
            headers: {
              contentType: 'application/json',
              'Api-Key': this.userApiKey
            }
          }
        );
        if (
          response &&
          response.status &&
          response.status === 200 &&
          response.data &&
          response.data.name
        ) {
          monitorID = this.flameScriptId;
          searchResult = true;
        } else {
          error = true;
        }
      }
    } catch (error) {
      throw new Error(error);
    }
    return { searchResult, monitorID, error };
  }

Add the. SetFlameScript function to CreateFlameScript()

async CreateFlameScript() {
...
...
        const monitorID = arrayLocation[1];
  --> this.SetFlameScript(monitorID, FlameMonitor.name);
        return monitorID;

Description

I am trying to initialize the development server of a New Relic application. I cloned the current repository and updated the version. It is currently in version 1.6.3. I have two profiles: account-3490120 and wigiboards. After cloning the project. I install the dependencies with npm install. At the end of the installation, I generate an id with the following command nr1 nerdpack:uuid -gf --profile=wigiboards. And continue to start the server with the command: nr1 nerdpack:serve. Its here where the problem born. I need a lot of help, screenshot:

Steps to Reproduce

Expected Behaviour

Relevant Logs / Console output

Your Environment

• NR1 CLI version used: @datanerd/nr1/2.49.5 win32-x64 node-v14.15.1
• Browser name and version: Edge 102.0.1245.39
• Operating System and version: Window 8.1

Additional context

Description

Step Editor's "visible" setting hides certain steps from the Pathpoint view. It works, but the steps show back on the main visualization after some time. The change to the visible settings is reverted back.

Steps to Reproduce

Open Step Editor
Click the Visible setting on the top right to make it "invisible."
Please wait for the issue to occur; it can be hours or a day before these steps show up again on the main UI

Expected Behaviour

Steps should not appear in the main view once made invisible through the Step Editor.

Relevant Logs / Console output

The screenshot below shows the steps getting dark after they are set to be hidden.

After a random wait time, the setting is reverted to default i.e. visible.

Your Environment

Deployed from the App Catalog

v 1.7.6

Description

The Steps section of the Pathpoint documentation https://github.com/newrelic/nr1-pathpoint/tree/main/docs/guides/Pathpoint-Steps
seems to be a duplicate of the stages section here https://github.com/newrelic/nr1-pathpoint/tree/main/docs/guides/Pathpoint-Stages

Steps to Reproduce

Just accessing the links above.

Expected Behaviour

Steps should have a detailed section describing what steps are, the options and the configurations of those.

Relevant Logs / Console output

na

Your Environment

na

Additional context

Acceptance Criteria

• See JIRA INFOSEC-3466 for details of this audit and findings.
• Conduct a retrospective on these findings

Description

All Touchpoints turn green on when updating config

Steps to Reproduce

Update a Touchpoint config

Expected Behaviour

Touchpoints to retain their status while config updates, or can simply be hidden while the Pathpoint loads again.

Description

We were trying to update this app in the cantlog and it was failing, we then discovered it doesn't run locally so we'll need to spend some time investigating this. This app also seems to have it's own support system so not sure on that.

Catalog Merge Issue

There is an issue with the tests, they pass in a specific version number which is behind the current version of the app. I think just updating the relevant tests, as well as the sample JSON files to match 1.1.x will suffice. The Schema checks to see if the first 2 numbers in the config pathpointVersion are the same as the current app version

• Failing Tests
• Example PR
• JSON examples

Build Issue

Seeing the following error when built locally:

4da92288-f951-41c5-a91c-9e45d4864ee9--pathpoint-nerdlet~latest.js:10878 Uncaught (in promise) Error: TypeError: Cannot read properties of undefined (reading 'id')

Repolinter Report

🤖This issue was automatically generated by repolinter-action, developed by the Open Source and Developer Advocacy team at New Relic. This issue will be automatically updated or closed when changes are pushed. If you have any problems with this tool, please feel free to open a GitHub issue or give us a ping in #help-opensource.

This Repolinter run generated the following results:

• Fail
  • ❌ readme-starts-with-nr1-catalog-header
  • ❌ readme-contains-forum-topic
• Passed
  • ✅ license-file-exists
  • ✅ readme-file-exists
  • ✅ readme-contains-security-section
  • ✅ readme-contains-link-to-security-policy
  • ✅ third-party-notices-file-exists
  • ✅ code-of-conduct-should-not-exist-here
  • ✅ github-actions-workflow-file-exists
  • ✅ nr1-catalog-config-file-exists
  • ✅ nr1-catalog-screenshots-directory-exists
  • ✅ nr1-catalog-documentation-file-exists
  • ✅ package-scripts-present

Fail #

❌ readme-starts-with-nr1-catalog-header #

The README of a community plus project should have a NR1 Catalog header at the start of the README. If you already have a NR1 Catalog header and this rule is failing, your header may be out of date, and you should update your header with the suggested one below. For more information please visit https://opensource.newrelic.com/oss-category/. Below is a list of files or patterns that failed:

• README.md: The first 1 lines do not contain the pattern(s): Open source NR1 Catalog header (see https://opensource.newrelic.com/oss-category).
  • 🔨 Suggested Fix: prepend the latest code snippet found at https://github.com/newrelic/opensource-website/wiki/Open-Source-Category-Snippets#code-snippet-3 to file

❌ readme-contains-forum-topic #

Doesn't contain a link to the appropriate forum.newrelic.com topic (README.md). New Relic recommends directly linking the your appropriate forum.newrelic.com topic in the README, allowing developer an alternate method of getting support. For more information please visit https://nerdlife.datanerd.us/new-relic/security-guidelines-for-publishing-source-code.

Passed #

The function that recreates the touchpoints definitions after an update has a bug in the APS Touchpoint.
It requiere to add the measure_time property

Description

File: services/DataMamager.js
Function: UpdateNewConfiguration

Steps to Reproduce

There’s an issue I have found with Pathpoint, I am not able to save changes in “since” time in query window for "APS touchpoint" type

Solution

Add this code on line 2501:
measure_time: query_measure_time,

Hi, I created a Pathpoint for an application and took JSON backup, and now if I try to re-import the JSON to revert back to my previous version, I am getting error in the "dashboard_url" key saying the position '0' can have string or boolean.

My dashboard_url key looks like below :

{
"dashboard_url" : {
         "nickName" : "",
         "link" : "https://onenr.io/abcdef"
     }
}

Can you please guide?

Repolinter Report

🤖This issue was automatically generated by repolinter-action, developed by the Open Source and Developer Advocacy team at New Relic. This issue will be automatically updated or closed when changes are pushed. If you have any problems with this tool, please feel free to open a GitHub issue or give us a ping in #help-opensource.

This Repolinter run generated the following results:

• Fail
  • ❌ readme-starts-with-nr1-catalog-header
  • ❌ code-of-conduct-should-not-exist-here
• Passed
  • ✅ license-file-exists
  • ✅ readme-file-exists
  • ✅ readme-contains-security-section
  • ✅ readme-contains-link-to-security-policy
  • ✅ readme-contains-discuss-topic
  • ✅ third-party-notices-file-exists
  • ✅ github-actions-workflow-file-exists
  • ✅ nr1-catalog-config-file-exists
  • ✅ nr1-catalog-screenshots-directory-exists
  • ✅ nr1-catalog-documentation-file-exists
  • ✅ package-scripts-present

Fail #

❌ readme-starts-with-nr1-catalog-header #

The README of a community plus project should have a NR1 Catalog header at the start of the README. If you already have a NR1 Catalog header and this rule is failing, your header may be out of date, and you should update your header with the suggested one below. For more information please visit https://opensource.newrelic.com/oss-category/. Below is a list of files or patterns that failed:

• README.md: The first 1 lines do not contain the pattern(s): Open source NR1 Catalog header (see https://opensource.newrelic.com/oss-category).
  • 🔨 Suggested Fix: prepend [![New Relic One Catalog Project header](https://github.com/newrelic/opensource-website/raw/master/src/images/categories/New_Relic_One_Catalog_Project.png)](https://opensource.newrelic.com/oss-category/#new-relic-one-catalog-project) to file

❌ code-of-conduct-should-not-exist-here #

New Relic has moved the CODE_OF_CONDUCT file to a centralized location where it is referenced automatically by every repository in the New Relic organization. Because of this change, any other CODE_OF_CONDUCT file in a repository is now redundant and should be removed. For more information please visit https://docs.google.com/document/d/1y644Pwi82kasNP5VPVjDV8rsmkBKclQVHFkz8pwRUtE/view. Found files. Below is a list of files or patterns that failed:

• CODE_OF_CONDUCT.md
  • 🔨 Suggested Fix: Remove file

Passed #

Summary

Desired Behaviour

Possible Solution

Additional context

Description

When the Background Functions keys are installed, every time a change is made to the Pathpoint configuration, the button must be shown again to be able to manage the Synthwtic Script update.
Currently that button is not shown when making changes with the GUI editor

Steps to Reproduce

• Add the Ingest Key in the Backgroiund Function Modal

• Add the User key in the Backgroiund Function Modal

• Enable Flame Filter Background Script

• Save/Update

• close the modal, and open it againg, it will show you the green button
  

• push the button to install the Synthetic script

• after enter to the touchpoint gui editor, made any change and push the Save/Update button

• What is expected is that the next time you open Backgroung Function the green button will show again to allow you to update the Synthetic Script

solution

the bug is in the Maincontainer.js file

• go to the handleStagesEditorSubmit function and add the next line inside the setState function

Pathpoint has a powerful feature where it can re-load a config file from history. Unfortunately files are only stored in the history when the config is changed by uploading a JSON file from disk. We need Pathpoint to also add a history record when a user saves stages/steps/touchpoints from the GUI.

@rsamanez

Summary

Pathpoint UI contains a form for submitting support requests

Desired Behaviour

Pathpoint UI should point to Github repo instead to encourage customers to open an issue on the repo instead

Possible Solution

Additional context

Link to file containing "support" text: https://github.com/newrelic/nr1-pathpoint/blob/main/nerdlets/pathpoint-nerdlet/config/messages.json

In some cases we have had complains of people exported a JSON from the same version of public Pathpoint 1.7.6 and it failed to be loadable in the same version of Pathpoint 1.7.6.

@rsamanez

Summary

Infrastructure status has up to 4 bars
1 bar (Green) - No Status
2 bars (Green) - Disruptive (Red Workload Status)
3 bars (Green) - Potential Disruptive (Yellow Workload Status)
4 bars (Green) - Desired (Green Workload status)

Desired Behaviour

Match the Workload Status color to the Infras Status under Biz Stage
1 bar (Grey) - No Status
2 bars (Red) - Disruptive (Red Workload Status)
3 bars (Yellow) - Potential Disruptive (Yellow Workload Status)
4 bars (Green) - Desired (Green Workload status)

Current State

Based on #bars vs. #bars and color

Additional context

Overall this will help users better understand the state of Infra for that stage without knowing the underlying details. Always green can be misleading.

Description

After updating the pathpoint configuration using the GUI editor, the reference to the accountID in the touchPoints object is lost.
this BUG is in the Datamanager.js file
Function: UpdateNewConfiguration()

solution

Remove the conditional, to always add the accountID

and left the code like this

Repolinter Report

🤖This issue was automatically generated by repolinter-action, developed by the Open Source and Developer Advocacy team at New Relic. This issue will be automatically updated or closed when changes are pushed. If you have any problems with this tool, please feel free to open a GitHub issue or give us a ping in #help-opensource.

This Repolinter run generated the following results:

• Passed
  • ✅ license-file-exists
  • ✅ readme-file-exists
  • ✅ readme-starts-with-nr1-catalog-header
  • ✅ readme-contains-security-section
  • ✅ readme-contains-link-to-security-policy
  • ✅ readme-contains-discuss-topic
  • ✅ third-party-notices-file-exists
  • ✅ code-of-conduct-should-not-exist-here
  • ✅ github-actions-workflow-file-exists
  • ✅ nr1-catalog-config-file-exists
  • ✅ nr1-catalog-screenshots-directory-exists
  • ✅ nr1-catalog-documentation-file-exists
  • ✅ package-scripts-present

Passed #

Description

It is possible to remove the dashboard link from any touchpoint within the Touchbpoints Editor. This results in an invalid json export:

"dashboard_url": false,

which leads to the following error when trying to upload:

The stage 'LOGIN', in touchpoint 'Login Infra (WORKLOAD)', the property 'dashboard_url', should be array

Steps to Reproduce

1. Open any dashboard with a touchpoint
2. Click on Touchpoints Editor
3. Select General
4. Remove Dashboard Link
5. Click Save Update
6. Click Json Configuration
7. Download json file
8. Enter description and note (to upload again)
9. Select json file from step 7
10. Click upload

Expected Behaviour

Successful upload from previously exported json

Relevant Logs / Console output

The stage 'LOGIN', in touchpoint 'Login Infra (WORKLOAD)', the property 'dashboard_url', should be array

Your Environment

Pathpoint version v.1.7.6

• NR1 CLI version used:
• Browser name and version:
  Firefox 110.0.1 (64-bit)
• Operating System and version:
  macOS 13.2.1

Additional context

Repolinter Report

🤖This issue was automatically generated by repolinter-action, developed by the Open Source and Developer Advocacy team at New Relic. This issue will be automatically updated or closed when changes are pushed. If you have any problems with this tool, please feel free to open a GitHub issue or give us a ping in #help-opensource.

This Repolinter run generated the following results:

• Passed
  • ✅ license-file-exists
  • ✅ readme-file-exists
  • ✅ readme-starts-with-nr1-catalog-header
  • ✅ readme-contains-security-section
  • ✅ readme-contains-link-to-security-policy
  • ✅ readme-contains-discuss-topic
  • ✅ third-party-notices-file-exists
  • ✅ code-of-conduct-should-not-exist-here
  • ✅ github-actions-workflow-file-exists
  • ✅ nr1-catalog-config-file-exists
  • ✅ nr1-catalog-screenshots-directory-exists
  • ✅ nr1-catalog-documentation-file-exists
  • ✅ package-scripts-present

Passed #

References

PR: #34
failed action: https://github.com/newrelic/nr1-pathpoint/actions/runs/1758312693

Issue

When attempting to update the version of the application in the package.json file, the version is not bumping correctly and the release job is failing on the error:

Error: Command failed with exit code 128: git tag v1.0.0 682bac8d79ea7ad61adbea9879c73f4728e68099
fatal: tag 'v1.0.0' already exists
    at makeError (/home/runner/.npm/_npx/1684/lib/node_modules/semantic-release/node_modules/execa/lib/error.js:60:11)
    at handlePromise (/home/runner/.npm/_npx/1684/lib/node_modules/semantic-release/node_modules/execa/index.js:118:26)
    at runMicrotasks (<anonymous>)
    at processTicksAndRejections (internal/process/task_queues.js:95:5)
    at async tag (/home/runner/.npm/_npx/1684/lib/node_modules/semantic-release/lib/git.js:224:3)
    at async run (/home/runner/.npm/_npx/1684/lib/node_modules/semantic-release/index.js:191:5)
    at async module.exports (/home/runner/.npm/_npx/1684/lib/node_modules/semantic-release/index.js:260:22)
    at async module.exports (/home/runner/.npm/_npx/1684/lib/node_modules/semantic-release/cli.js:55:5) {
  shortMessage: 'Command failed with exit code 128: git tag v1.0.0 682bac8d79ea7ad61adbea9879c73f4728e68099',
  command: 'git tag v1.0.0 682bac8d79ea7ad61adbea9879c73f4728e68099',
  escapedCommand: 'git tag v1.0.0 682bac8d79ea7ad61adbea9879c73f4728e68099',
  exitCode: 128,
  signal: undefined,
  signalDescription: undefined,
  stdout: '',
  stderr: "fatal: tag 'v1.0.0' already exists",
  failed: true,
  timedOut: false,
  isCanceled: false,
  killed: false

Expected

The release job runs successfully and the version changes