neworbit / malwarescan.amsi Goto Github PK

We use NLog in our solution. It seems that LibLog resolves and initializes NLog provider with the configuration we have in the project root. This means that Malware scanner tries to internally write according to our default nlog configuration when running unit tests. This even causes tests to crash when they try to resolve NLog db connection while lacking permissions.

As a workaround we clear the NLog configuration via static access point at the start of unit test
LogManager.Configuration = new NLog.Config.LoggingConfiguration();

However I think this is an ugly and unwanted side effect.
Maybe this could be avoided by using ILogger interface and dependency injection approach instead. Let the software always decide the implementation instead of sniffing for usable providers.

Hi There,

Just a thought for documentation - from reviewing the source code it looks like this would be safe to register as a singleton in DI and reuse it across threads. If you agree: it would be good to add this information to the documentation?

Cheers,
Stuart

Allow insights into what happens underneath the covers.

Hello - thank you for creating this library, its very useful.

I'm getting OutOfMemoryException when trying to scan large files 500mb and bigger. Sharing the details below:

I took a look at the CopyToByteArray() method implementation, but not sure what should be modified. I'm able to successfully open the same big file using File.OpenRead (returns FileStream) and File.ReadAllBytes (returns byte array). I wonder if CopyToByteArray() could be modified to handle large files. Is this something that could be addressed?

Thanks in advance!

System.OutOfMemoryException: Exception of type 'System.OutOfMemoryException' was thrown.
        at MalwareScan.AMSI.MalwareScanner.CopyToByteArray(Stream stream)
        at MalwareScan.AMSI.MalwareScanner.HasVirus(Stream stream, String filename)