neworbit / eslint-config Goto Github PK

This is bad:

<h1>This is a really really really
    long title</h1>

This is good:

<h1>
    This is a really really really
    long title
</h1>

Not sure if we can lint for this but it would be good if we could.

Covered here.

Covered here

As part of our migration to eslint we should re-write (or find if one exists already) in eslint the disallow root import rule

There is currently no support for jsx-ban-props. Further details can be found in the submitted issue here.

Covered here. Not fully supported.

Suggest we lint for usages of dangerouslySetInnerHtml

<p dangerouslySetInnerHTML={{ __html: myHtmlVar }} />

Usages of this should be minimal and could introduce an XSS attack vector so extra warnings around this seem sensible.

https://github.com/yannickcr/eslint-plugin-react/blob/master/docs/rules/no-danger.md

This seems like a sensible rule to introduce.

To copy directly from the following link:

Nesting ternary expressions can make code more difficult to understand.
e.g. var foo = bar ? baz : qux === quxx ? bing : bam;

https://eslint.org/docs/latest/rules/no-nested-ternary

In this config we have explicitly switched off the object-curly-spacing.
Looks like this has always been the case in this config most likely because it was not a rule that existed/was enable on the old ts-lint config.

I suggest that this would be a good rule for us to adopt for consistent code style and hopefully easy to adopt as there is a fixer for the rule too that will fix most/all of existing violations.

Covered here

Covered here