neuroo / json-ast Goto Github PK

It would be great if junker will allow to read over missing comma like in this case:

{
  "key1": "value1"
  "key2": 1
}

Repro steps:

1. git clone https://github.com/neuroo/json-ast/issues/new
2. npm install
3. npm run coverage

Expected:
Pass

Actual:

  ..............................

  29 passing (78ms)
  1 failing

  1) Test cases multi-line-comments-in-object:

      AssertionError [ERR_ASSERTION]: asts are not equal
      + expected - actual

 const ast = require("json-ast")
 const {parse, Visitor, AST} = ast;
 const json = `
    {
        "type": "regex",
        "pattern": "^\\w+$",
        "errorMsg": "Characters of Name should match regex ^\\w+$ ."
    }         
 `
 parse(json)

https://runkit.com/ecutdavid/58c215b66c0f8c0014b2d7ad

I discovered while traversing a produced AST that the node positions extended beyond the length of the file, nearly doubling the line length. After poking around and testing a hypothesis, I discovered that by normalizing lines endings to "\n", the line count returned to normal.

Operating System: Windows (works as expected on Mac)
Line ending: Windows standard (\r\n)

JSON source in question:

{
    "Snippet snippet": {
        "prefix": "snippet",
        "body": [
            "\"$1\": {",
            "\t\"prefix\": \"$2\",",
            "\t\"body\": [",
            "\t\t$3",
            "\t],",
            "\t\"description\": \"$4\"",
            "},"
        ],
        "description": "A snippet for creating new snippets"
    }
}

The normalization fix I applied in my parser abstraction is as follows:

function normalizeSourceLineEndings(source) {
    return source.split(/\r?\n/).join('\n');
}

I know this project is old, and potentially unmaintained, but I figured this issue would, at least, help someone else if they encountered a similar issue.

Thank you for building this.

Cheers!

I would like to use this package to pars and then pretty print JSON with comments. How can I do that? Using AST.JsonDocument.toJSON(ast) and similar methods does not sustain comments

The junker should handle this contents fine:

{
  name: "there",
  version: 2.0
}