netlogix / angular2-jsonapi-src Goto Github PK

The current convenient getter to a hasMany relation just fetches all related objects from the unit of work and returns an array which isn't bound to the source as soon as it is returned.
This means if consumer code adjusts that array, no exception is triggered, the array provided to the consumer code gets modified but those changes don't result in the payload or unit of work data being changed.

Reproduce:

let group = groupRepository.findOneByIdentifier(groupIdentifier);
console.log(group.members);

let newMember = memberRepository.create();
let members = group.members;
members.push(newMember);
group.members.push(newMember);

console.log(group.members);

The code above doesn't actually change the members of this group.

This code does change to members:

let group = groupRepository.findOneByIdentifier(groupIdentifier);
let newMember = memberRepository.create();
group.members = [...group.members, newMember];
console.log(group.members);

There is Object.observer() to make the first snippet working.
There is Object.freeze() to make the first snippet throw exceptions.

Currently we are fetching the single record when we already have it in the unit of work.
TODO:

• In the ResourceProxyRepository ->findByIdentifier check if we have the item in the unit of work and return it as Observable
• If we have includes check if there is more then one include and only fetch the includes and return the item. Otherwise fetch the hole item.
• Add already loaded includes to the meta data, so we can check if we need to fetch them
• How do we handle items in the unit of work when we have sparse fields

http://jsonapi.org/format/#fetching-sparse-fieldsets

• ResourceProxyRepository
• ConsumerBackend