Coder Social home page Coder Social logo

craft-starter's People

Contributors

adneforslund avatar andreasnaustdal avatar annazlinka avatar bendiksolevag avatar dependabot[bot] avatar fredrikkvalvik avatar haakonmb avatar jennur avatar jessepinuelas avatar kevinbodi avatar kmelve avatar lissomliksom avatar mhauken avatar nervetattoo avatar nilsnh avatar robinsandborg avatar svale avatar thomaslgj avatar timharek avatar tommyno avatar torgeirbeyer avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar

craft-starter's Issues

App chrashing on Heroku: This program requires PHP 5.5^

2015-12-07T18:39:34.560181+00:00 heroku[web.1]: State changed from crashed to starting
2015-12-07T18:39:34.544630+00:00 heroku[web.1]: Process exited with status 1
2015-12-07T18:39:35.927541+00:00 heroku[web.1]: Starting process with command `vendor/bin/heroku-php-nginx -C nginx_app.conf public`
2015-12-07T18:39:37.571263+00:00 app[web.1]: vendor/bin/heroku-php-nginx: line 197: -dnewrelic.enabled=0: command not found
2015-12-07T18:39:37.571455+00:00 app[web.1]: This program requires PHP 5.5.11 or newer; check your 'php' command.
2015-12-07T18:39:38.169770+00:00 heroku[web.1]: State changed from starting to crashed
2015-12-07T18:39:38.175045+00:00 heroku[web.1]: Process exited with status 1

Skriv guide for effektiv nedlasting av database for lokal utvikling

Pratet såvidt med @timharek om dette. Me kunne hatt ein markdown guide docs/sync-db.md som foreslår ein effektiv arbeidsflyt for synkronisering av produksjonsdata til lokal database.

Tips:

  • Kan vere nyttig å lage noke rundt hamstr som gjer det lettare å kople seg på remote databaser som krever at ein lager SSH tunnel i forkant.
  • Kanskje treng me berre å skrive litt om på denne kommandoen i package.json og gi den eit nytt namn?

Deprecated node version in nvmrc

Node 16 is deprecated and it seems like there is a difference between the version set in nvmrc and the one specified in the engines object in package.json

sass-cache

Jeg glemmer alltid å legge inn .sass-cache/.scssc i .gitignore, legge inn dette som default?

Docker does not allow craft to send e-mail

In its current state, the docker setup does not allow craft to send e-mail.

Proposed fix:
Add EXPOSE 587 to the Dockerfile.
By adding this line I was able to set up a user registration form sending validation e-mails through postmark.

Using port 25 still gave me an error, 587 seems to work.

Provide instructions for caching login sessions in redis

Currently we recommend specifying app-id in general.php to ensure logins are persisted between deployments. This hasn't been working for me. And I realized that Craft by default persists user sessions to disk but Heroku wipes that disk between deployes.

Recommend trying to setup redis for persistent user sessions and adding instruction to the readme.

Improve cache busting of css and javascript

This should be added to general.php

'aliases' => [
            '@deployId' => 'VERSION_CODE',
],

and we need to update css and js inclusion in the _layout template file:

<link rel="stylesheet" href="/dist/main.dist.css?v={{ alias('@deployId') }}">

<script src="/dist/main.dist.js?v={{ alias('@deployId') }}">

webpack fails if app.js contains "let" keyword

Inside /resources/js/app.js if you write something like

let something = "hello world"

The webpack build will fail. Not sure if it's the babel-loader or some form of linting that's erroring out. Seems to come from UglifyJS.

Error message:

> $ webpack                                                                      ⬡ 6.4.0 [±master ●●]
Hash: f5fc0ec6d50bff460a4f
Version: webpack 1.13.2
Time: 2156ms
             Asset     Size  Chunks             Chunk Names
    js/min/main.js   259 kB       0  [emitted]  main
css/min/screen.css  0 bytes       0  [emitted]  main
   [0] multi main 52 bytes {0} [built]
 [298] ./resources/js/app.js 30 bytes {0} [built]
    + 298 hidden modules

ERROR in js/min/main.js from UglifyJs
SyntaxError: Unexpected token: name (something) [./resources/js/app.js:2,0]
Child extract-text-webpack-plugin:
        + 2 hidden modules

No html tag in _layout.twig causing validation warnings

Html tag is missing in _layout.twig, however browsers seems to add it if missing.
Missing lang attribute cause validation warnings.

Possible fixes:
Add html tag to _layout.twig:
<html lang="nb">
or this might work for sites with multiple languages:
<html lang="{{ currentSite.language }}">

First time install of Craft fails

    > can't apply existing project config: Craft is installed at the wrong schema version (3.6.8, but project.yaml lists ).
    > moving config/project/ to storage/config-backups/project-2021-08-17-195053 ... Exception: rename(): The first argument to copy() function cannot be a directory (/var/www/html/vendor/craftcms/cms/src/migrations/Install.php:1091)
#0 /var/www/html/vendor/craftcms/cms/src/web/ErrorHandler.php(76): yii\base\ErrorHandler->handleError(2, 'rename(): The f...', '/var/www/html/v...', 1091)
#1 [internal function]: craft\web\ErrorHandler->handleError(2, 'rename(): The f...', '/var/www/html/v...', 1091, Array)
#2 /var/www/html/vendor/craftcms/cms/src/migrations/Install.php(1091): rename('/var/www/html/c...', '/var/www/html/s...')
#3 /var/www/html/vendor/craftcms/cms/src/migrations/Install.php(74): craft\migrations\Install->insertDefaultData()
#4 /var/www/html/vendor/craftcms/cms/src/db/Migration.php(52): craft\migrations\Install->safeUp()
#5 /var/www/html/vendor/craftcms/cms/src/db/MigrationManager.php(232): craft\db\Migration->up(true)
#6 /var/www/html/vendor/craftcms/cms/src/controllers/InstallController.php(300): craft\db\MigrationManager->migrateUp(Object(craft\migrations\Install))
#7 [internal function]: craft\controllers\InstallController->actionInstall()
#8 /var/www/html/vendor/yiisoft/yii2/base/InlineAction.php(57): call_user_func_array(Array, Array)
#9 /var/www/html/vendor/yiisoft/yii2/base/Controller.php(181): yii\base\InlineAction->runWithParams(Array)
#10 /var/www/html/vendor/craftcms/cms/src/web/Controller.php(190): yii\base\Controller->runAction('install', Array)
#11 /var/www/html/vendor/yiisoft/yii2/base/Module.php(534): craft\web\Controller->runAction('install', Array)
#12 /var/www/html/vendor/craftcms/cms/src/web/Application.php(278): yii\base\Module->runAction('install/install', Array)
#13 /var/www/html/vendor/craftcms/cms/src/web/Application.php(581): craft\web\Application->runAction('install/install', Array)
#14 /var/www/html/vendor/craftcms/cms/src/web/Application.php(543): craft\web\Application->_processActionRequest(Object(craft\web\Request))
#15 /var/www/html/vendor/craftcms/cms/src/web/Application.php(187): craft\web\Application->_processInstallRequest(Object(craft\web\Request))
#16 /var/www/html/vendor/yiisoft/yii2/base/Application.php(392): craft\web\Application->handleRequest(Object(craft\web\Request))
#17 /var/www/html/public/index.php(21): yii\base\Application->run()
#18 {main}

Strukturere SASS/CSS

Legge inn filstruktur for SASS og CSS.
F.eks. tomme filer i en gitt struktur.
Da kan også css lenkes klart i templaten.

Ut av boksen støtte for flerspråklighet

Sette opp sånn at craft skjønner foo.com/en eller foo.com/no eller hvilket sekundærspråk du nå setter opp.

Enkel variabel du kan teste mot { currentLang } eller noe.

Update PHP, Craft CMS and plugins

We need to update to a newer version of PHP for security reasons.

We should also update Craft CMS and plugins to versions which are being supported.

Add robots.txt.twig

Example from geodata.no we have a file called robots.txt.twig.

{% header "Content-Type: text/plain; charset=utf-8" %}
User-agent: *
{% if 'herokuapp' in craft.request.url %}
Disallow: /
{% else %}
Disallow: /styleguide
{% endif %}

Add troubleshooting.md

We should add a troubleshooting.md file and link to it from the readme.md. The file should include some common use cases and suggestions on how to debug and fix them.

We can start simple. 🌱We should encourage everyone to contribute.

Each problem in the troubleshooting file could contain:

Problem name (subtitle) <-- is it possible to make title linkable?

  • Symptom
  • Possible cause
  • Suggested fix

Add upgrade instructions

We should develop/research a nice way for users to upgrade their build setup to the current craft-starter build setup.

Strømlinjeforme deploy oppsett og mappestruktur

RFC: Request for comments.

Craft CMS har bytta ifrå public/ til web/ som web root i sin anbefalte mappestruktur.

@svale har foreslått at starteren burde reflektere denne endringen. Eg syns det høres bra ut, og så fordrer dette at me også endrer på litt andre greier relatert til deploy.

Servebolt bruker i dag public/ som web root så viss me byrjer å bruke web/ mappe for lokal utvikling så må me sørge for at deploy steget automatisk teiper over denne skilnaden.

Endringsforslag

  1. Skriv ein buddy.yml fil som definerer bygge-pipeline. Dette er i tråd med infrastructure as code tilnærmingen.
  2. Omnavn public/ til web/ og sørg for å oppdater både dokumentasjon og kode relatert til lokal utvikling og livereloading.
  3. Oppdater buddy.yml slik at byggesteget tek høgde for at det blir lagd ein symlink frå public/ til web/ i server-miljøet. Foreslå gjerne ein annen løysing om det kan passe betre.
  4. Skriv ein guide docs/deployment-servebolt.md som set brukerar i stand til å settje opp deploy løpet sjølv og link til den i readme.md.

Rewrite for .htaccess

Legge til en rewrite regel slik at "craft" og "public" kan ligge på samme nivå i filstrukturen?

Legg til automatisert test for ytelse

Problem:

Det er lett å gløyme å sjekke ytelsen når me lager nettsider.

Løysingsforslag

Forske på og utvikle ein automatisert test som sjekker at forsiden laster raskt og at den ikkje henter inn for mange ressurser. I prosjekter så kan utviklere legge til fleire tester for andre undersider. Testene kan kjøres av Buddy Works på passende tidspunkt.

Alternativt, så kan me plassere eit Lighthouse steg i Buddy Works etter deploy av løsningen som rapporterer om noko har blitt verre siden sist? (Oppdaget denne no, og den er kanskje den lettaste og raskaste måten). Og det finst ein løysing for GIthub actions også: https://blog.logrocket.com/lighthouse-meets-github-actions-use-lighthouse-ci/ .

Kjelder

Add plugin: The architect

Use case: It would be great to be able to create fields within the Craft installation from the command line.

Rammeverk

Hadde det vært en idé å legge inn linjer (gjerne kommentert ut) for å få inn ting som inuit/bootstrap/foundation/modernizr/jquery etc. i package.json?

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.