Memory Leaks about netket

[gcarleo]

Would you consider moving past your state of shock and suggest a concrete correction to this (potential) issue?

[twesterhout]

Of course, and I've already suggested a fix: use std::unique_ptr. You get memory safety at no noticeable performance cost.

[gcarleo]

OK thanks, I fixed this in the latest commit 7402132

[twesterhout]

I have a more general question: how would you feel about receiving a whole lot of similar bug reports? Would you be willing to accept PRs improving code quality or is the state where the code "runs" good enough?
The reason I'm asking this is because I'm trying to decide whether it makes sense to abandon my own similar code in favour of this project.

[gcarleo]

As long as the bug reports concern potential performance/stability issues in the code, it is perfectly OK and well accepted. Reports concerning coding style issues that do not affect performance, and do not improve the code usability, might not be considered.
Forks and pull requests is of course a good way of actively proposing changes to the code.

[twesterhout]

I see. Thanks for the honest answer!