Coder Social home page Coder Social logo

Comments (5)

PhilipVinc avatar PhilipVinc commented on June 24, 2024

Can you try to add a @jax.jit to the MetropolisSampler.reset method?

Otherwise @inailuig might know better.

from netket.

inailuig avatar inailuig commented on June 24, 2024

#1721 will fix this

The issue is that the key in

σ = sampler.rule.random_state(sampler, machine, parameters, state, rng)

is sharded after the first call, but random_state is not jitted, so it errors if its called with non fully addressable arrays.

from netket.

inailuig avatar inailuig commented on June 24, 2024

@PhilipVinc mabye we can do a bugfix release which includes #1727
and I'll complete this todo

σ = sampler.rule.random_state(sampler, machine, params, rule_state, rng)
if config.netket_experimental_sharding and jax.device_count() > 1:
# TODO If we end up rewriting the hilbert spaces in jax then we can avoid
# this and instead jit the random state with the correct out_shardings
σ = distribute_to_devices_along_axis(σ, axis=0)

in the other PR to solve it properly later.

from netket.

PhilipVinc avatar PhilipVinc commented on June 24, 2024

Solved by #1727 , released few moments ago in netket 3.11.1

from netket.

therooler avatar therooler commented on June 24, 2024

Thanks guys, I appreciate the quick fix!

from netket.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.