neopoly / rubyfox-server Goto Github PK

Hey there,

While reviewing the source code of rubyfox-server I've noticed, that several files in the lib/ directory have executable permissions while not being an executables.

For example:

lib/rubyfox/server/data/lib/httpclient-4.5.2.jar
lib/rubyfox/server/data/lib/slf4j-api-1.7.5.jar
lib/rubyfox/server/data/lib/Lib/sre_constants$py.class
lib/rubyfox/server/data/lib/commons-codec-1.9.jar
lib/rubyfox/server/data/www/ROOT/_images_/logo_smartfoxserver.png
lib/rubyfox/server/data/lib/Lib/email/test/data/PyBanner048.gif
# and many more...

is that something intended? If so, I would appreciate explanation as I often find it as a bug.

Thank you 🙏

When updating the bundled Smartfox server, it might happen that it overwrites the exec definition in sfs2x.sh.

This can break the setup.

Please add a spec/test which ensure that exec ... is part of the file.