nelmio / nelmioesidebugbundle Goto Github PK

Hi,

I'm running Symfony 2.1 and I wasn't able to make the bundle work. The bundle is loaded and I have the "Hide ESI" button in the WDT but there is no ESI debug on the screen.

After digging the code, I have commented the following condition in the Kernel event listener:

if (!preg_match('{^text/html\b}', $response->headers->get('Content-Type'))) {
    return;
}

My ESI action is rendered with the @template annotation and at this moment there is no Content-Type in the Response.

I looked at the Profiler to see in which order event listeners are called. This is the result:

kernel.response     0   ContextListener::onKernelResponse
kernel.response     0   ResponseListener::onKernelResponse
kernel.response     0   FirePHPHandler::onKernelResponse
kernel.response     0   CacheListener::onKernelResponse
kernel.response     0   Kernel::onKernelResponse <-- Your event listener
kernel.response     0   ResponseListener::onKernelResponse <-- Prepare headers
kernel.response     0   EsiListener::onKernelResponse
kernel.response     -100    ProfilerListener::onKernelResponse 

I think the order is not correct. The Nelmio Kernel event listener is called too soon. It's called before the Symfony ResponseListener event listener that prepares the response. This listener sets headers and I think it also sets the Content-Type header field.

So, ResponseListener should be called before Kernel event listener.