neilime / php-css-lint

CSS Linter for PHP

Hi 👋, I'm Emilien Escalle

CEO @ ESCEMI and CTO @ Your service

• 📫 How to reach me https://www.linkedin.com/in/emilienescalle/

 

php-css-lint's Issues

Close down API

Most methods/properties are declared as protected which I don't think should be the case as most of them work on its self and therefore should be declared private.

I would also suggest to make the Linter class final and to add the private visibility to class constants (Available as of PHP 7.1, which this library already targets).

Specify file indentation

I'm working with files that mostly have tabbed indentation. After digging through the code, I wasn't able to find a way of specifying the type of indentation in a file.

Is there such an option, and if not - will it be much of a hassle to implement?

Take CSS in from STDIN

Hey,

I would like a way to potentially take input from STDIN. As there is some PHP involved in the generation of my styles, I cannot reliably run automated tests on them using your library, however I like the fact that it is in PHP (and thus in composer).

Is there any way support for this option could be added?

Fails when testing with what appears to be a valid file

I've been trying to find a good PHP linter that checks if a CSS string has valid syntax. So far, this is the only one that has gotten the job almost right. My tests are done on the official stylesheet of WordPress' twentyseven theme - style.css. It returns a lot of errors, which I imagine shouldn't be flagged as such.

Here's the same file tested with the w3c's validator - link.

Tested with latest version from master (before and after indentation update).

Inject Properties class into Linter to respect Dependency Inversion principle

Currently the Properties class is not declared as final but it's impossible to inject an extended class of it into the Linter.

For this I would propose to add a constructor to Linter and remove the getCssLintProperties() method.

Commandline modifiers for easy CI integration

Currently if you want to allow tabs on the files, you need to create your own script to run the linter.

It would be nice to have a command line parameter to weak this sor of configurations.

This would make it easier to use this script in a CI environment

Doesn't accept CSS variables

Describe the bug

The linter doesn't seem to accept CSS variables.

To Reproduce

Introduce a CSS variable:

:root {
  --border-radius: 3px;
}

This throws an error:

Unknown CSS property "--border-radius" (line: 1980, char: 20)

Expected behavior

CSS variables are valid CSS.

https://developer.mozilla.org/en-US/docs/Web/CSS/Using_CSS_custom_properties