neg4n / tr Goto Github PK

Hello there, I'd like to make a short review of the library and point out some issues and how to fix them.

1. https://github.com/neg4n/tr/blob/master/include/tr.hpp#L22
   The Xor library you're advising people to use will cause issues on specific computers/CPUs, from my remote debugging it appears to be invalid ASM, might be due to the compiler (MSVC x86), but I'm just advising that you use something more like this (https://www.unknowncheats.me/forum/c-and-c-/164273-xor-compile-time.html), I have tested it and the speed should be around the same and it worked on every computer it was tested on.

2. Universal - Many code parts are fundamentally flawed because, at the standard where they're put, they don't respect the best C++ practices even in simple situations. Revise some of the code while checking in with https://github.com/lefticus/cppbestpractices

3. Structures, for OOP, I recommend you start using classes. It shouldn't be that much of an issue, but afterall, you're writing C++, the language who was first made to bring classes to C for OOP. Your code had a mix of both. Also you should explore by protecting fields of code that don't need to be public, so people don't encounter issues when they try to tinker with the library. I know that this isn't intended, but it's good for suppossive new developers experimenting with your code.

4. "printf", I recommend you stop advising for it, since there is cout, again, we are writing C++. This might be a nitpick, but I'd try to impose cout if I were you.

Kindest regards