neeckeloo / newrelic Goto Github PK

allow chaining method on NewRelic\Client functions to use like

$client = $this->getServiceLocator()->get('NewRelic\Client');
$client->backgroundJob(true)->nameTransaction('my_name');

e.g.

    /**
     * {@inheritdoc}
     */
    public function nameTransaction($name)
    {
        if (!$this->extensionLoaded()) {
            return;
        }

        newrelic_name_transaction($name);

        return $this;
    }

It would be cool if the library also could push to the Insights collector.

There is a bug enabling strict types:

ini_set() expects parameter 2 to be string, bool given

You should check these types and covert them to strings

Wouldnt it be better to send the real URL as a name instead of the called route? If hou have dynamic routes and you want to analyse with specific paramters you cant see which parameters have a huge load time or throughput or smth. You only see the route.

Nice Module!

 Uncaught TypeError: Argument 1 passed to NewRelic\Listener\ErrorListener::createLogMessageFromException() must be an instance of Exception, instance of Error given, called in /var/www/www/vendor/neeckeloo/newrelic/src/Listener/ErrorListener.php on line 56 and defined in /var/www/www/vendor/neeckeloo/newrelic/src/Listener/ErrorListener.php:61

private function createLogMessageFromException(\Throwable $exception)
{
    return $exception->getFile()
        . ":" . $exception->getLine()
        . ": " . $exception->getMessage();
}

Should fix the error!

include module name on ignore list

return array(
    'newrelic' => array(
        'ignored_transactions' => array(
            'module' => array(
                'Foo',
                'Bar',
                'Baz',
            ),
        ),
    ),
);

and optionally with controller/action

return array(
    'newrelic' => array(
        'ignored_transactions' => array(
            'module' => array(
                array('Foo', array('FooController', 'BarController')),
                array('Bar', array( array('BazController', array('foo', 'bar')))),
                'Baz',
            ),
        ),
    ),
);

It's pretty obvious, but you might want to add into the readme that you need to add 'NewRelic' to the application.config.php modules array.

When using console request the route can be a invalid transaction name

• php index.php do-stuff users
• php index.php do-stuff places

This can lead to different controllers/action but in new relic will only show "do-stuff" on the transaction name

I´m using

$this->getServiceLocator()
->get('NewRelic\Client')
->nameTransaction('/console/[controller]/[action]');

And since is a ConsoleRequest, can it be automatically set as a background job?

Hi,

I would like to use the lib with a ZF2.3.9 application. Is there any way?

Thanks,
Ingmar