nedap / archie Goto Github PK

Hi Pieter,

I found a small typo in the file OperatorKind.java. The "ge" is wrongly defined.
Thought you wanted to know this.

best regards
Bert Verhees

Hi Pieter, in the aom-class Archetype is function:
public ArchetypeTerm getTerm(CObject object, String code, String language) {
return getTerminology().getTermDefinition(language, code);
}

The parameter CObject object is not used, that does not seem right, is that an error?

Hi Pieter, you asked for comments, so I have one.

In the CComplexObject-class I found this method: public void addAttribute(CAttribute attribute)
Opening this functionality can cause bugs when developers are going to use it.

In my opinion this shouldn't be necessary because the AOM gets the attributes from the ADL-parser (or another parser), and only there. There may not be another way to do this.
The only place where the class can get its attributes is in the constructor.
As you look to the ADL-Parser/AOM from Rong Chen, you see that he put much effort in keeping the code clean from mutability.

Bert