Comments (5)
Here's a quick mock of what it could look like (just made with Inspect Element :P ). The "2 others" could expand to everyone who's favorited your post when you click it as well.
from mastodon.
Interestingly, there's a <AvatarComposite>
component that we can use, i think right now it's only really used for DMs.
Even more interestingly, it's imported into status_header (the component that renders "{acct} has favourited your post" unused, meaning it looks like either this was already a feature at one point, or it's a feature that someone wanted to work on but never fully went through.
from mastodon.
FediLab implements this and I'm a big fan. Definitely want this!
from mastodon.
Even more interestingly, it's imported into status_header (the component that renders "{acct} has favourited your post" unused, meaning it looks like either this was already a feature at one point, or it's a feature that someone wanted to work on but never fully went through.
btw this is a lie, unfortunately I don't think we can use AvatarComposite for our use-case
from mastodon.
Alright, I have something whipped up. Going to do some extra local testing and then create the PR into master for some review. So far, this touches quite a bit of code, so it might cause some merge conflicts whenever we want to merge upstream in. This is because I had to change the account
property in notifications and statuses from a single object to a list of objects, so quite a lot of logic had to change to deal with that.
Also just noticed that now profile icons aren't rendering... time to figure that out ahaha
I also still need to implement the option to hide all of this logic behind.
from mastodon.
Related Issues (20)
- Boosts are only inserted into the public timelines on page refresh HOT 1
- Old posts sometimes inserted into the timeline HOT 8
- Add setting in Local/Federated timeline to hide boosts HOT 2
- Emojis in a linked status do not zoom
- Hashtag ordering kinda sucks HOT 22
- Allow for status action customization HOT 1
- Add a way to see who reacted to a post HOT 1
- The emoji picker is not forced within the screen bounds HOT 6
- Add ability to collapse reaction notifications (just like boost and favorite)
- custom emoji don't show in notifications
- Allow customization of number of visible lines in a collapsed status HOT 1
- Show full reaction counts on remote posts HOT 2
- Updates required to fix Linting
- [Wording] Consider either clarifying what "otaku" means or replacing the word with something less derogetory
- Bug: NoMethodError when accessing nil value in has_user_settings.rb (setting_flavour) HOT 1
- ArgumentError (missing keywords: :records, :associations) after update HOT 1
- Emoji Reactions not converting to Favourites on Vanilla Mastodon instances HOT 1
- mp3 uploads not playing HOT 1
- `ReferenceError: ReactIcon is not defined` on Vanilla Mastodon HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from mastodon.