Coder Social home page Coder Social logo

Comments (5)

deanveloper avatar deanveloper commented on August 26, 2024 1

Here's a quick mock of what it could look like (just made with Inspect Element :P ). The "2 others" could expand to everyone who's favorited your post when you click it as well.

image

from mastodon.

deanveloper avatar deanveloper commented on August 26, 2024 1

Interestingly, there's a <AvatarComposite> component that we can use, i think right now it's only really used for DMs.

Even more interestingly, it's imported into status_header (the component that renders "{acct} has favourited your post" unused, meaning it looks like either this was already a feature at one point, or it's a feature that someone wanted to work on but never fully went through.

from mastodon.

neatchee avatar neatchee commented on August 26, 2024

FediLab implements this and I'm a big fan. Definitely want this!

from mastodon.

deanveloper avatar deanveloper commented on August 26, 2024

Even more interestingly, it's imported into status_header (the component that renders "{acct} has favourited your post" unused, meaning it looks like either this was already a feature at one point, or it's a feature that someone wanted to work on but never fully went through.

btw this is a lie, unfortunately I don't think we can use AvatarComposite for our use-case

from mastodon.

deanveloper avatar deanveloper commented on August 26, 2024

Alright, I have something whipped up. Going to do some extra local testing and then create the PR into master for some review. So far, this touches quite a bit of code, so it might cause some merge conflicts whenever we want to merge upstream in. This is because I had to change the account property in notifications and statuses from a single object to a list of objects, so quite a lot of logic had to change to deal with that.

image

Also just noticed that now profile icons aren't rendering... time to figure that out ahaha

I also still need to implement the option to hide all of this logic behind.

from mastodon.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.