Comments (8)
Yeah I'm almost certain that's the issue. Glad sidekiq logged it! My bad, I'll take a look to see if there's some Ruby tooling in VSCode that will catch stuff like before it's an issue at runtime since this was introduced by me LOL
from mastodon.
For the record, this is probably a mastodon/glitch-soc bug but I'm not sure
from mastodon.
I think this is intended design: The federated feed displays anything that is interacted with by users on our instance, right? If one of our users favorites a day old post, that post will show up in the federated feed shortly thereafter despite being a day old.
There might also be some access pattern stuff going on here? I'm not familiar enough with the internals, but I know there is a comprehensive retry system in place, so this could theoretically be a consequence of a very stale request finally going through to another server.
from mastodon.
https://urusai.social/@[email protected]/109603022970728801
This 2 day old post appears to be entirely unprompted - no favorites nor boosts (within our federation). I think you might be right with the stale request. It just seems weird how often this occurs, and it's almost always with this exact account. Granted I don't know if I follow any other accounts from botsin.space.
Possible solutions could be either to implement this on the frontend by sorting the post into the correct spot, or on the backend by doing a quick "recency" check (ie, only posts/boosts from the last 5 minutes will be sent over pubsub/websockets)
from mastodon.
So, keep in mind, we federate with a relay. Relay-provided posts won't show follows unless you click all the way through to their instance (and they have it visible).
And this probably goes back to my security concern re: young accounts - I could imagine that the bot account owner also set up follower accounts on big instances that automatically like/boost posts from the bot account after N hours
from mastodon.
Nevermind, there's definitely something up. I'm rolling back the public boost feature too see if that resolves it as only posts within the past 3 days are showing this behavior
from mastodon.
Ok, so before reverting Sidekiq was showing a ton of retry entries with a "missing argument" error related to "silenced_account_ids". I think this is the culprit line:
Note that in the function immediately preceding that line we have a second argument in the publish function for "anonymous_payload"
I'm like 99% sure that's it as that payload contains the rendered_status variable which I would assume is how the timeline filters out things like old posts from appearing a second time on the home timeline due to new boosts/etc and how post publishing works.
Testing that as a fix now.
from mastodon.
Upside, that may be (at least part of) the feature(s) we need to pipe through to the local/federated timelines to help with suppressing duplicate boosts when that's enabled :D
from mastodon.
Related Issues (20)
- Boosts are only inserted into the public timelines on page refresh HOT 1
- Add setting in Local/Federated timeline to hide boosts HOT 2
- Emojis in a linked status do not zoom
- [frontend-only] Option to combine similar notifications into a single notification HOT 5
- Hashtag ordering kinda sucks HOT 22
- Allow for status action customization HOT 1
- Add a way to see who reacted to a post HOT 1
- The emoji picker is not forced within the screen bounds HOT 6
- Add ability to collapse reaction notifications (just like boost and favorite)
- custom emoji don't show in notifications
- Allow customization of number of visible lines in a collapsed status HOT 1
- Show full reaction counts on remote posts HOT 2
- Updates required to fix Linting
- [Wording] Consider either clarifying what "otaku" means or replacing the word with something less derogetory
- Bug: NoMethodError when accessing nil value in has_user_settings.rb (setting_flavour) HOT 1
- ArgumentError (missing keywords: :records, :associations) after update HOT 1
- Emoji Reactions not converting to Favourites on Vanilla Mastodon instances HOT 1
- mp3 uploads not playing HOT 1
- `ReferenceError: ReactIcon is not defined` on Vanilla Mastodon HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from mastodon.