ndayishimiyeeric / awesome-books

Awesome Books is a Libray where you can add a book and it author using the Local Storage. it has functionality of a SPA where you can add, view Added Book(s) and a contact sections. this is all done using javascript modules.

Hi there, I'm Ndayishimiye Eric! 🖖

Full-Stack Developer specializing in Distributed Artificial Intelligence.

Front-End: Typescript, React, Next.js, HTML5, CSS3
Back-End: Python, Java, Spring boot, FastApi, MySQL, Prisma
MAS: JADE(Java Agent DEvelopment Framework)
Tools & Methods: Git, Github, Gitflow, Railways, Varcel, Docker, Chrome Dev Tools
Professional: Remote Pair-Programming, Teamwork

awesome-books's Issues

Morning session: Peer-to-peer code review

Hi ndayishimiyeeric,

Good job so far!
There are some issues that you still need to work on to make your code better than it is!

To Highlight 🎉

• No linter errors. ✔️
• GitHub flow is followed. ✔️
• Professional README file. ✔️
• Good use of ES6 modules. ✔️

Suggested Changes ♻️

• since you used this block of code more than once kindly put this two lines inside it own function which will make your code DRY and less repeated

  awesome-books/modules/class.js

  Lines 32 to 33 in 8940afc

  	localStorage.setItem('books', JSON.stringify(this.booksArray));
  	this.displayBooks();

• in index.html kindly add the link to your home page when someone clicks the logo
  

  awesome-books/index.html

  Line 12 in 8940afc

  <a href="#" id="logo">Awesome Books</a>

• it would be better if you download luxon using npm packages instead of downloading it as a javascript file

Cheers and Happy coding!👏👏👏

Peer to peer code reivew!

Hammad Siddique: You have done a good job it's hard to find any issues there!

Yusuf Nviiri: Please Add a message to the user if he adds an empty field as u did when he adds book.

@ABDULALI3468: Well your code is properly organized and very descriptive. Moreover, you got many commits for every point which is also inaccordance with the industrial practices.