ncracker / dd_ansible Goto Github PK

Rather than www.google.com in the text, perhaps consider [Google](www.google.com)? I think it gives the article a cleaner look?

I think we should caution against committing those changes (DD API key) back to source control. Or if there is some way we could source from environment or command line input that would be great. This is always an issue, and often complex to solve, but at a minimum I think there should be a note regarding the sensitivity and taking care not to expose those keys.

Might require some finagling, but leveraging Vagrant as a host to connect to and install the agent on? I am using the Vagrant provisioner here: https://github.com/ckelner/datadog-ansible-vagrant-terraform -- but I imagine you could use Ansible itself to connect to the Vagrant as well after it gets spun up? This lowers the barrier for someone following the blog (they don't need to have some server running somewhere, you can walk them through running vagrant up and getting the ip of the machine (see: https://www.vagrantup.com/docs/networking/public_network.html) to insert into the Ansible hosts file?

requirements.txt gets a mention at the very end, but I feel like this is the most acceptable way, coupled with a virtualenv, when dealing with py packages. Not suggesting you need to restructure the blog post, but might be worth mentioning earlier on?