nclavaud / mininova-web-editor Goto Github PK

Novation MiniNova isn't supported by standard Linux kernel.
and it's not enough to allow MiniNova to be recognized by udev rules.

It's requires also to build kernel and include definitions to sound/usb/quirks-table.h

Dear @nclavaud

I found some issues. Maybe it's related to missing dependencies.

Steps to reproduce:

1. Cloned repository
2. Installed yarn packages with:
   yarn install
3. Started development server with:
   yarn start
4. Successfully found my Mininova, selected ports
5. I can change all parameters, such as Arp, OSC, LFOs etc.
6. When I select Randomize ot Reset defaults (only) it gives me error message for Randomize:

emit
src/App.tsx:60

  57 |     return;
  58 |   }
  59 |   debugMidiMessage(message, 'Output: ');
> 60 |   output.send(message);
     | ^  61 | };
  62 | 
  63 | const onChangeOutput = () => selectPatch(emit);

randomize
src/components/Controls.js:41

  38 |       continue;
  39 |     }
  40 |     const value = control.range ? randomInt(...control.range) : randomInt(0, control.enum.length);
> 41 |     emit(control.msg(value));
     | ^  42 |     dispatch(patchControlChanged(controlId, value));
  43 |   }
  44 | };

and this for Reset Defaults:

resetDefaults
src/components/Controls.js:30

 27 | const resetDefaults = () => {
  28 |   for (let [controlId, control] of Object.entries(controls)) {
  29 |     const value = control.init;
> 30 |     emit(control.msg(value));
     | ^  31 |     dispatch(patchControlChanged(controlId, value));
  32 |   }
  33 | };

In terminal I see this:

src/App.tsx
Line 65:42: React Hook useCallback has a missing dependency: 'output'. Either include it or remove the dependency array react-hooks/exhaustive-deps

Thank you for checking this.