nation3 / citizen-app Goto Github PK

https://app.dework.xyz/nation3/app-2?taskId=52213f7d-c0f1-4b62-8545-6f4f9f794ea7

Unhandled promise rejections are making integration tests unstable: https://github.com/nation3/app/runs/7461874997?check_suite_focus=true

To reproduce, open https://app.nation3.org/ in a browser without Web3 support.

javascript
Uncaught (in promise) Error: invalid address or ENS name (argument="name", value=undefined, code=INVALID_ARGUMENT, version=contracts/5.6.1)
    at d.makeError (_app-f771c5453f43eeba.js:1:107374)
    at d.throwError (_app-f771c5453f43eeba.js:1:107494)
    at d.throwArgumentError (_app-f771c5453f43eeba.js:1:107549)
    at _app-f771c5453f43eeba.js:1:63972
    at Generator.next (<anonymous>)
    at s (_app-f771c5453f43eeba.js:1:63452)

Add license for this repository's code to LICENSE.md.

Page is not displayed properly on mobile: https://app.nation3.org/citizen

First reported in Discord.

Depends on #175

After have done an unlimited approval before:
https://etherscan.io/tx/0xf58e4108795db19e424ef987e29c9d0e29c0a7530b2a4ce4a54ff662dc3b019f

The UI for /liquidity keeps asking for approval again:

Initially reported by other user.
Same behaviour on /lock.

@luisivan we should also publish the goerli .env contract addresses

Originally posted by @gregfromstl in #14 (comment)

https://app.dework.xyz/nation3/citizen-app-p?taskId=1e2d33dc-48bc-4d33-a0c1-7491c459f008

https://app.nation3.org/lock

https://app.dework.xyz/nation3/citizen-app-p?taskId=f614e270-4baf-4e1a-80d7-a6a9f3ad1234

How to reproduce:

1. Connect an Ethereum account (press "Sign in") at https://app.nation3.org using the Ethereum mainnet.
2. Go to https://app.nation3.org/lock, and put a number in the "Lock amount" field. Use a number that is larger than you currently locked $veNATION
3. Adjust the "Lock expiration date."
4. "Your final balance will be approx $veNATION" shows a negative number.

https://app.nation3.org/join

During development, when NEXT_PUBLIC_CHAIN=goerli, use https://goerli.balancer.fi instead of https://app.balancer.fi.

This way, a developer can more easily trade and pool $NATION tokens on the Goerli testnet.

Balancer pool on Goerli: https://goerli.balancer.fi/#/pool/0x6f57329d43f3de9ff39d4424576db920b55060b30002000000000000000000d7

The files that need to be updated are:

1. https://github.com/nation3/app/blob/130d1fec82f44a209969164d1ad17b835569b9d7/ui/pages/index.tsx#L85

2. https://github.com/nation3/app/blob/130d1fec82f44a209969164d1ad17b835569b9d7/ui/pages/index.tsx#L98

3. https://github.com/nation3/app/blob/0e0bb4d2bdd28406a7b8f7cd5ed693234eb956ae/ui/pages/claim.tsx#L84

4. https://github.com/nation3/app/blob/956c1e33fcff3e7dcaac3136c3602b60ebd6e974/ui/pages/join.tsx#L184

5. https://github.com/nation3/app/blob/c3073acb4fa10215cd41e3a5bcba4444a8fa6acb/ui/pages/liquidity.tsx#L100

6. https://github.com/nation3/app/blob/4c73d693a678c7b7885b5c07d9e11fb5b10f1fa9/ui/components/Layout.tsx#L69

7. https://github.com/nation3/app/blob/main/contracts/deployments/goerli.json

https://app.dework.xyz/nation3/develop-1?taskId=d59d16fb-9471-44ab-b56e-e070c9756fa0

https://app.dework.xyz/nation3/app-2?taskId=0554bc64-e2b2-4161-90b5-75997aaf3891

A bug causes the "Lock expiration date" slider at https://app.nation3.org/lock to automatically adjust itself to the original date after a few seconds, which is causing trouble for users interacting with the app:

How to reproduce:

1. Go to https://app.nation3.org/lock
2. Adjust the slider, then wait for ~10 seconds

If you are having trouble reproducing this behavior, it could be that this bug only happens for users that have already locked $NATION. If that's the case, you can obtain some test tokens at https://goerli.balancer.fi/#/trade/ether/0x333A4823466879eeF910A04D473505da62142069

• I don't understand how going from 3 different RPC providers to one is a good move.

  I don't feel good about maintaining these three keys, especially in UI code, I can see all your API keys (someone can send a lot of traffic to these and break things):

  

  If you are looking for fallback providers, i think it is better to use a few other trusted public nodes, and use FallbackProvider instead

Originally posted by @biendeveloper in #107 (comment)

It's not good for vision-impaired people to view some of the content as the background color(them color) is too sharp or not contrast enough. Could you please add an option to add a dark mode maybe?

For example, this page https://nation3.org/join#carousel

Steps to reproduce:

• Open https://app.nation3.org/lock
• Move the slider or change the input manually

Result:

How to reproduce:

1. Go to https://app.nation3.org/lock
2. Connect an Ethereum account that has locked $NATION tokens
3. Click "Sign out"

If you want to reproduce on Goerli, you need to get some test tokens first.

main-acf70204e036151b.js:1 TypeError: Cannot read properties of undefined (reading '0')
    at lock-a83f12e356202410.js:1:6747
    at Object.To [as useMemo] (framework-bb5c596eafb42b22.js:1:64149)
    at t.useMemo (framework-bb5c596eafb42b22.js:1:125294)
    at S (lock-a83f12e356202410.js:1:6686)
    at oo (framework-bb5c596eafb42b22.js:1:59416)
    at Wo (framework-bb5c596eafb42b22.js:1:68983)
    at Ku (framework-bb5c596eafb42b22.js:1:112707)
    at Li (framework-bb5c596eafb42b22.js:1:98957)
    at Ni (framework-bb5c596eafb42b22.js:1:98885)
    at Pi (framework-bb5c596eafb42b22.js:1:98748)

As we start having more apps for citizens, it’s easily for the frontend to become quite a monolith. There are a few ways to not fall into that issue:

• Having each app be completely independent, which means not having a consistent UX and duplicating a lot of code
• The typical app store model embedding an iframe and enabling parent-child communication. Gets out of hand quite quickly in terms of complexity, we don’t need it right now
• Creating a shared library of reusable components that make creating and maintaining a Nation3 app as simple as using a wrapper component, and letting the dev focus on the actual app

I think the last option makes the most sense. I’d propose moving most of the components under a shared library in a repo (which can be nation3/shared). This library can expose two packages: @nation3/components and @nation3/utils.

From a practical perspective, this means:

• Current components directory: All current components can be moved to @nation3/components.

• _app.tsx and _document.tsx can also be exported in @nation3/components.

• Current lib directory: These files could be moved to @nation3/utils

  • connectors.ts
  • approve.ts
  • nation-token.ts
  • network-id.ts
  • numbers.ts
  • passport-nft.js
  • static-call.ts
  • use-*.ts
  • ve-token.ts

Finally, a Nation3App component can implement:

• Network and account handling
• Error handling
• Sidebar
• Nation3 theming

It could be something like this:

  const sidebar = [
    {
      name: 'Start',
      href: '/',
      icon: <ViewGridIcon className="h-5 w-5" />,
    },
    {
      name: 'Become a citizen',
      href: '/join',
      icon: <UserAddIcon className="h-5 w-5" />,
    }
   ]

  return (
    <Nation3App sidebar=sidebar>
      {children}
    </Nation3App>
  )

When the lock is an extension of a pre-existing lock, the final balance estimation fails:

https://app.nation3.org/lock

At https://app.nation3.org/liquidity, the "Available to withdraw" amount under "Unstake" is rounded, causing UX problems when the number gets rounded to a higher number than what is available in the user's account.

When pressing "MAX", the actual number is used:

But when the user copies the number from the input field label and pastes it into the input field, the Ethereum transaction will fail:

Solve this by showing the full amount instead of rounding it to 2 decimals.

Add missing variables to the /join page connected to the Görli testnet: statement and termsURI

Mainnet

Görli

Görli Claim Passport

Add Web3 wallet support to the integration tests so that we can automatically test blockchain interactions for each pull request.

This will greatly reduce future bugs related to a wallet interacting with the Nation3 app.

Before staking the LP tokens, the value shown for Your boosted APY was exactly the same as Rewards APY. After successfully staking, it's about 5% higher. I think that same value should also be shown before staking?

It would also be nice to explain what up to 2.5x more rewards means exactly. What's the formula? How much veNATION do I need to have to get the maximum?

Introduce logging in some of the main functions to make it easier to pin down the location of bugs/errors.

https://app.nation3.org/liquidity

https://app.nation3.org/join

How to reproduce: Obtain at least 2 $veNATION, then press the claim button at http://localhost:42069/join

next-dev.js?3515:32 TypeError: claim is not a function
    at _callee$ (join.tsx?f81f:46:24)
    at tryCatch (runtime.js?ecd4:45:16)
    at Generator.invoke [as _invoke] (runtime.js?ecd4:274:1)
    at prototype.<computed> [as next] (runtime.js?ecd4:97:1)
    at asyncGeneratorStep (join.tsx?f81f:27:53)
    at _next (join.tsx?f81f:27:53)
    at eval (join.tsx?f81f:27:53)
    at new Promise (<anonymous>)
    at Object.eval (join.tsx?f81f:27:53)
    at Object.eval [as onSuccess] (join.tsx?f81f:44:40)
    at N.execute (index.production.js?491d:21:15248)

https://app.dework.xyz/nation3/app-2?taskId=307bc999-e381-4919-b569-f2a7465f3dbd

To make it easier for developers, we need to move public environment variables out of Vercel. Development work involving process.env.* is now is slow and difficult because not all developers have access to Vercel, and therefore cannot easily know the value of each variable or add/edit variables.

More context here: https://discord.com/channels/690584551239581708/963778898389237800/999871593184497765

Remove usage of all process.env.NEXT_PUBLIC_* variables except for NEXT_PUBLIC_CHAIN:

• Refactor https://github.com/nation3/app/blob/main/ui/lib/config.ts
• Delete variables from https://github.com/nation3/app/blob/main/ui/.env.goerli
• Delete variables from https://github.com/nation3/app/blob/main/ui/.env.mainnet

Admin Tasks

After the PR for this issue has been merged into main:

• In Vercel, remove all NEXT_PUBLIC_* variables except for NEXT_PUBLIC_CHAIN

It make me and other people buy Nation 2 times to get 2 veNations

A couple users reported to me the same UX problem.

When trying to withdraw & claim on https://app.nation3.org/liquidity they got confused by the fact that you can select an amount of tokens to withdraw but if you click ¨withdraw all and claim¨ you are actually withdrawing all your staked tokens.

As the contract doesn't implement an option to withdraw a set amount and claim on the same transaction i think the best fix would be to add a tooltip in this button that clarifies that you are about to withdraw ALL your tokens.

First reported in Discord: https://discord.com/channels/690584551239581708/963777388712460288/968696161416400916

I tried to lock 2 $NATION for 4 years three times but it shows the error and the transaction failed.

This is the transaction hash: https://etherscan.io/tx/0x9ce585e255a2afe5d9a006c33c5c3ed5b8e9089a9e6185fb700221cc351f4fce

transaction failed [ See: https://links.ethers.org/v5-errors-CALL_EXCEPTION ] (transactionHash="0x9ce585e255a2afe5d9a006c33c5c3ed5b8e9089a9e6185fb700221cc351f4fce", transaction=

{
	"hash": "0x9ce585e255a2afe5d9a006c33c5c3ed5b8e9089a9e6185fb700221cc351f4fce",
	"type": 2,
	"accessList": null,
	"blockHash": null,
	"blockNumber": null,
	"transactionIndex": null,
	"confirmations": 0,
	"from": "0x568b9bFfF4a3a7C7351db84EC2F4Ad4CA147A1D0",
	"gasPrice": {
		"type": "BigNumber",
		"hex": "0x0b356e6a69"
	},
	"maxPriorityFeePerGas": {
		"type": "BigNumber",
		"hex": "0x59682f00"
	},
	"maxFeePerGas": {
		"type": "BigNumber",
		"hex": "0x0b356e6a69"
	},
	"gasLimit": {
		"type": "BigNumber",
		"hex": "0x06b1f4"
	},
	"to": "0xF7deF1D2FBDA6B74beE7452fdf7894Da9201065d",
	"value": {
		"type": "BigNumber",
		"hex": "0x00"
	},
	"nonce": 42,
	"data": "0x65fc38730000000000000000000000000000000000000000000000001bc16d674ec800000000000000000000000000000000000000000000000000000000000069e56c80",
	"r": "0xb4d1d9bdf85e15567998f70133017a9abf24c251163306fd1f4f042185e1ccd5",
	"s": "0x0efde33ece255b3ff19b276755eaf2daa2b23294ad24152100ee93b8a3df5841",
	"v": 1,
	"creates": null,
	"chainId": 0
}, receipt = {
	"to": "0xF7deF1D2FBDA6B74beE7452fdf7894Da9201065d",
	"from": "0x568b9bFfF4a3a7C7351db84EC2F4Ad4CA147A1D0",
	"contractAddress": null,
	"transactionIndex": 225,
	"gasUsed": {
		"type": "BigNumber",
		"hex": "0x06b1f4"
	},
	"logsBloom": "0x00000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000",
	"blockHash": "0xb251a8ee4062576a65cce73ba94c385f565008e03ebb9f4b3b09e68bb257375d",
	"transactionHash": "0x9ce585e255a2afe5d9a006c33c5c3ed5b8e9089a9e6185fb700221cc351f4fce",
	"logs": [],
	"blockNumber": 14625765,
	"confirmations": 2,
	"cumulativeGasUsed": {
		"type": "BigNumber",
		"hex": "0x013a2c4e"
	},
	"effectiveGasPrice": {
		"type": "BigNumber",
		"hex": "0x0b27d195ff"
	},
	"status": 0,
	"type": 2,
	"byzantium": true
}

, code=CALL_EXCEPTION, version=providers/5.6.0)

How to reproduce:

1. Go to https://app.nation3.org/liquidity
2. Connect an Ethereum account (press "Sign in") using the Ethereum mainnet
3. Open the JavaScript Console

inpage.js:1 MetaMask - RPC Error: execution reverted {code: -32603, message: 'execution reverted', data: {…}}

The error seems to occur only when the Ethereum account holds zero $veNATION.

Refactor the code so that no error is thrown in the console.

Remove signer account settings from https://app.nation3.org/citizen to avoid confusion during Snapshot voting.

          @pythonpete32 We don't know yet if this typo is in the code or in the Vercel admin dashboard.  But we'll double-check that once we get admin access to Vercel.

Originally posted by @aahna-ashina in #168 (comment)

At https://app.nation3.org/liquidity, I can see this text:

You can boost your APY to 124.16%. To do so, claim your current rewards.

But how can a reward of 0.0028 boost the APY from 66.61% to 124.15%?

Is there a bug with the way the potentialBoost variable is calculated?

https://github.com/nation3/app/blob/8213be5114dcce3e629a86c6bd07c8839d0d9d40/ui/pages/liquidity.js#L169

To test the code changes of each pull request, start a server on localhost:3000 before running the tests. This way, we can catch UI errors sooner.

Docs: https://nextjs.org/docs/testing#running-your-cypress-tests

Suggested by @Caranell at #86 (comment)

Revamp the config system to use the *.json manifest files found in contracts/deployments by default and use only the ENV variable to override.

Originally posted by @xPi2 in #18 (comment)

https://app.dework.xyz/nation3/citizen-app-p?taskId=adeac3e1-0944-4662-8ea4-1a53a8348c3b

https://app.dework.xyz/nation3/develop-1?taskId=fb60f323-7335-4354-9151-8363cd1d30aa

https://app.dework.xyz/nation3/develop-1?taskId=f63f80f7-0d17-4dc4-aad0-62acd1951eb1

https://archive.jestjs.io/docs/en/24.x/configuration#coveragethreshold-object

zhongbuzhong.eth

After staking some LP tokens, the page refreshed to show this error:
Application error: a client-side exception has occurred (see the browser console for more information).

The console showed this:

inpage.js:1 MetaMask - RPC Error: execution reverted Object
(anonymous) @ inpage.js:1
framework-5f4595e5518b5600.js:1 Error: invalid decimal value (argument="value", value="Infinity", code=INVALID_ARGUMENT, version=bignumber/5.7.0)
    at d.makeError (_app-829a704c68928b4b.js:1:170377)
    at d.throwError (_app-829a704c68928b4b.js:1:170497)
    at d.throwArgumentError (_app-829a704c68928b4b.js:1:170552)
    at m (_app-829a704c68928b4b.js:1:50776)
    at Module.u (_app-829a704c68928b4b.js:1:369179)
    at p (582-eb8d93187353437a.js:1:5354)
    at liquidity-eef06e9b6bca3c51.js:1:29401
    at Ui (framework-5f4595e5518b5600.js:1:104662)
    at t.unstable_runWithPriority (framework-5f4595e5518b5600.js:1:129336)
    at Ql (framework-5f4595e5518b5600.js:1:44981)

After refreshing the page it looks like everything was successful: the staked LP show up under Unstake as expected ('Available to withdraw').

How to reproduce:

1. Go to https://app.nation3.org/
2. Switch to a network that is not mainnet

An error is thrown at /lock:

next-dev.js?3515:32 Warning: A component is changing an uncontrolled input to be controlled. This is likely caused by the value changing from undefined to a defined value, which should not happen. Decide between using a controlled or uncontrolled input element for the lifetime of the component. More info: https://reactjs.org/link/controlled-components
    at input
    at EthersInput (webpack-internal:///./components/EthersInput.tsx:69:27)
    at div
    at div
    at div
    at div
    at div
    at div
    at div
    at MainCard (webpack-internal:///./components/MainCard.tsx:12:26)

How to reproduce:

cp .env.goerli .env.local
yarn dev

Go to http://localhost:42069/lock and type a number into the "Lock amount" field.

Fix unhandled runtime error introduced in #147

Application error when typing more than 18 decimals as stake amount at https://app.nation3.org/liquidity

Error: fractional component exceeds decimals [ See: https://links.ethers.org/v5-errors-NUMERIC_FAULT ] (fault="underflow", operation="parseFixed", code=NUMERIC_FAULT, version=bignumber/5.6.1)
    at d.makeError (_app-6c618fae021f384d.js:1:107374)
    at d.throwError (_app-6c618fae021f384d.js:1:107494)
    at h (_app-6c618fae021f384d.js:1:49985)
    at m (_app-6c618fae021f384d.js:1:50990)
    at Module.u (_app-6c618fae021f384d.js:1:261202)
    at u (57-1a3a605a543a96c8.js:1:5929)
    at R (liquidity-5b716c9f1c561dc5.js:1:26463)
    at oo (framework-5f4595e5518b5600.js:1:59412)
    at Wo (framework-5f4595e5518b5600.js:1:68979)
    at Ku (framework-5f4595e5518b5600.js:1:112703)