natecox / corrator Goto Github PK

Several errors currently fail less than gracefully, will add instances as I find them

• endoflife.date fails to connect or parse
• docker isn't currently accessible (need to start the server/app/whatever)

Maybe the flag could be --output and pass in a file name

Currently corrator uses a single config file, which is fine for small projects. However, it can get a bit unwieldy when dozens of containers need to be configured with dozens of apps.

It may be better to split app and container configs into their own config files. This would also open the door to:

• cleaner validation of containers on initialization
• removing the need for a transitional struct for parsing the file (container/app definition)
• replacing a hash lookup for apps with a simple pointer

Currently Containers store a vector of strings representing the apps to check, requiring a lookup for each one.

Consider refactoring to instead store a pointer to an Application instead so it can be used directly.

This will currently require an upfront pass through each container to convert from strings (from the config file) to pointers after the app configs have been parsed.

Group containers together in-config and run them by name.

[containers.ubuntu]
config = "here"

[containers."app name here"]
config = "here"

[containers.etc]
config = "here"

[groups.my-project-name]
containers = [ "ubuntu", "app name here", "etc" ]

corrator --group my-project-name

I was made aware while writing the release CI pipeline that the xdg crate does not support windows and has it as a wont fix.

Replace it with https://crates.io/crates/directories so we are more cross platform.

Currently the main processing of the container query happens in a thread::scope which has worked well enough. However, it may be worthwhile to convert that scope to use rayon's par_iter() instead, which would probably be a cleaner looking.