nasa-pds / feedback-widget Goto Github PK

🐛 Describe the bug

Feedback not being submitted

📜 To Reproduce

Steps to reproduce the behavior:

1. go to pds.nasa.gov or pds-gamma.jpl.nasa.gov
2. try to submit feedback
3. do not receive email at [email protected]

🕵️ Expected behavior

Expect to see email

From user:

There is a small bug in the feedback widget. feedback.css line
634 sets the default font size to 16, but it does it for the
".feedbackTab p" element. The config.js file overrides the parent
".feedbackTab" style, but the "p" element still gets its size from
feedback.css. The end result is it's not possible to change the font
size using config.js.

We would like to discuss the possibility of having alternate ways of triggering the feedback widget that don't involve the floating button that resides on the right side of the browser. Reason being that some of us feel that the button is distracting and would rather like to have the widget triggered by say a "Contact Us" link somewhere on the site like the footer perhaps.

Would this be acceptable and if so, would it require any changes to the widgets implementation?

🐛 Describe the bug

Same issue as #18
I am still seeing the error message, but the feedback was submitted to the system.

🕵️ Expected behavior

user should see the "Thank you" message instead.

🐛 Related Test cases

#18

📜 To Reproduce

...

🖥 Environment Info

• Operating System: [e.g. MacOSX with Docker Desktop vX.Y]
  ...

📚 Version of Software Used

No response

🩺 Test Data / Additional context

No response

🦄 Related requirements

🦄 #xyz

⚙️ Engineering Details

No response

• TBD to be updated by @c-suh

The README looks pretty good, but there are a couple of issues in the "Configured Variables" table:

• Footnote (5) tells users to enter integer values only, not units like "px" or "vw". But every single corresponding "default" value has explicit units shown, and there is no indication of what units will be applied to the naked integer.

  What you have now is likely to lead to needless confusion and frustration. If the user cannot select units, then the default values in this table shouldn't show them, and the description should name the (de facto required) unit explicitly. But if the user cannot select units, then there shouldn't be any units in the config.js file, either - you're basically instructing users to remove the units that are already in there! If what you mean is "Do not change the units that are in config.js", then say that - but expect users to change them anyway.

• The "placement -offset" line shows a value range of "[0,95)" [sic]. The use of an opening bracket with a closing parenthesis looks like a typo; if it isn't one it needs to be explained.

• The set of values itself is also somewhat mysterious. I don't see why "0" would be an allowed value on one extreme, but "100" is not allowed on the other. It's also not immediately clear to me why the unit is "vh" regardless of whether the widget is placed top/bottom or left/right. Perhaps it is clear to CSS programmers?

• This table does not follow the order or the syntax in the config.js file, and it's not sorted in alphabetical order, either. If the table were any longer it would be kind of annoying to have to scroll back and forth looking for things. Still, one order or the other should be applied.

• The structure of the "followUpLinks" section is more complex than what is in the table.That's not a major issue for people who know JSON, but that does not necessarily describe people who would be tasked with implementing this widget.

  On the whole, I'd re-order the table to match config.js, and I would expand the content of the "followUpLinks" line the same way as has been done for "size" and "placement". Then I'd expand the description to include a) what in the JSON structure can be changed ("url" only? "title"?); and b) to remove the implication that anything in there should be a multivalued list of URLs - unless that is actually valid.

🐛 Describe the bug

TextArea submission is being cut off.

📜 To Reproduce

Steps to reproduce the behavior:

1. Go to pds.nasa.gov
2. Click on 'Need Help?' to open Feedback widget
3. Enter comment and Submit
4. Follow up with pds_operator to see what was received

🕵️ Expected behavior

Comment is cut off if a special character is used.

📚 Version of Software Used

v1.2.1

🩺 Test Data / Additional context

Special characters are the suspected culprit (not yet verified) because there is no maxLength set on the form element. This issue was brought to our attention when a user submitted feedback on an RMS site (email thread with subj: 'Feedback from pds-rings.seti.org')

🏞Screenshots

🖥 System Info

• OS: [e.g. iOS]
• Browser [e.g. chrome, safari]
• Version [e.g. 22]

🦄 Related requirements

⚙️ Engineering Details

🐛 Describe the bug

On submitting something to the Feedback widget, a message will come up that "There was an error sending your feedback." Opening dev tools shows a CORS error. However, the submission goes through. This has been tested from the ATM site, two SBN PSI sites (https://arcnav.psi.edu/ and https://sbn.psi.edu/pds/) and the PDS gamma site.

Notes:

• brought to our attention by Mike Drum
• this didn't seem to be a problem in March (#17 (comment)), unless it was a problem at that time and unnoticed until now

📜 To Reproduce

Steps to reproduce the behavior:

1. Go to pds.nasa.gov
2. Click on "Need Help?" to open the Feedback modal
3. Fill in with your information, indicate it's for testing, and submit
4. See error

🕵️ Expected behavior

Either the submission should not go through, or the feedback widget should give the "Thank you for making PDS a better site" message.

📚 Version of Software Used

v1.3.0, at least on gamma

🩺 Test Data / Additional context

🏞Screenshots

🖥 System Info

• OS: [e.g. iOS]
• Browser [e.g. chrome, safari]
• Version [e.g. 22]

🦄 Related requirements

⚙️ Engineering Details

🐛 Describe the bug

For SBN-UMD, a submission gives the message "Are you a bot? Suspicious behavior detected."
For SBN-PSI, a submission gives the message "Status: error; Error: Not Found"

📜 To Reproduce

Steps to reproduce the behavior:

1. Go to
   • https://pds-smallbodies.astro.umd.edu/
   • https://pdssbn.astro.umd.edu/
   • https://sbn.psi.edu/pds/
   • https://arcnav.psi.edu/
2. Open the Feedback form by clicking the blue tab on the right side of the screen which says "Need Help?"
3. Fill in some comment and click the button to "Send Feedback"
4. See message

🕵️ Expected behavior

The message should be something like, "Thank you for making the PDS a better site. If you provided an email address, a PDS representative will get back to you as soon as possible."

📚 Version of Software Used

?

🩺 Test Data / Additional context

SBN-UMD had updates to their servers, after which the widget stopped working. I do not know if this applies to SBN-PSI as well.

🦄 Related requirements

⚙️ Engineering Details

I followed the directions but could not get the widget to show for either:

• http://sharks.jplsoftball.org/killme1.shtml is https://pds.nasa.gov/datasearch/subscription-service/SS-20191030.shtml moved directly to the other web site.
• http://sharks.jplsoftball.org/killme2.shtml is a stripped down version that copies the code from github into its <head>.

Maybe the web server is missing something, but, if so, the directions should say what the requirements are.

🐛 Describe the bug

[email protected] was spammed by [email protected] at 120+ spam emails per minute.

📜 To Reproduce

Steps to reproduce the behavior:

1. Go to '...'
2. Click on '....'
3. Scroll down to '....'
4. See error

🕵️ Expected behavior

📚 Version of Software Used

🩺 Test Data / Additional context

🏞Screenshots

🖥 System Info

• OS: [e.g. iOS]
• Browser [e.g. chrome, safari]
• Version [e.g. 22]

🦄 Related requirements

⚙️ Engineering Details

Checked for duplicates

No - I haven't checked

🐛 Describe the bug

When I used the feedback widget on ATM website, the pop raises an error asking if I am sure if I am not a bot.

🕵️ Expected behavior

I expected the feedback widget to recognize I am not a bot.

📜 To Reproduce

Go on ATM web site https://pds-atmospheres.nmsu.edu/ and use the feedback widget deployed there.

🖥 Environment Info

No response

📚 Version of Software Used

No response

🩺 Test Data / Additional context

No response

🦄 Related requirements

🦄 #xyz

⚙️ Engineering Details

There is no error in the developer tool's console or the network tab.