nasa-pds / api-search-query-lexer Goto Github PK

Describe the bug
Given the simple URL from pds-api 54 /products?q="lid eq *text*" and expectation (acceptance criteria), the registry-api-service when nuts and blew up with out of memory. Tracked it down to this module. Turns out there is a simple infinite loop in ANTLR 4.9.2 and earlier that is most likely a fault of the language or how it is being parsed because the ANTL FAQ suggests that not terminating the stream is the biggest problem and the infinite loop is caused by never finding the end of the stream even though all data has been read.

To Reproduce
Run/Debug in Eclipse api.pds.nasa.gov.api_search_query_lexer.TestParsing.

Expected behavior
TestParsing should run to completion and successfully parse the lid eq *text* string without running out of memory.

Version of Software Used
ANTLR 4.3, 4.7, 4.9.

🐛 Describe the bug

The search string a eq b does not parse while a eq "b" does. The expectation is that both parse to the same result.

📜 To Reproduce

See TestParsing.isParsable() a unit test for this module.

🕵️ Expected behavior

Should pass,

** 🦄 Applicable requirements**