naoina / denco Goto Github PK

View Code? Open in Web Editor NEW

223.0 223.0 24.0 43 KB

The fast and flexible HTTP request router for Go

License: MIT License

Go 100.00%

denco's People

Contributors

Stargazers

Watchers

denco's Issues

Wildcard backtracking

The following test code fails:

    records = []denco.Record{
        {"/*wildcard", "testroute0"},
        {"/a/:b/c", "testroute1"},
    }
    testcases = []testcase{
        {"/a/b", "testroute0", []denco.Param{{"wildcard", "a/b"}}, true},
        {"/a/b/foo", "testroute0", []denco.Param{{"wildcard", "a/b/foo"}}, true},
        {"/a/b/c", "testroute1", []denco.Param{{"b", "b"}}, true},
        {"/a", "testroute0", []denco.Param{{"wildcard", "a"}}, true},
    }
    runLookupTest(t, records, testcases)

Router.Lookup("/a") => (<nil>, denco.Params(nil), false), want ("testroute0",denco.Params{denco.Param{Name:"wildcard", Value:"a"}}, true)

I would expect the /a lookup to return the /*wildcard route. Instead it fails to return anything. Shouldn't the /a/:b/c pattern backtrack all the way to the root?

Why there is no ANY handler

You are provided handler for POST PUT HEAD methods, Why there is no handler registration enabled without method type?

For example

Any request on /proxy/*path should need to be handled by a handler.. How can I use this library ?? Am I missing something ??

do something everytime, no matter what?

This might sound like a dumb question.

With Denco, is it possible to run a function everytime it hit any route?

So if I had something like:

mux := denco.NewMux()
handler, err := mux.Build([]denco.Handler{
mux.GET("/", handleRoot),
mux.GET("/foo", handleFoo),
mux.POST("/bar", handleBar),
})
if err != nil {
panic(err)
}
GetSession()
log.Fatal(http.ListenAndServeTLS(":443","crt", "key", handler))

How would I run GetSession() every time, no matter what route gets triggered?

Thanks!

Route parsing issue

Hi @naoina,

Thanks for making denco available, we have been using denco intensively for our critical application in production, and it does the job very well.

Recently, we found inconsistent parsing for multiple dynamic segments path. Here's the gist:

package main

import (
	"fmt"

	"github.com/naoina/denco"
)

type route struct {
	name string
}

func main() {
	router := denco.New()
	router.Build([]denco.Record{
		{"/stock-adjustments/lines", &route{"adjust-xx"}},
		{"/stock-adjustments/lines/upload", &route{"adjust-up"}},
		{"/stock-adjustments/lines/:id", &route{"adjust-id"}},

		{"/stock-adjustments/:stock-adjustment-id/lines", &route{"lines-xx"}},
		{"/stock-adjustments/:stock-adjustment-id/lines/upload", &route{"lines-up"}},
		{"/stock-adjustments/:stock-adjustment-id/lines/:id", &route{"lines-id"}},
	})

	data, params, found := router.Lookup("/stock-adjustments/123/lines")
	fmt.Printf("%#v, %#v, %#v\n", data, params, found)

	data, params, found = router.Lookup("/stock-adjustments/123/lines/456")
	fmt.Printf("%#v, %#v, %#v\n", data, params, found)

	data, params, found = router.Lookup("/stock-adjustments/123/lines/upload")
	fmt.Printf("%#v, %#v, %#v\n", data, params, found)

	data, params, found = router.Lookup("/stock-adjustments/lines")
	fmt.Printf("%#v, %#v, %#v\n", data, params, found)

	data, params, found = router.Lookup("/stock-adjustments/lines/456")
	fmt.Printf("%#v, %#v, %#v\n", data, params, found)

	data, params, found = router.Lookup("/stock-adjustments/lines/upload")
	fmt.Printf("%#v, %#v, %#v\n", data, params, found)
}

// OUTPUT
//
// &main.route{name:"lines-xx"}, denco.Params{denco.Param{Name:"stock-adjustment-id", Value:"123"}}, true
// &main.route{name:"lines-id"}, denco.Params{denco.Param{Name:"stock-adjustment-id", Value:"123"}, denco.Param{Name:"id", Value:"456"}}, true
// &main.route{name:"lines-id"}, denco.Params{denco.Param{Name:"stock-adjustment-id", Value:"123"}, denco.Param{Name:"id", Value:"upload"}}, true
// &main.route{name:"adjust-xx"}, denco.Params(nil), true
// &main.route{name:"adjust-id"}, denco.Params{denco.Param{Name:"id", Value:"456"}}, true
// &main.route{name:"adjust-up"}, denco.Params(nil), true

Any idea?

Add more testcases

Recommend Projects

React

A declarative, efficient, and flexible JavaScript library for building user interfaces.
Vue.js

🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
Typescript

TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
TensorFlow

An Open Source Machine Learning Framework for Everyone
Django

The Web framework for perfectionists with deadlines.
Laravel

A PHP framework for web artisans
D3

Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

javascript

JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
web

Some thing interesting about web. New door for the world.
server

A server is a program made to process requests and deliver data to clients.
Machine learning

Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
Visualization

Some thing interesting about visualization, use data art
Game

Some thing interesting about game, make everyone happy.

Recommend Org

Facebook

We are working to build community through open source technology. NB: members must have two-factor auth.
Microsoft

Open source projects and samples from Microsoft.
Google

Google ❤️ Open Source for everyone.
Alibaba

Alibaba Open Source for everyone
D3

Data-Driven Documents codes.
Tencent

China tencent open source team.