nakijun / ddab-lib Goto Github PK

I've found an error in your function GetAllEnvVars:
line:
  Windows.FreeEnvironmentStrings(PEnvEntry);
should be:
  Windows.FreeEnvironmentStrings(PEnvVars);
Dejan

In order to compile the unit PJSysInfo Delphi 5, the conditional define:

{$IFDEF VER130} // Delphi 5
  {$UNDEF EXCLUDETRAILING}
{$ENDIF}

must be added as D5 supports ExcludeTrailingBackSlahs but NOT
ExcludeTrailingPathDelimiter, which is used in the code.

Rich Habedank

There is a syntax error compiling PJWdwState.pas with Delphi XE2 and later.

Some API routines that are qualified with unit do not compile on XE2 and later 
since full namespace name would be required.

In your GetEnvVarValue and ExpandEnvVars, the length of Result is set 
inconsistently. GetEnvVarValue sets it to BufSize - 1 while ExpandEnvVars sets 
it to BufSize, which adds null (#$0) at the end.
Shouldn't it also do SetLength(Result, BufSize - 1)?

Thanks
e.e

Which of the various library projects caused the bug you are reporting?

TPJCBViewer

What steps will reproduce the problem?

It was discovered at De Novo Software, while debugging our flagship program, 
that attempting to copy data to the clipboard while the program is frozen under 
the debugger can cause the program copying data to the clipboard to become 
unresponsive until execution.  If the program in question is the Delphi IDE, 
this can make it impossible to continue debugging.

I traced the issue back to our program's use of TPJCBViewer and its use of the 
obsolete clipboard chain APIs.

What is the expected output? What do you see instead?

Expected: One process failing to handle messages should not interfere with the 
workings of another process.
Observed: When the clipboard chain API is invoked on a frozen application, it 
can cause the calling program to hang.

What version of the product are you using? On what operating system?

 * $Rev: 666 $
 * $Date: 2010-10-13 03:24:43 +0100 (Wed, 13 Oct 2010) $
Windows 7.

Please provide any additional information below.

Since Windows Vista, a better API for clipboard monitoring has been available 
that does not rely on inter-process chaining: AddClipboardFormatListener.  
Since versions of Windows earlier than Vista are no longer supported, either by 
Microsoft or by Delphi, there is no good reason not to update.

I've attached a patch file that fixes this unit.  It's a patch against the 
revision mentioned above, which is not the latest revision, but the latest 
revision still has the same problems.

What feature would you like to be added?

Add a property to provide access to a TPJResourceEntry instance's data as
an array of bytes (TBytes?). May need to conditionally compiled to only
work on Delphis with TBytes.

What feature would you like to be added?

Enumerator for TPJResource to enable use of for ... in construct to
enumerate all entries in resource file.

Add in such a way not to break Delphis that don't support for ... in.

The GetAllEnvVars topic in the help file refers to the function returning
the size of the environment block in bytes, when in fact the size is in
characters.

Error occurs in (at least) v1.3 and v1.3.1.

Make PJSysInfo project return info about whether user has admin privelges.

Request by Steffan Schaff.

v3.4 of the About Box component can freeze the Delphi 2010 IDE.
Steps to reproduce:
1) Install the About Box Component.
2) Start a new Delphi 2010 VCL application.
3) Drop an About Box component on the form.
4) Save and run the application.
5) Attempt to close the Delphi IDE - it freezes.

Project-wdwstate

Love the component. Would it be possible to remember 'docked' status of the 
form though? Currently when you drag the window to the far left of the screen 
etc and then exit, the docked status is not remembered on restore.

Window size and word wrap setting are supposed to be persistent but this is not 
the case.

...

If the program runs on a 64bit-machine, the "function GetRegistryString(const 
RootKey: HKEY; const SubKey, Name: string): string;" doesn't work correctly. It 
returns on a Windows 7, 64bit an empty string!

What I found out is:
If you change the "Reg := TRegistry.Create;" in line 1116 to "Reg := 
TRegistry.Create(KEY_READ or KEY_WOW64_64KEY);" (KEY_WOW64_64KEY = $0100) and 
use in "function RegOpenKeyReadOnly(const Reg: TRegistry; const Key: string): 
Boolean;" the "Result := Reg.OpenKey(Key, False);" (line 1096), it works!

Maybe you could fix that!?

Thanks a lot, you did a nice job!
Steffen Schaff

Request by Steffan Schaff.

Which of the various library projects caused the bug you are reporting?
Please specify one of the Project-xxxx keywords below

What steps will reproduce the problem?
1. Unzip the download, this creates the demos directory
2. Open the Demos/PJConsoleAppDemos.bpg project group in Delphi 7
3. Select any project and try to compile or build, result is ERROR
4. Open project properties/Directories and add ..\..\ to search path
5. Try to build again. SUCCESS

What is the expected output? What do you see instead?
I expected the projects to build, but instead Delphi7 showed a file not found 
error

What version of the product are you using? On what operating system?
I downloaded from the site:
http://www.delphidabbler.com/software/consoleapp/download
today (2013-03-20)
And I am operating on Windows 7 Pro X64 SP1 (but that does not matter for this 
issue)

If you have implemented a fix, please attached the fixed source code as a
single, compressed, file. .zip and .gz file formats are accepted.

Attached a zip containing all of the dof files that now contain the search path 
as ..\..\

Please provide any additional information below.

Bug described in this email from Peter Aschbacher

Hi! When the Windows Task Bar is on the LEFT SIDE of the Windows desktop and 
woFitWorkArea is set to True, then restoring the LEFT position always adds the 
Task Bar width to the restored LEFT position of the window!

PJWdwState $Date: 2011-06-18
Windows 7 x64 SP1

Version numbers in TPJVersionInfo are represented by the TPJVersionNumber 
record. It would be useful if these numbers could be formatted as strings. 
In Delphi 2006 or later this can be by operator overloading.

TPJEnvVars current has an EnumNames function that calls a callback procedure, 
but it would be better and more useful on later Delphis to provide a standard 
enumerator to allow use of the for .. in construct to enumerate environment 
variable names.

A method to provide the product key would be useful.

Requested by Steffan Schaff who provided this link to sample code:

http://tinyurl.com/3egdbhw

Hi,

please add an "OnAfterWindowSizing" event to TPJWdwState. This would be very 
helpful when having to do any actions after the window has been sized by 
PJWdwState. Thank you.

Kind regards,
Peter Aschbacher

When running on Windows 98 the IsServer and IsWindowsServer methods of 
TPJOSInfo return True.

Since Windows 9x is never a server, this is wrong.

Based on diagnostic info provided by Rch Habedank

Which of the various library projects caused the bug you are reporting?
Please specify one of the Project-xxxx keywords below
I used the Wiki Example 8 found here:
http://wiki.delphidabbler.com/index.php/Docs/ConsoleAppExample8

What steps will reproduce the problem?
1. Create a program using wiki example 8 as template
2. Use a command line for the Timed test application with 5s running time 
(<path to>\Timed 5)
3. Click the button and observe nothing at all in Memo1 until Timed terminates.
4. Then see everything Timed has output all at once

What is the expected output? What do you see instead?
I expected to see the greeting message from Timed to appear immediately.
Then on the next line a sequence of dots showing the execution progress and 
finally the ending message.

What I see instead: Nothing at all until 5s has passed when all of the above 
suddenly and instantly appears.

What version of the product are you using? On what operating system?
Downloaded today 2013-03-20. Operating system Windows 7 Pro X64 SP1

If you have implemented a fix, please attached the fixed source code as a
single, compressed, file. .zip and .gz file formats are accepted.

No fix available, just confused.
But it seems like App.Execute(Command) never returns until the execution has 
actually terminated! Therefore no other events will be processed inside the 
application because the console was launched from within a TButton OnClick 
event that never ends and so blocks other events from happening.

Please provide any additional information below.
Need an example where the App.Execute will NOT wait for termination but instead 
return with a code that tells us that it successfully started....

It would be useful if the could be an option added to TPJWdwState that lets any 
relative path specified for an ini file be written to certain pre-defined 
directories by default.

Current default is Windows directory if a file name is specified without a 
path, or program directory if no name specified. Neither of these are ideal.

Options could be:

* Classic (or Default) - original behaviour
* Program directory (not recommended)
* Per user app data directory
* All users app data directory

Should also have facility to create any necessary sub-directories in relative 
path.

Requested by Steffen Schaff.

Get TPJOSInfo to provide name of company Windows is registered to.

I am using Delphi XE3 and Server 2012 R2. After I upgraded to System 
Information Unit 5.0.0. i get a Range Check Error in procedure NewGetVersion, 
line 1248 while TestWindowsVersion(Major, Minor, SPMajor, SPMinor, VER_GREATER) 
do

The program Halt, and I am not able to run my Application.

Is this something which can be fixed?

If you want some more information, I can send it to you by email.

john myren

Requested by Bill Miller

[Email Snip]
....
I tried TPJVCLMsgDlg and liked it a lot. The only thing that bothers
me a bit is that there is no overloaded function that allows you to use
it with windows MessageBox uType (UINT that contains the buttons and
icons together).
[/Email Snip]

Eran Toktin

If a buffer size of 0 is returned from ExpandEnvironmentStrings we may edn
up calling the same API with an empty buffer. Could (but may not be risky).
Better to check for 0 buffer size and return '' from ExpandEnvVars.

Note: similar code in http://www.delphidabbler.com/articles?article=6 does
this.

The about box component always appears at the top left of the screen, 
regardless of the Position and related property values if 
Application.MainFormOnTaskBar := True; and / or Application.ModalPopupMode := 
pmAuto; (don't know which causes the error.

Setting UseOwnerAsParent to true makes no difference.

When these statements are removed, the about box positions itself correctly.

Beginning with v5.0.0 of PJSysInfo, any software compiled with this unit will 
AV at program start-up with a message that "assertion failed". Simply creating 
a new project with nothing but the main form (no controls) & PJSysInfo in uses 
clause will AV on Windows 98, for instance. Adding EurekaLog (for debugging) 
shows the error at line 1178 of TestWindowsVersion method:

Assert(Assigned(VerSetConditionMask) and Assigned(VerifyVersionInfo));

Your overview indicates this unit will work W95 & up. Any idea what's going 
wrong and is there anything I can do to assist in finding the problem?

Notified by Rich Habedank

Hello!

In PJSysInfo library 

* $Rev: 1256 $
 * $Date: 2013-01-20 02:15:05 +0000 (Sun, 20 Jan 2013) $

you have a bug - misspell for retrieving value of registered organization. Code 
returns empty string because you are looking in registry for value 
"RegisteredOrganiSation" instead of correct string "RegisteredOrganiZation". 
This is what I have so far. Can you please fix it for other users so they won't 
have problems.

Kind regards,
Matjaz

What feature would you like to be added?

Enumerator for TPJResource to enable use of for ... in construct to
enumerate all entries in resource file.

Add in such a way not to break Delphis that don't support for ... in.

I am trying to create a new package to use in a Delphi 5 program.  When I try 
to build the package, I get the following errors:

[Error] PJWdwState.pas(1509): Undeclared identifier: 'PathDelim'
[Error] PJWdwState.pas(1631): Undeclared identifier: 
'IncludeTrailingPathDelimiter'
[Error] PJWdwState.pas(1690): Undeclared identifier: 'ForceDirectories'
[Fatal Error] WindowState.dpk(33): Could not compile used unit 'PJWdwState.pas'

Notified by Joe Gross