nak2 / stormfox2

StormFox2

StormFox 2 is the successor to StormFox applying weather, light and effects to the map. SF2 is created with a focus on asynchronization, letting clients handle the effects.

How to install

You can find it on Steam Workshop here.

You can also install from this repository via this link here.

License

This project is licensed under the GNU General Public License v3.0

Bugs and errors

Please report any bugs via the issue tracker.

Changelogs can be found on the Steam Workshop Page here.

Content pack

Don't reupload SF2 content on the workshop, instead use this.

stormfox2's Issues

light_environment

Why not re-create light_environment if it's not on the map? I tried it and it worked fine.

StormFox2.Ent.light_environments = GetOrCreate( "light_environment")

improved rain and rain plus plus add rain mm add Foliage Dynamic Random add hail add hail cm

add more abundant improvements to the rain and foliage change the normal foliage to a random dynamic foliage i realistic i and add the amount of rain mm also add hail storm also add the size of the hail cm thanks regards

Bug: filter to darken maps still comes up when SF is disabled

Even though i have SF disabled, the darkness filter will still come on every once and awhile.
In the server options, I have SF disabled
In client options, under effects I have "Extra Darkness" disabled
this is what the server options show

I can temporarily get the brightness back to normal by enabling and disabling SF in the server options, which puts this in console:

Time is always the same on every map.

I remember before some updates, time was random on every map, but now on every map, time is 3:45.
In sf2 settings default time is -1, and no errors in the console.
I reinstalled gmod and addon few times, but the issue still persists.

[Crash] It crashes the game when cleanup the map

/proc/1/fd/4(+0x2f4e9)[0xf794d4e9]
linux-gate.so.1(__kernel_rt_sigreturn+0x0)[0xf7ef7570]
/home/container/garrysmod/bin/server_srv.so(+0xd8c9a8)[0xf24f79a8]
/home/container/garrysmod/bin/server_srv.so(+0xd8cd02)[0xf24f7d02]
/home/container/garrysmod/bin/server_srv.so(+0xd8cdf8)[0xf24f7df8]
/home/container/garrysmod/bin/server_srv.so(+0xdfd548)[0xf2568548]
/home/container/garrysmod/bin/server_srv.so(+0xdfd748)[0xf2568748]
/home/container/garrysmod/bin/server_srv.so(+0xdfe257)[0xf2569257]
/home/container/garrysmod/bin/server_srv.so(+0xe994c7)[0xf26044c7]
/home/container/garrysmod/bin/server_srv.so(+0xce445e)[0xf244f45e]
/home/container/garrysmod/bin/server_srv.so(+0xce55bb)[0xf24505bb]
/home/container/garrysmod/bin/server_srv.so(+0x59cf6f)[0xf1d07f6f]
/home/container/garrysmod/bin/server_srv.so(+0x6ce318)[0xf1e39318]
/home/container/garrysmod/bin/lua_shared_srv.so(+0x5c9b9)[0xedb499b9]
/home/container/garrysmod/bin/lua_shared_srv.so(lua_pcall+0x48)[0xedb3ce38]
/home/container/garrysmod/bin/lua_shared_srv.so(+0x197dc)[0xedb067dc]
/home/container/garrysmod/bin/lua_shared_srv.so(+0x230c6)[0xedb100c6]
/home/container/garrysmod/bin/lua_shared_srv.so(+0x236cb)[0xedb106cb]
/home/container/garrysmod/bin/lua_shared_srv.so(+0x18e79)[0xedb05e79]
/home/container/garrysmod/bin/server_srv.so(+0x6b8d42)[0xf1e23d42]
/home/container/bin/engine_srv.so(+0xe649b)[0xf5a3d49b]
/home/container/bin/engine_srv.so(+0xe68cc)[0xf5a3d8cc]
/home/container/bin/engine_srv.so(+0x13c320)[0xf5a93320]
/home/container/bin/engine_srv.so(+0x149648)[0xf5aa0648]
/home/container/bin/engine_srv.so(+0x149926)[0xf5aa0926]
/home/container/bin/engine_srv.so(+0x14996d)[0xf5aa096d]
/home/container/bin/engine_srv.so(+0x1da3f9)[0xf5b313f9]
/home/container/bin/engine_srv.so(+0x1d7cc6)[0xf5b2ecc6]
bin/dedicated_srv.so(+0x973ba)[0xf6f223ba]
/home/container/bin/engine_srv.so(+0x1d7d6d)[0xf5b2ed6d]
/home/container/bin/engine_srv.so(+0x22e818)[0xf5b85818]
/home/container/bin/engine_srv.so(+0x1d807d)[0xf5b2f07d]
bin/dedicated_srv.so(+0x97078)[0xf6f22078]
bin/dedicated_srv.so(+0xf6098)[0xf6f81098]
bin/dedicated_srv.so(+0xf6098)[0xf6f81098]
bin/dedicated_srv.so(+0x418fa)[0xf6ecc8fa]
./srcds_linux[0x8048aab]
/lib/i386-linux-gnu/libc.so.6(__libc_start_main+0x106)[0xf7c9ce46]
./srcds_linux[0x8048c33]

Lua Stack:
[C][+0] [C] in STORMFOX_CLEANUPMAP
[L][+1] lua/autorun/stormfox2.lua:223 in field CleanUpMap Line 213 -> 224
[m][+2] lua_run:1 in anonymous function Line 0 -> 1

End of stack trace

Here is the log.

A Small but noticeable cosmetic issue I came across

The rain fog particles seem to be a bit off since sometimes when they lift or stop and stay still a pretty abrupt sharp edge leading to a sudden nothing at the bottom, not sure what is causing this as It mostly happens when I'm walking and standing still, though it sometimes gets a bit crazy when running, I also have tested it on some other maps and discovered the issue isn't linked to a single map, though at the moment I only have 2 different maps screenshotted with it occurring.

I am very sorry if this is the incorrect place to put this. Thank you.

And here are some pictures as an example.

Support for obfuscated maps

Stormfox 2, is able to correctly load maps with obfuscation, if the lump file is next to the source, to match the loader support, but.

If the lump file is only on the server, and the client does not have it, then the client will have errors.

for example one of them:
stormfox2/lua/stormfox2/lib/sh_mapglass.lua:646: bad argument #1 to 'pairs' (table expected, got nil)

[v2.08] Timer Failed! - Dusk/dawn events

I've noticed that whenever the game time or weather ticks over, the dusk and dawn events don't seem to trigger. I have two relays in my map called dusk and dawn.

This particular error happened at dawn:

[StormFox 2] lua/stormfox2/functions/sv_mapio.lua:22: Tried to use a NULL entity!
  1. Fire - [C]:-1
   2. setELight - lua/stormfox2/functions/sv_mapio.lua:22
    3. unknown - lua/stormfox2/functions/sv_mapio.lua:31

Timer Failed! [StormFox2.mi.lights][@lua/stormfox2/functions/sv_mapio.lua (line 29)]

1. Set the time a few minutes prior to either dusk or dawn.
2. Allow Stormfox to tick over the time.
3. There should be a script error in the console.
4. Relays won't have triggered.

[Suggestion] Temperature-related entities

Would be cool to have some kind of fireplace or a torch, which (on a snow weather) will "melt down" the snow near it.
I think it could be made with the help of a displacement alpha

Major issue with emitters

I've been debugging a major crash lag issue I've been experiencing for a few weeks now, and I've come to the conclusion that StormFox is to blame.

The issue in question is: CUtlLinkedList overflow! (exhausted memory allocator). I've done exhaustive testing with and without StormFox, and the issue only occurs when SF is on the server.

I believe the issue is that you never run the Finish() function on your particle emitters. Because of this, your particle emitters are never released from memory. This is why this issue only happens after a player has been on the server for a while.

Stars visible through unlit side

Stars can be seen through the unlit side of the moon

Clicking on the "Materials" button in the server window's effects tab creates a lua error

Go to the server window and click on effects then click on the Materials button and you'll get this error:

[StormFox 2] RunConsoleCommand: Command is blocked! (+mat_texture_list)
  1. DoClick - lua/stormfox2/functions/cl_menu_sv.lua:1007
   2. unknown - lua/vgui/dlabel.lua:237

RedownloadAllLightmaps causes crashed

Whenever time changes and the lightmaps are getting redownloaded, 80% of all players crash.
In their crashlog always appears the same error:

-Lua Stack Traces-
  Client
    0. RedownloadAllLightmaps - [C]:-1
      1. (null) - addons/stormfox2/lua/stormfox2/framework/sh_maplight.lua:124

  Server
    Lua Interface = NULL

  MenuSystem
    *Not in Lua call OR Lua has panicked*

I tried to reproduce the crash on an empty server but didn't achieve it.

[Suggestion] Support Instanced Relays

I've noticed that a relay with the name of instanceauto6-dawn or dawn-instanceauto6 won't trigger at dawn, and I assume the same can be said for dusk relays. I would just use func_instance_io_proxy to feed a dawn or dusk relay in the map to the instanced entities, but func_instance_io_proxy doesn't exist in GMod's Hammer.

Footstep sound will not be replaced when moving with jumps

I think it's problems with noSpam check. When you moving and jump at the same time, you emit multiple sounds which are ignored by GetFootstep in StormFox2.footstep.detecter and we can hear original footstep sound. I get fixed this when copy noSpam check into StormFox2.lastfootprint, but idk how correct it is.

ADD STORM HAIL

Hail can be added

error when loading TF2 map cp_5gorge

[StormFox 2] lua/stormfox2/framework/cl_envioment.lua:921: lua/stormfox2/framework/cl_envioment.lua:667: bad argument #1 to 'ipairs' (table expected, got no value)
    1. cor_scan - [C]:-1
        2. unknown - lua/stormfox2/framework/cl_envioment.lua:921

sometimes surf can be nil, i'm not sure what the correct behavior is in this circumstance so i can't adequately submit a PR for it

StormFox2/lua/stormfox2/framework/cl_envioment.lua

Line 667 in 3a25356

for _,t in ipairs(surf:GetMesh()) do