Comments (9)
It would be even nicer to have the "real" font-awesome included, maybe, if possible as submodule. I patched my own fork but its kinda dirty. If there is interest, I can create a PR.
from pelican-alchemy.
Please update font awesome.
I would like to use the "strava" icon but it's only awailable from version Version 5.8.0.
Thanks.
from pelican-alchemy.
Hello, I've recently joined pelican-alchemy dev team and I am available to fix this issue. Unfortunately, I have no experience with Font Awesome, so I'm not sure how to proceed.
From what I've gathered we provide a copy of Font Awesome stylesheet and font files along with the theme. Our version is 4.7.0 and current upstream version is 5.11.2.
How did we generate the bundled version in the first place? Did we select one of "kits" that are mentioned on the FA website? Or did we use some repacking tool to select a subset of provided glyphs?
Version 5 is not backwards-compatible because of CSS class renaming, fa
was split into fab
and fas
- how do we handle user-specified ICONS
? Do we assume them always to be brands, like suggested here?
PS: as a workaround for now you can refer to any new CDN hosted version of Font Awesome with THEME_CSS_OVERRIDES
from pelican-alchemy.
I don't have much experience in FontAwesome myself... In efa3235 I merely followed the instructions on the FA website, and changed the fa
class in the theme to the appropriate fab
or fas
. I think I did this exhaustively. Regarding user-specifed ICONS
, I did assume that they would all be brands, because that matched my own use-case, but this indeed a debatable choice.
What's wrong with using the CDN? This lowers the burden on the server hosting the Pelican website, and this makes it more likely that the client reuses a cached version (from another website also using the CDN). And users preferring to host their own version could still use THEME_CSS_OVERRIDES
, but they would be responsible of retrieving the files... ;-)
from pelican-alchemy.
I agree on the benefits of CDN but I would rather have it as an opt-in instead of opt-out feature.
CDN is very much the first-world only solution. When every party involved behaves the way they are expected to - it works. When any of them do something unexpected - it doesn't and can't be made to work. I'm sure you've heard of the Great Firewall of China; India, Russia, some African countries are doing similar things. You never know which URL or IP might become inaccessible (e.g. mail.python.org is blocked in Russia - who would've thought, huh?) - but with your own web server you at least can do something about it.
Also, some users might be concerned about the privacy issue. Using CDN exposes all your visitors to tracking by the CDN owner, whom you can not control and can only trust (more or less blindly).
from pelican-alchemy.
Fair enough.
from pelican-alchemy.
Just FYI, I think #85 would address this issue, without needing a CDN.
from pelican-alchemy.
Based on works of @pchampin and @aquatix I've come up with a solution that shouldn't break existing setups.
For now it's in sio/font-awesome
branch. I'll leave it there for a few days to gather comments and to have a fresh look at it before merging. Any feedback is very welcome!
from pelican-alchemy.
Font Awesome 5.12 is now available in master
. I'm closing this issue.
from pelican-alchemy.
Related Issues (20)
- Update README.md
- Start tagging releases HOT 2
- Add semantic markup to templates HOT 1
- Update to Bootstrap 3.3.6 HOT 1
- Not clear how to get the feed icon to appear on the main page as shown in the example HOT 2
- Take ✨ Alchemy to the next level HOT 13
- Pages didn't show HOT 2
- Update Bootstrap to v4 Alpha 6
- How to add cover background? HOT 3
- pelican-alchemy is just great HOT 1
- unable to make a dropdowns menu :( HOT 2
- Include jQuery, Popper.js, and Bootstrap JavaScript assets HOT 2
- the path of site image is wrong
- Chinese characters in Code Block is ugly. HOT 2
- Merge PR #74 for Pelican 4.x HOT 2
- Applying for commit access to nairobilug/pelican-alchemy HOT 2
- Update demo web site HOT 2
- Add max-width property to all images?
- Changes to google analytics HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from pelican-alchemy.