Coder Social home page Coder Social logo

Comments (13)

alanorth avatar alanorth commented on June 3, 2024 1

Try using the new GitHub Projects workflow to track issues and pull requests for this milestone. 👍

from pelican-alchemy.

alanorth avatar alanorth commented on June 3, 2024 1

Feedback:

  • New site is 230KiB, old site is 178KiB ⚠️
  • Old site is including bootstrap.min.js and jquery.min.js and I'm pretty sure we're only using the CSS grid parts of Bootstrap, so we could actually even get rid of ~50KiB more on the old site 🔥
  • New site includes ~30KiB of fonts, which we should probably not be using anyway (switch to native font stacks, they are pretty good on all platforms now) ⚠️
  • Ideally the four CSS assets would be combined and minified, but I know you want to keep build dependencies simple (maybe we can just pre-generate them and give build instructions like in my Hugo Bootstrap v4 theme) ⚠️
  • I love the use of Font Awesome for tag and category icons etc in the new theme 🙌
  • The new theme performs much better on the w3c validator (only one minor issue, compared to a dozen on the old theme) ﷺ

Really awesome work, @rwanyoike. I think this can absolutely replace the current theme immediately as is. It already has feature/functional parity with the old theme, provides extra value, and is more standards compliant—we can fix the rest after the switch.

from pelican-alchemy.

rwanyoike avatar rwanyoike commented on June 3, 2024

It's taken shape https://rwanyoike.github.io/pelican-alchemy/

from pelican-alchemy.

alanorth avatar alanorth commented on June 3, 2024

Page no function!

from pelican-alchemy.

rwanyoike avatar rwanyoike commented on June 3, 2024

from pelican-alchemy.

alanorth avatar alanorth commented on June 3, 2024

Ah, it's working now. Looks great, but so does the original pelican-alchemy. It would be good to see them side by side with the same content.

from pelican-alchemy.

rwanyoike avatar rwanyoike commented on June 3, 2024

you're right! I got gh-pages to work on my fork, https://rwanyoike.github.io/nairobilug.or.ke/ <-> https://nairobilug.or.ke/.

from pelican-alchemy.

alanorth avatar alanorth commented on June 3, 2024

Mash'allah. ﷲ. It looks fantastic, dude. I'll do a closer look tomorrow to try and quantify how zesty the improvement is.

One improvement could be to just bite the bullet and switch to Bootstrap v4 though, or at least to steal its native font CSS stuff. I am using it on my Hugo blog theme and it looks great on all modern platforms and is quick to load.

from pelican-alchemy.

rwanyoike avatar rwanyoike commented on June 3, 2024

Just for the rem's 🤘

Here's the same with bootstrap v4, ported, with a bunch of 'fixes'. How does it compare: https://rwanyoike.github.io/nairobilug.or.ke2

https://rwanyoike.github.io/nairobilug.or.ke - bootstrap v3
https://nairobilug.or.ke/

from pelican-alchemy.

alanorth avatar alanorth commented on June 3, 2024

Heh, the Typography on the Bootstrap v4 one looks like crap actually. WTF? The typography on my blog looks much better and it's just plain Bootstrap v4—what's up with the fonts on your new version?

A bonus is that this new version is 30KiB smaller though, and Bootstrap v4 will be more future proof anyways.

from pelican-alchemy.

rwanyoike avatar rwanyoike commented on June 3, 2024

from pelican-alchemy.

alanorth avatar alanorth commented on June 3, 2024

Great success, I shift-refreshed and now I see it. Looks great. Ship it!

By the way, for my blog I shaved off 50+ KiB by using a custom Bootstrap that only includes the typography and grid stuff, as well as only including CSS for Font Awesome icons I was using.

I know one of the goals was to keep the dependencies low, but you could pre-generate these in the theme and then only people who know how or need to change them would need npm.

from pelican-alchemy.

rwanyoike avatar rwanyoike commented on June 3, 2024

We can definitely can work on theme size and performance using these tips! Ref. #54

from pelican-alchemy.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.