naghamfarwati / hyf-javascript Goto Github PK

Hey Nagham How are you,
As i said it's simple to get solve the object issue, and as Mr. Jim has said yeah it's the best way to get the object as what you did.
Actually i played around the code and i solved it, not really big issue just want some focusing you will find the solution Here AND Live Here.
Good Luck 👍

Hi Nagham,

I have taken your version of the homework and adapted it a bit to make it closer to what was asked in the homework assignment. In particular, your books array was supposed to be an object (see step 4 in the assignment). Although this does not make much difference for the end-result (your web page looks fine), it is a deviation from the assignment. My adapted version is here: https://github.com/remarcmij/class12-js/tree/master/week3/nagham-dom.

P.S. I still see some var's in your code. While not wrong, we recommend let and const over var.

hey Nagham,

good job u have done well, but you have 2 issues in your code in line 20 and 23
what u should do is to call the callback not the function

if (i % 3 === 0) {
threeCallback(i);
}

good luck

Hi Nagham,

The one remark which I would like to make is about adding a new method to the Array prototype. While I commend you for grasping the underlying concept this is not normally something you should do in your own code.

When you start to write larger applications you will be using third-party libraries of JavaScript code. By adding or changing the prototype of a built-in JavaScript object this change or addition is not limited to your own piece of JavaScript but is visible to all other running JavaScript code (it is in the global scope). So you cannot predict how your change will affect third-party code. It is best to avoid this situation altogether.