mycryptohq / mycrypto.com

Legacy version of MyCrypto.com. Was used in production from 2015-2018. See https://github.com/MyCryptoHQ/mycrypto for up-to-date codebase

MyCrypto

• Web
• Support
• Twitter
• Blog
• Github
• Reddit
• Facebook
• LinkedIn

Download the Latest Release

• https://github.com/MyCryptoHQ/mycrypto.com/releases

Developers

• If you would like to contribute, please look at our new and improved React/Typescript Repo

• master is the working / development branch

• gh-pages contains only the smaller dist folder only and is served to MyCrypto.com

If you would like to play around with this one for whatever reason:

First, clone the repo and cd into the working directory. Then...

$ npm install

$ npm run dev

Open the resulting dist/index.html file in your browser.

Gulp will auto-build it upon save.

To Prep for Production

$ gulp prep

$ gulp zipit

License

Adapted from https://github.com/kvhnuke/etherwallet

Copyright (c) 2015-2017 MyEtherWallet LLC

Copyright (c) 2018 MyCrypto, Inc.

mycrypto.com's Issues

Remove "try the latest beta"

Post-footer link goes nowhere

From Michael (blurspec):

"You are responsible for your security" disclaimer link at the bottom of every page is dead.

Swap with ShapeShift promo is unreadable

The logo uses white text, so it's white text on white background.

Parity Phrase help link dead

Description

Clicking on the help link for Parity Phrase leads to a dead link

Add new ci setting for mycrypto.com

Is there any ci server or services for mycrypto.com gh-pages release?

Firefox doesn't work, throws errors

Opening the page on Firefox shows the following errors (Firefox 57.0.4)

TypeError: setting getter-only property "u2f"

Error: [$injector:modulerr] Failed to instantiate module mycryptoApp due to:
[$injector:nomod] Module 'mycryptoApp' is not available!

The page is blank and fails to respond to any input after this.

Broken nav bar on helpers.html

When you are on https://www.mycrypto.com/helpers.html and try to use the nav bar's buttons the URL changes, but you're left with the helpers.html still displayed.

Before button click:

After button click:

Zip missing for v3.14.0 - Release

I'm not totally concerned with the missing zip for v3.14.0 so long as the next release has a zip 😄

Not sure why it wasn't included in the release?

Bug when generating contract transaction offline

When I try to generate a contract transaction offline using this guide: https://coss.io/coss-token-based-fee-split-allocation-tutorial, I get the following javascript error:

TypeError: data[0] is undefined
Stack trace:
[63]</customNode.prototype.getTransactionData/<@file:///home/ghost/crypto/mycrypto-v3.12.0/js/mycrypto-master.js:8076:9
[63]</customNode.prototype.rawPost/<@file:///home/ghost/crypto/mycrypto-v3.12.0/js/mycrypto-master.js:8133:9
processQueue@file:///home/ghost/crypto/mycrypto-v3.12.0/js/mycrypto-master.js:45350:39
scheduleProcessQueue/<@file:///home/ghost/crypto/mycrypto-v3.12.0/js/mycrypto-master.js:45399:9
$digest@file:///home/ghost/crypto/mycrypto-v3.12.0/js/mycrypto-master.js:46508:17
$apply@file:///home/ghost/crypto/mycrypto-v3.12.0/js/mycrypto-master.js:46797:15
done@file:///home/ghost/crypto/mycrypto-v3.12.0/js/mycrypto-master.js:40895:38
completeRequest@file:///home/ghost/crypto/mycrypto-v3.12.0/js/mycrypto-master.js:41131:9
requestError@file:///home/ghost/crypto/mycrypto-v3.12.0/js/mycrypto-master.js:41060:11
 Possibly unhandled rejection: {}

I used the code from mycrypto-v3.12.0.zip
The error happen when I click on "Generate transaction"

Error Code Labeling Mismatch

Mismatch between error code id and error code description.

Fix <title> to reflect legacy

Guide on how to run offline doesn't apply anymore

I just wanted to make you folks aware that the description on how to run MyCrypto locally doesn't apply anymore.

There is no index.html that the user could run without installing dependencies and running the build before.

register eos tokens offline

Is there a way to register eos tokens offline?
ie generate/sign the transaction offline and only publish online (not have to enter private mycrypto keys on an online computer)?

Please add NTK

It seems impossible to sign a transaction offline for a token (eg NTK) that is not already in the list of default tokens?
ie "add a custom token" and "send offline" cant be combined?

If so, can you please add NTK as a default token asap, as I want to move it (offline).

Many thanks in Advance.

https://etherscan.io/token/0x69beab403438253f13b6e92db91f7fb849258263

Sidebar Tokens issues

From Michael (blurspec):

"Show all tokens" button does not function correctly (No tokens list). Trying to add a custom token using the "Add Custom Token" button displays error message "Default Node does not exist. Please clear local storage and try again." It should be noted that the custom token error only shows on the ETH (mycryptoapi.com) node. Otherwise, it correctly shows that I'm trying to add a default token. Default token list, however, still does not show.

how to join to translate it into Chinese?

Etherscan api key in public

Hello, MyCrypto Team!
You didn't hide etherscan api key

mycrypto.com/app/scripts/nodeHelpers/etherscan.js

Line 113 in feb64ca

data.apikey = 'DSH5B24BQYKD1AD8KUCDY3SAQSS6ZAU175';

Someone could make many requests to etherscan with this api key, and it will be blocked

We (https://ethadmin.com) prefer put such api keys in conf.json and don't keep it in github. And we've added conf.json to .gitignore

mew.giveth.io node doesnt work on local version

Error message from dev tools
2index.html#send-transaction:1 Failed to load https://mew.giveth.io/: Response to preflight request doesn't pass access control check: The 'Access-Control-Allow-Origin' header has a value 'http://null' that is not equal to the supplied origin. Origin 'null' is therefore not allowed access.

Contract function call arguments not returning same result as Remix and etherscan

Having some issues with calling a function on a deployed contract (rinkeby).

When calling the function on remix or etherscan, it returns true, but when trying to call the same function with the same arguments on MyCrypto (MEW as well), then function returns false. The function requires the v,s,r arguments for the ecrecover() function in solidity.

MyCrypto

Remix

Etherscan

The 4 input arguments I am using are ;
_add : "0xd046b3c521c0f5513c8a47eb3c2011684ea80b27",
v : "0x1b",
r : "0x11e64b1e177fc75b859b4e55182e09b96b4518349c8a9ab438dac568ac78e7d3",
s : "0x4a0843d860a38bfa5fecb393959b5ea8fd35803ab8935af9ec84d268e00e6b3f"

Sub 1gwei TX Gasprice options or Mwei Options

Hi,

it's quite not user-friendly right now to make sub-1gwei Tx on Mycrypto.com, can we change that ?
Maybe a custom gasprice box ? or a Mwei/Kwei (in the future) option?

3.15.0 release zip file has old filename 3.12.0

filename for the folder is older version... consider automating this :-D

Enhancement: Add, "ARY" to list of ETH Tokens

We would like to ask that ARY, the Block Array ERC-20 Token be added to the MyCrypto list of tokens please.

Website: www.blockarray.com

Etherscan Token Contract: https://etherscan.io/address/0xa5F8fC0921880Cb7342368BD128eb8050442B1a1

Json:

{ "address":"0xa5F8fC0921880Cb7342368BD128eb8050442B1a1", "symbol":"ARY", "decimal":18, "type":"default" }

Please let us know if you require any other information or if we should submit a pull request!

Keep up the good work and thank you!

twitter: @blockarraygroup

Tag initial release

Hi, might be worth tagging a release so the info on this page is accurate.

[View Info via MetaMask] Unable to Print Paper Wallet

Description of the Issue

When going to "View Info" and connecting via MetaMask, pressing the "Print Paper Wallet" button is unresponsive.

Steps to Reproduce

1. Go to https://mycrypto.com/#view-wallet-info
2. Click MetaMask/Mist (issue cannot be reproduced when viewing via Keystore or Private Key)
3. Connect to MetaMask, and go to your wallet info
4. Click "Print Paper Wallet."

Description of Your Machine

Google Chrome Version 65.0.3325.181 (Official Build) (64-bit)
MacOS High Sierra Version 10.13.3 (17D47)

Console Logs / Screenshots

n/a

Remove Link/Update Copy

Onboarding Slide - remove "or the MyCrypto extension" (copy and link)
https://pbs.twimg.com/media/Dacxb0mW0AExpKg.jpg

Typo in "private key warning" text

Currently: Entering your private key on a website dangerous.

Correct to: Entering your private key on a website is dangerous.

Cannot install locally - npm error: No such file - node_modules/dezalgo

I wanted to try running mycrypto locally. I have not been able to start it. Neither the 3.14.0 tag, nor the master branch nor the beta 0.64

Maybe I just don't understand all this npm stuff. Is there no way to just download a complete, packaged, offline version?

anyway; any help with the issue below is appreciated.

HEAD is now at a96da8e... Bump version to 3.14.0 (#82)


root@eth-work:/home/user/mycrypto/mycrypto.com# npm install 
npm WARN [email protected] No repository field.

npm ERR! path /home/user/mycrypto/mycrypto.com/node_modules/npm/node_modules/dezalgo
npm ERR! code ENOENT
npm ERR! errno -2
npm ERR! syscall rename
npm ERR! enoent ENOENT: no such file or directory, rename '/home/user/mycrypto/mycrypto.com/node_modules/npm/node_modules/dezalgo' -> '/home/user/mycrypto/mycrypto.com/node_modules/npm/node_modules/.dezalgo.DELETE'
npm ERR! enoent This is related to npm not being able to find a file.
npm ERR! enoent 

npm ERR! A complete log of this run can be found in:
npm ERR!     /root/.npm/_logs/2018-03-30T15_08_04_536Z-debug.log

Messages signed with a Trezor don't verify without a Trezor

The signed message verification doesn't work properly for Trezors. It currently requires that any message signed with a trezor is verified with a trezor.

https://github.com/MyCryptoHQ/mycrypto.com/blob/master/app/scripts/controllers/signMsgCtrl.js#L150

I believe this code was inherited from MyEtherWallet, although MEW has updated their code to correct this issue:

https://github.com/kvhnuke/etherwallet/blob/mercury/app/scripts/controllers/signMsgCtrl.js#L178

Would be nice if MyCrypto did the same.