mycroftai / skill-stop Goto Github PK

Is your feature request related to a problem? Please describe.
Currently language files are split across locale and vocab.

Describe the solution you'd like
These can be merged under locale and consideration for a better file structure within that directory should be given.

Context
locale is a newer addition that can store all language files. The older convention is to split these across dialog, regex and vocab directories. Each locale/lang-code/ directory can contain any type of sub-directory structure and Mycroft will traverse these. However each language directory should be kept consistent.

There was a change in the intent from .require("StopKeyword") to .require("Stop"), but only the en-us vocab-file was renamed to "Stop.vocab". This renders this skill useless for languages other than "en-us".

possible solutions:

1. change intent back to .require("StopKeyword")and rename en-us vocab-file only
2. rename all vocab-files in the lang subfolders

I tried using it as "hey mycroft ... stop" during the wiki skill, but either mycroft isn't listening at that time, or else can't hear my over itself.

You must have recently updated this to be more flexible with the use of the phrase "turn off" because this skill now conflicts with my Domoticz Skill. Now when I say something like "turn off the lights" and instead of turning off the lights it asks "confirming, you want me to turn myself off?" It's annoying. The skill should require something like "yourself"